Open editor with clean env

Editors which have ruby embedded may be confused by bundler's
environment, so strip it before launching the editor process.

2 files changed, 8 insertions, 1 deletions

diff --git a/lib/bundler/cli/open.rb b/lib/bundler/cli/open.rb
index d4dba703cd..0bbfa63d34 100644
--- a/lib/bundler/cli/open.rb
+++ b/lib/bundler/cli/open.rb
@@ -16,7 +16,9 @@ module Bundler
       path = Bundler::CLI::Common.select_spec(name, :regex_match).full_gem_path
       Dir.chdir(path) do
         command = Shellwords.split(editor) + [path]
-        system(*command) || Bundler.ui.info("Could not run '#{command.join(" ")}'")
+        Bundler.with_clean_env do
+          system(*command)
+        end || Bundler.ui.info("Could not run '#{command.join(" ")}'")
       end
     end
   end
diff --git a/spec/commands/open_spec.rb b/spec/commands/open_spec.rb
index 6fa219f889..1776eed6e9 100644
--- a/spec/commands/open_spec.rb
+++ b/spec/commands/open_spec.rb
@@ -78,4 +78,9 @@ describe "bundle open" do
     bundle "open rails", :env => { "EDITOR" => "echo editor", "VISUAL" => "", "BUNDLER_EDITOR" => "" }
     expect(out).to include("Installing foo 1.0")
   end
+
+  it "opens the editor with a clean env" do
+    bundle "open", :env => { "EDITOR" => "sh -c 'env'", "VISUAL" => "", "BUNDLER_EDITOR" => "" }
+    expect(out).not_to include("BUNDLE_GEMFILE=")
+  end
 end