diff options
author | Samuel Giddins <segiddins@segiddins.me> | 2017-04-30 10:26:59 +0200 |
---|---|---|
committer | Samuel Giddins <segiddins@segiddins.me> | 2017-06-13 11:12:23 -0500 |
commit | dd5839c7a95137cac2201099844077e09a0b88de (patch) | |
tree | df6e84d191b7f7cebb83fe5b1ff0bd8f6f188179 | |
parent | 889219151390924ba3bc03550c6b53980a8b1987 (diff) | |
download | bundler-dd5839c7a95137cac2201099844077e09a0b88de.tar.gz |
Remove quality spec for single quotes
RuboCop already includes this check
-rw-r--r-- | spec/quality_spec.rb | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb index db019e03de..d8ae027e34 100644 --- a/spec/quality_spec.rb +++ b/spec/quality_spec.rb @@ -6,17 +6,6 @@ if defined?(Encoding) && Encoding.default_external.name != "UTF-8" end RSpec.describe "The library itself" do - def check_for_spec_defs_with_single_quotes(filename) - failing_lines = [] - - File.readlines(filename).each_with_index do |line, number| - failing_lines << number + 1 if line =~ /^ *(describe|it|context) {1}'{1}/ - end - - return if failing_lines.empty? - "#{filename} uses inconsistent single quotes on lines #{failing_lines.join(", ")}" - end - def check_for_debugging_mechanisms(filename) debugging_mechanisms_regex = / (binding\.pry)| @@ -128,18 +117,6 @@ RSpec.describe "The library itself" do expect(error_messages.compact).to be_well_formed end - it "uses double-quotes consistently in specs" do - included = /spec/ - error_messages = [] - Dir.chdir(File.expand_path("../", __FILE__)) do - `git ls-files -z`.split("\x0").each do |filename| - next unless filename =~ included - error_messages << check_for_spec_defs_with_single_quotes(filename) - end - end - expect(error_messages.compact).to be_well_formed - end - it "does not include any leftover debugging or development mechanisms" do exempt = %r{quality_spec.rb|support/helpers} error_messages = [] |