Merge #6834

6834: Allow files other than Gemfile.lock to be opened in definition specs r=hsbt a=segiddins

### What was the end-user problem that led to this PR?

The problem was the specs are brittle.

### What was your diagnosis of the problem?

My diagnosis was  we should assume code can open other files.

### What is your fix for the problem, implemented in this PR?

My fix allows other files to be opened, and only raises when opening the file under test.

Co-authored-by: Samuel Giddins <segiddins@segiddins.me>

1 files changed, 2 insertions, 0 deletions

diff --git a/spec/bundler/definition_spec.rb b/spec/bundler/definition_spec.rb
index 2ed87ec81d..ceb7b4bf05 100644
--- a/spec/bundler/definition_spec.rb
+++ b/spec/bundler/definition_spec.rb
@@ -13,6 +13,7 @@ RSpec.describe Bundler::Definition do
       subject { Bundler::Definition.new(nil, [], Bundler::SourceList.new, []) }
 
       it "raises an PermissionError with explanation" do
+        allow(File).to receive(:open).and_call_original
         expect(File).to receive(:open).with("Gemfile.lock", "wb").
           and_raise(Errno::EACCES)
         expect { subject.lock("Gemfile.lock") }.
@@ -23,6 +24,7 @@ RSpec.describe Bundler::Definition do
       subject { Bundler::Definition.new(nil, [], Bundler::SourceList.new, []) }
 
       it "raises a TemporaryResourceError with explanation" do
+        allow(File).to receive(:open).and_call_original
         expect(File).to receive(:open).with("Gemfile.lock", "wb").
           and_raise(Errno::EAGAIN)
         expect { subject.lock("Gemfile.lock") }.