diff options
| author | The Bundler Bot <bot@bundler.io> | 2017-07-05 06:24:04 +0000 |
|---|---|---|
| committer | The Bundler Bot <bot@bundler.io> | 2017-07-05 06:24:04 +0000 |
| commit | e6403e870087b8b37d1ee79e85afd53af4b3acbf (patch) | |
| tree | dfaf850fe8510cfb684884607fe28bb4d25e4c72 | |
| parent | 955c131ceb3c6238babea4a65e9e35c534dd7ebf (diff) | |
| parent | 738841b394de63d64330b12ed6c3bdd786471b2a (diff) | |
| download | bundler-e6403e870087b8b37d1ee79e85afd53af4b3acbf.tar.gz | |
Auto merge of #5829 - bundler:colby/vcr-cassettes-illegal-path-chars, r=segiddins
remove forbidden chars in cassettes pathname
### What was the end-user problem that led to this PR?
Users running Micorsoft Windows are currently unable to clone to Bundler project due to a forbidden character in the folder path:
`spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies?gems=bundler'`
The `?` being the forbidden character.
See #5828
### What is your fix for the problem, implemented in this PR?
Replaced the forbidden character in the folder name with a `-` and updated the VCR spec helper to replace any forbidden character with a `-` in the filename function.
### Why did you choose this fix out of the possible options?
This was the most simple approach to fix the issue.
| -rw-r--r-- | spec/support/artifice/vcr.rb | 2 | ||||
| -rw-r--r-- | spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies-gems=bundler/GET/request (renamed from spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies?gems=bundler/GET/request) | 0 | ||||
| -rw-r--r-- | spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies-gems=bundler/GET/response (renamed from spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies?gems=bundler/GET/response) | bin | 13564 -> 13564 bytes |
3 files changed, 1 insertions, 1 deletions
diff --git a/spec/support/artifice/vcr.rb b/spec/support/artifice/vcr.rb index 9db0053e6c..dff87e87f1 100644 --- a/spec/support/artifice/vcr.rb +++ b/spec/support/artifice/vcr.rb @@ -74,7 +74,7 @@ class BundlerVCRHTTP < Net::HTTP end def file_name_for_key(key) - key.join("/") + key.join("/").gsub(/[\:*?"<>|]/, "-") end def request_pair_paths diff --git a/spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies?gems=bundler/GET/request b/spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies-gems=bundler/GET/request index 00dcd51750..00dcd51750 100644 --- a/spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies?gems=bundler/GET/request +++ b/spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies-gems=bundler/GET/request diff --git a/spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies?gems=bundler/GET/response b/spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies-gems=bundler/GET/response Binary files differindex 2dd5aa76f8..2dd5aa76f8 100644 --- a/spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies?gems=bundler/GET/response +++ b/spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies-gems=bundler/GET/response |