diff options
| author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2018-09-26 13:14:14 -0300 |
|---|---|---|
| committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2018-10-03 08:48:56 -0300 |
| commit | 9d4c99ca617f3a6ec7bf3610e59285056000e875 (patch) | |
| tree | 07bb22aa2971aecf7159ffe5628904471a34ce95 | |
| parent | d7365389a65b0b8ebdd150f84c55d792e6e7e2de (diff) | |
| download | bundler-9d4c99ca617f3a6ec7bf3610e59285056000e875.tar.gz | |
Hangs in specs improved
When working on a bug, I was getting a hang inside the subprocess of a
specs, and it was hard to debug because any logging I added was not
visible. This reording makes logging visible and can make it easier to
troubleshoot these cases.
| -rw-r--r-- | spec/support/helpers.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb index e2b96f5d21..6735766db9 100644 --- a/spec/support/helpers.rb +++ b/spec/support/helpers.rb @@ -224,9 +224,9 @@ module Spec yield stdin, stdout, wait_thr if block_given? stdin.close - command_execution.exitstatus = wait_thr && wait_thr.value.exitstatus command_execution.stdout = Thread.new { stdout.read }.value.strip command_execution.stderr = Thread.new { stderr.read }.value.strip + command_execution.exitstatus = wait_thr && wait_thr.value.exitstatus end (@command_executions ||= []) << command_execution |