diff options
| author | Bundlerbot <bot@bundler.io> | 2019-04-01 23:10:10 +0000 |
|---|---|---|
| committer | Bundlerbot <bot@bundler.io> | 2019-04-01 23:10:10 +0000 |
| commit | cb062dff33331a067afa4ccd5d445de2100da3a4 (patch) | |
| tree | c6930a0fe3b0cb8bf6da9f749e4b7908f24fba7d | |
| parent | 63cc70aa2573345ebfb6bddaeef0b9d465591dd9 (diff) | |
| parent | a6c7c4fbb577bfadc608ba9a75c716adf943819c (diff) | |
| download | bundler-cb062dff33331a067afa4ccd5d445de2100da3a4.tar.gz | |
Merge #7090
7090: Make sure spec fails if gems cannot be installed r=hsbt a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was if the installation if system gems failed during specs failed, that was being silently ignored.
### What was your diagnosis of the problem?
My diagnosis was that if this installation fails, the specs that use this helper are not probably testing what they should
### What is your fix for the problem, implemented in this PR?
My fix is to use the bang method instead.
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
| -rw-r--r-- | spec/support/helpers.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb index f6c94208ab..b3d061c917 100644 --- a/spec/support/helpers.rb +++ b/spec/support/helpers.rb @@ -435,7 +435,7 @@ module Spec ENV["GEM_PATH"] = system_gem_path.to_s gems.each do |gem| - gem_command :install, "--no-document #{gem}" + gem_command! :install, "--no-document #{gem}" end return unless block_given? begin |