Merge pull request #2569 from fuadsaud/github-https

Use https:// instead of git:// on GitHub URL's

2 files changed, 3 insertions, 3 deletions

diff --git a/lib/bundler/dsl.rb b/lib/bundler/dsl.rb
index 947aca7ba8..7f88a1bc5d 100644
--- a/lib/bundler/dsl.rb
+++ b/lib/bundler/dsl.rb
@@ -230,7 +230,7 @@ module Bundler
 
       if github = opts.delete("github")
         github = "#{github}/#{github}" unless github.include?("/")
-        opts["git"] = "git://github.com/#{github}.git"
+        opts["git"] = "https://github.com/#{github}.git"
       end
 
       if gist = opts.delete("gist")
diff --git a/spec/bundler/dsl_spec.rb b/spec/bundler/dsl_spec.rb
index 610ff0b55e..1b05eb48b4 100644
--- a/spec/bundler/dsl_spec.rb
+++ b/spec/bundler/dsl_spec.rb
@@ -9,7 +9,7 @@ describe Bundler::Dsl do
   describe "#_normalize_options" do
     it "converts :github to :git" do
       subject.gem("sparks", :github => "indirect/sparks")
-      github_uri = "git://github.com/indirect/sparks.git"
+      github_uri = "https://github.com/indirect/sparks.git"
       expect(subject.dependencies.first.source.uri).to eq(github_uri)
     end
 
@@ -27,7 +27,7 @@ describe Bundler::Dsl do
 
     it "converts 'rails' to 'rails/rails'" do
       subject.gem("rails", :github => "rails")
-      github_uri = "git://github.com/rails/rails.git"
+      github_uri = "https://github.com/rails/rails.git"
       expect(subject.dependencies.first.source.uri).to eq(github_uri)
     end
   end