diff options
author | Bundlerbot <bot@bundler.io> | 2019-03-03 22:16:38 +0000 |
---|---|---|
committer | Bundlerbot <bot@bundler.io> | 2019-03-03 22:16:38 +0000 |
commit | d910751543ed58c00e85a6ca5e48bd7d776dafbd (patch) | |
tree | d980e5d99aab7db2b740dc5e3b66ca1e333d6ee8 | |
parent | 493b4438db43acd1f90228406fa6e6fda96009c8 (diff) | |
parent | 31a5e080c9424a9b024c8f5cb89e3dbb29a71a55 (diff) | |
download | bundler-d910751543ed58c00e85a6ca5e48bd7d776dafbd.tar.gz |
Merge #7010
7010: Use double quotes for `git commit -m` r=colby-swandale a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that Azure logs are full of "error: pathspec 'COMMIT'' did not match any file(s) known to git." and other similar ones.
### What was your diagnosis of the problem?
My diagnosis was that Windows' git doesn't like single quotes.
### What is your fix for the problem, implemented in this PR?
My fix is to use double quotes, which is also consistent with our global style.
### Why did you choose this fix out of the possible options?
I chose this fix because it brings the number of spec failures on Windows from 657 to 474! :tada:
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
-rw-r--r-- | spec/install/gemfile/git_spec.rb | 8 | ||||
-rw-r--r-- | spec/support/builders.rb | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/spec/install/gemfile/git_spec.rb b/spec/install/gemfile/git_spec.rb index aa19fa1ce0..cac571754c 100644 --- a/spec/install/gemfile/git_spec.rb +++ b/spec/install/gemfile/git_spec.rb @@ -221,7 +221,7 @@ RSpec.describe "bundle install with git sources" do end Dir.chdir(lib_path("foo-1.0")) do - `git update-ref -m 'Bundler Spec!' refs/bundler/1 master~1` + `git update-ref -m "Bundler Spec!" refs/bundler/1 master~1` end # want to ensure we don't fallback to HEAD @@ -257,7 +257,7 @@ RSpec.describe "bundle install with git sources" do end Dir.chdir(lib_path("foo-1.0")) do - `git update-ref -m 'Bundler Spec!' refs/bundler/1 master~1` + `git update-ref -m "Bundler Spec!" refs/bundler/1 master~1` end # want to ensure we don't fallback to HEAD @@ -282,7 +282,7 @@ RSpec.describe "bundle install with git sources" do it "does not download random non-head refs" do Dir.chdir(lib_path("foo-1.0")) do - sys_exec!("git update-ref -m 'Bundler Spec!' refs/bundler/1 master~1") + sys_exec!('git update-ref -m "Bundler Spec!" refs/bundler/1 master~1') end bundle! "config global_gem_cache true" @@ -1163,7 +1163,7 @@ RSpec.describe "bundle install with git sources" do void Init_foo() { rb_define_global_function("foo", &foo, 0); } C end - `git commit -m 'commit for iteration #{i}' ext/foo.c` + `git commit -m "commit for iteration #{i}" ext/foo.c` end git_commit_sha = git_reader.ref_for("HEAD") diff --git a/spec/support/builders.rb b/spec/support/builders.rb index 442623a415..33a81f6f65 100644 --- a/spec/support/builders.rb +++ b/spec/support/builders.rb @@ -649,7 +649,7 @@ module Spec `git config user.email "lol@wut.com"` `git config user.name "lolwut"` `git config commit.gpgsign false` - `git commit -m 'OMG INITIAL COMMIT'` + `git commit -m "OMG INITIAL COMMIT"` end end end |