summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBundlerbot <bot@bundler.io>2019-11-04 12:25:44 +0000
committerBundlerbot <bot@bundler.io>2019-11-04 12:25:44 +0000
commit46aead4739e079345b47b131f046775d515b332f (patch)
tree66f9f1be4faddb118bfefe146daf5f1b7bbdc1c8
parent1a585f5cd760ae4be6930fd38d262677faa3694c (diff)
parent82d29c78fa8b05379078100b87a4e761f2636cae (diff)
downloadbundler-46aead4739e079345b47b131f046775d515b332f.tar.gz
Merge #7399
7399: Fix some realworld specs testing nothing r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that this helper was printing nothing to the standard output, so the specs in this file were just checking if lockfiles contained the empty string, which is obviously true. For example, https://github.com/bundler/bundler/blob/e70643c1be3a4417bd537d7e63470265465e693e/spec/realworld/edgecases_spec.rb#L31 ### What was your diagnosis of the problem? My diagnosis was that the helper needs to actually print the extracted information about the resolved gem, so it can be checked that the lockfile is correct. ### What is your fix for the problem, implemented in this PR? My fix adds the missing `puts`. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
-rw-r--r--spec/realworld/edgecases_spec.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/realworld/edgecases_spec.rb b/spec/realworld/edgecases_spec.rb
index 26dd096b28..c7ec814df5 100644
--- a/spec/realworld/edgecases_spec.rb
+++ b/spec/realworld/edgecases_spec.rb
@@ -17,7 +17,7 @@ RSpec.describe "real world edgecases", :realworld => true, :sometimes => true do
raise "Could not find #{name} (#{requirement}) on rubygems.org!\n" \
"Found specs:\n\#{index.send(:specs).inspect}"
end
- "#{name} (\#{rubygem.version})"
+ puts "#{name} (\#{rubygem.version})"
RUBY
end