diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2018-10-01 20:23:15 -0300 |
---|---|---|
committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2018-10-01 21:26:22 -0300 |
commit | 9deb5447da89453c22686819782b034e62583b6b (patch) | |
tree | a8b7aafee664460fd975eabe12c3b264d7a31060 | |
parent | 3d9e6167a7df9ca89a030dfe95c7cdff293e74a9 (diff) | |
download | bundler-9deb5447da89453c22686819782b034e62583b6b.tar.gz |
Remove "no-color" tweaks from specs
I don't know why it was there, and it makes things more complicated with
dealing and running assertions on ARGV.
-rw-r--r-- | spec/bundler/cli_spec.rb | 6 | ||||
-rw-r--r-- | spec/other/cli_dispatch_spec.rb | 2 | ||||
-rw-r--r-- | spec/plugins/command_spec.rb | 2 | ||||
-rw-r--r-- | spec/support/helpers.rb | 3 |
4 files changed, 5 insertions, 8 deletions
diff --git a/spec/bundler/cli_spec.rb b/spec/bundler/cli_spec.rb index 16ca32ca19..73868d10fb 100644 --- a/spec/bundler/cli_spec.rb +++ b/spec/bundler/cli_spec.rb @@ -71,17 +71,17 @@ RSpec.describe "bundle executable" do it "prints the running command" do gemfile "" bundle! "info bundler", :verbose => true - expect(last_command.stdout).to start_with("Running `bundle info bundler --no-color --verbose` with bundler #{Bundler::VERSION}") + expect(last_command.stdout).to start_with("Running `bundle info bundler --verbose` with bundler #{Bundler::VERSION}") end it "doesn't print defaults" do install_gemfile! "", :verbose => true - expect(last_command.stdout).to start_with("Running `bundle install --no-color --retry 0 --verbose` with bundler #{Bundler::VERSION}") + expect(last_command.stdout).to start_with("Running `bundle install --retry 0 --verbose` with bundler #{Bundler::VERSION}") end it "doesn't print defaults" do install_gemfile! "", :verbose => true - expect(last_command.stdout).to start_with("Running `bundle install --no-color --retry 0 --verbose` with bundler #{Bundler::VERSION}") + expect(last_command.stdout).to start_with("Running `bundle install --retry 0 --verbose` with bundler #{Bundler::VERSION}") end end diff --git a/spec/other/cli_dispatch_spec.rb b/spec/other/cli_dispatch_spec.rb index a9d0bf7462..d17819b394 100644 --- a/spec/other/cli_dispatch_spec.rb +++ b/spec/other/cli_dispatch_spec.rb @@ -23,7 +23,7 @@ RSpec.describe "bundle command names" do it "dispatches `bundle cache` to the package command" do bundle "cache --verbose" - expect(last_command.stdout).to start_with "Running `bundle package --no-color --verbose`" + expect(last_command.stdout).to start_with "Running `bundle package --verbose`" end end end diff --git a/spec/plugins/command_spec.rb b/spec/plugins/command_spec.rb index 8275351d19..999d8b722b 100644 --- a/spec/plugins/command_spec.rb +++ b/spec/plugins/command_spec.rb @@ -49,7 +49,7 @@ RSpec.describe "command plugins" do bundle "plugin install the-echoer --source file://#{gem_repo2}" expect(out).to include("Installed plugin the-echoer") - bundle "echo tacos tofu lasange", "no-color" => false + bundle "echo tacos tofu lasange" expect(out).to eq("You gave me tacos, tofu, lasange") end diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb index e2b96f5d21..d64b3923d5 100644 --- a/spec/support/helpers.rb +++ b/spec/support/helpers.rb @@ -99,9 +99,6 @@ module Spec with_sudo = options.delete(:sudo) sudo = with_sudo == :preserve_env ? "sudo -E" : "sudo" if with_sudo - no_color = options.delete("no-color") { cmd.to_s !~ /\A(e|ex|exe|exec|conf|confi|config)(\s|\z)/ } - options["no-color"] = true if no_color - bundle_bin = options.delete("bundle_bin") || bindir.join("bundle") if system_bundler = options.delete(:system_bundler) |