diff options
| author | Bundlerbot <bot@bundler.io> | 2019-12-08 12:04:13 +0000 |
|---|---|---|
| committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-12-13 20:07:20 +0100 |
| commit | cd3fb55c06b18673f2cfbb946d6fc81375afa3ea (patch) | |
| tree | 8eb35790940d91f28670e5532620b10c7f5f965a /lib/bundler.rb | |
| parent | e101da16143ed4974099e0521dcc53bf3777aa45 (diff) | |
| download | bundler-cd3fb55c06b18673f2cfbb946d6fc81375afa3ea.tar.gz | |
Merge #7473
7473: Cleanup some unnecessary code r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was #7460 is very big so I want to extract these changes to a separate PR, so that we're more aware of them.
### What was your diagnosis of the problem?
My diagnosis was that this code can be removed. In particular, in the `GemRemoteFetcher` class there was the following comment
https://github.com/bundler/bundler/blob/25595896eb0f8dfd004d941093bf1d8f4a39aeeb/lib/bundler/gem_remote_fetcher.rb#L9-L10
After having a look, I think the comment would make sense if where it says "gemstash", it actually meant "bundler". That would make sense to me since this is about fetching remote specs, so I would assume it's the client side running it.
Assuming this is the correct interpretation, we can remove the code since our minimum supported rubygems version is 2.5.2, and this code was included in rubygems in 2.5.0.
### What is your fix for the problem, implemented in this PR?
My fix is to remove the `GemRemoteFetcher` class, plus simplify other related code.
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
(cherry picked from commit bada03dd6d4d15828fb5b2cf7f744948e88a69a3)
Diffstat (limited to 'lib/bundler.rb')
| -rw-r--r-- | lib/bundler.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/bundler.rb b/lib/bundler.rb index 3b494a6cdf..df345539c8 100644 --- a/lib/bundler.rb +++ b/lib/bundler.rb @@ -50,7 +50,6 @@ module Bundler autoload :FeatureFlag, File.expand_path("bundler/feature_flag", __dir__) autoload :GemHelper, File.expand_path("bundler/gem_helper", __dir__) autoload :GemHelpers, File.expand_path("bundler/gem_helpers", __dir__) - autoload :GemRemoteFetcher, File.expand_path("bundler/gem_remote_fetcher", __dir__) autoload :GemVersionPromoter, File.expand_path("bundler/gem_version_promoter", __dir__) autoload :Graph, File.expand_path("bundler/graph", __dir__) autoload :Index, File.expand_path("bundler/index", __dir__) |