diff options
| author | Bundlerbot <bot@bundler.io> | 2019-04-11 10:41:44 +0000 |
|---|---|---|
| committer | Bundlerbot <bot@bundler.io> | 2019-04-11 10:41:44 +0000 |
| commit | a6533c0fe6541cc929f895ee0b7a9b673d34cb4d (patch) | |
| tree | 15201fd1b3c701b1be634c1f353f74b23c4f05aa /lib/bundler/settings.rb | |
| parent | 23772391d5f15835b1a540a4bd5ce16aac7ecc98 (diff) | |
| parent | 59e989f3019c41daa807cc1e893263a873ebfb9b (diff) | |
| download | bundler-a6533c0fe6541cc929f895ee0b7a9b673d34cb4d.tar.gz | |
Merge #7057
7057: Review multiple sources deprecation r=indirect a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that I had not yet reviewed the deprecation about multiple global sources being present on a Gemfile, and thus the specs were skipped.
### What was your diagnosis of the problem?
My diagnosis was that we need to delay the removal of multiple sources support to bundler 3, so that we can show the deprecations in the 2.x series.
I also noticed that part of the deprecation message was inaccurate. In order to upgrade the warning to an error, you would also need to configure the `lockfile_uses_separate_rubygems_sources` setting. Otherwise you will get an error that these two settings depend on each other and can't be enabled separatedly.
### What is your fix for the problem, implemented in this PR?
My fix is to delay these feature flags to bundler 3 so that the deprecation specs pass. Also, since before giving this advice I'd like to study why we have two different settings that can't be enabled separately, and why the can't be merged to a single one, I have removed that part of the message for now.
### Why did you choose this fix out of the possible options?
I chose this fix because it keeps me moving with reviewing all the deprecations for bundler 3 breaking changes, and makes sure that the deprecations for this change of behavior are tested (and passing).
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
Diffstat (limited to 'lib/bundler/settings.rb')
| -rw-r--r-- | lib/bundler/settings.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/bundler/settings.rb b/lib/bundler/settings.rb index 7a14a86ea5..bdd15fe675 100644 --- a/lib/bundler/settings.rb +++ b/lib/bundler/settings.rb @@ -39,7 +39,6 @@ module Bundler global_gem_cache ignore_messages init_gems_rb - lockfile_uses_separate_rubygems_sources no_install no_prune only_update_to_newer_versions |