Remove forgotten options deprecationforgotten_options_deprecation_second_pass

This deprecation will be a false positive in almost every case, so it
will be very annoying for users. I realized about this when being bitten
by the warning on our own specs on perfectly fine `bundle install` runs
(`bundle install --retry 3`).

Since we already have the deprecation in place about the options being
removed from `bundle install` and being turned into configuration
options, I think we can skip this warning altogether since the remaining
flags are very unlikely to cause any problems when they start being
"forgotten".

1 files changed, 0 insertions, 20 deletions

diff --git a/lib/bundler/settings.rb b/lib/bundler/settings.rb
index c708659e1c..3bec5c8c3b 100644
--- a/lib/bundler/settings.rb
+++ b/lib/bundler/settings.rb
@@ -110,26 +110,6 @@ module Bundler
         temporary(key => value)
         value
       else
-        command = if value.nil?
-          "bundle config unset #{key}"
-        else
-          "bundle config set #{key} #{Array(value).join(":")}"
-        end
-
-        unless Bundler.settings[:forget_cli_options] == false
-          Bundler::SharedHelpers.major_deprecation 3,\
-            "flags passed to commands " \
-            "will no longer be automatically remembered. Instead please set flags " \
-            "you want remembered between commands using `bundle config set " \
-            "<setting name> <setting value>`, i.e. `#{command}`. Once you are " \
-            "ready for the new behavior, use `bundle config set forget_cli_options " \
-            "true` to get rid of this message. Or if you want to get rid of " \
-            "this message and stick with the old behavior for now, run " \
-            "`bundle config set forget_cli_options false`, but keep in mind " \
-            "that this behavior will be fully removed in future versions of " \
-            "bundler."
-        end
-
         set_local(key, value)
       end
     end