diff options
| author | Samuel Giddins <segiddins@segiddins.me> | 2018-08-06 23:02:49 -0700 |
|---|---|---|
| committer | Samuel Giddins <segiddins@segiddins.me> | 2018-08-06 23:08:03 -0700 |
| commit | fcc4b607379b25f607ce8d003664902f58fefd23 (patch) | |
| tree | a1ebcf872827ef46e1c8dac9d930234f974470ac /lib | |
| parent | 32222b5e892fc548c59890bd45919fee1959603f (diff) | |
| download | bundler-fcc4b607379b25f607ce8d003664902f58fefd23.tar.gz | |
Fix error sorting
Also avoid mutating the original exception message to generate the message we want
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/bundler/definition.rb | 4 | ||||
| -rw-r--r-- | lib/bundler/resolver.rb | 4 | ||||
| -rw-r--r-- | lib/bundler/resolver/spec_group.rb | 4 | ||||
| -rw-r--r-- | lib/bundler/source/metadata.rb | 4 |
4 files changed, 8 insertions, 8 deletions
diff --git a/lib/bundler/definition.rb b/lib/bundler/definition.rb index df8ee1f54b..3964c07fb5 100644 --- a/lib/bundler/definition.rb +++ b/lib/bundler/definition.rb @@ -855,8 +855,8 @@ module Bundler concat_ruby_version_requirements(locked_ruby_version_object) unless @unlock[:ruby] end [ - Dependency.new("ruby\0", ruby_versions), - Dependency.new("rubygems\0", Gem::VERSION), + Dependency.new("Ruby\0", ruby_versions), + Dependency.new("RubyGems\0", Gem::VERSION), ] end end diff --git a/lib/bundler/resolver.rb b/lib/bundler/resolver.rb index 13fe436cb1..3fd1706371 100644 --- a/lib/bundler/resolver.rb +++ b/lib/bundler/resolver.rb @@ -308,7 +308,7 @@ module Bundler deps = conflict.requirement_trees.map(&:last).flatten(1) !Bundler::VersionRanges.empty?(*Bundler::VersionRanges.for_many(deps.map(&:requirement))) end - e.conflicts.replace(conflicts) unless conflicts.empty? + e = Molinillo::VersionConflict.new(conflicts, e.specification_provider) unless conflicts.empty? solver_name = "Bundler" possibility_type = "gem" @@ -329,7 +329,7 @@ module Bundler trees.reject! {|t| !maximal.include?(t.last) } if maximal - trees.sort_by {|t| [t.flatten.map(&:to_s), t.reverse.map(&:name)] } + trees.sort_by {|t| t.reverse.map(&:name) } end, :printable_requirement => lambda {|req| SharedHelpers.pretty_dependency(req) }, :additional_message_for_conflict => lambda do |o, name, conflict| diff --git a/lib/bundler/resolver/spec_group.rb b/lib/bundler/resolver/spec_group.rb index 34d043aed7..119f63b5c8 100644 --- a/lib/bundler/resolver/spec_group.rb +++ b/lib/bundler/resolver/spec_group.rb @@ -94,10 +94,10 @@ module Bundler return [] if !spec.is_a?(EndpointSpecification) && !spec.is_a?(Gem::Specification) dependencies = [] if !spec.required_ruby_version.nil? && !spec.required_ruby_version.none? - dependencies << DepProxy.new(Gem::Dependency.new("ruby\0", spec.required_ruby_version), platform) + dependencies << DepProxy.new(Gem::Dependency.new("Ruby\0", spec.required_ruby_version), platform) end if !spec.required_rubygems_version.nil? && !spec.required_rubygems_version.none? - dependencies << DepProxy.new(Gem::Dependency.new("rubygems\0", spec.required_rubygems_version), platform) + dependencies << DepProxy.new(Gem::Dependency.new("RubyGems\0", spec.required_rubygems_version), platform) end dependencies end diff --git a/lib/bundler/source/metadata.rb b/lib/bundler/source/metadata.rb index 93909002c7..639f262f74 100644 --- a/lib/bundler/source/metadata.rb +++ b/lib/bundler/source/metadata.rb @@ -5,8 +5,8 @@ module Bundler class Metadata < Source def specs @specs ||= Index.build do |idx| - idx << Gem::Specification.new("ruby\0", RubyVersion.system.to_gem_version_with_patchlevel) - idx << Gem::Specification.new("rubygems\0", Gem::VERSION) + idx << Gem::Specification.new("Ruby\0", RubyVersion.system.to_gem_version_with_patchlevel) + idx << Gem::Specification.new("RubyGems\0", Gem::VERSION) idx << Gem::Specification.new do |s| s.name = "bundler" |
