summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2019-03-17 22:13:08 +0100
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2019-03-17 22:44:09 +0100
commit7d09b12e4e57705dca23078b93e49961df5ff673 (patch)
treebf7a6e6e9da53535fd3056f7ee224fbadf5cd6ff /lib
parentcf6e2f75d15e1b999f148900e437df9cbd9e1b36 (diff)
downloadbundler-7d09b12e4e57705dca23078b93e49961df5ff673.tar.gz
Remove forgotten options deprecationforgotten_options_deprecation_second_pass
This deprecation will be a false positive in almost every case, so it will be very annoying for users. I realized about this when being bitten by the warning on our own specs on perfectly fine `bundle install` runs (`bundle install --retry 3`). Since we already have the deprecation in place about the options being removed from `bundle install` and being turned into configuration options, I think we can skip this warning altogether since the remaining flags are very unlikely to cause any problems when they start being "forgotten".
Diffstat (limited to 'lib')
-rw-r--r--lib/bundler/settings.rb20
1 files changed, 0 insertions, 20 deletions
diff --git a/lib/bundler/settings.rb b/lib/bundler/settings.rb
index c708659e1c..3bec5c8c3b 100644
--- a/lib/bundler/settings.rb
+++ b/lib/bundler/settings.rb
@@ -110,26 +110,6 @@ module Bundler
temporary(key => value)
value
else
- command = if value.nil?
- "bundle config unset #{key}"
- else
- "bundle config set #{key} #{Array(value).join(":")}"
- end
-
- unless Bundler.settings[:forget_cli_options] == false
- Bundler::SharedHelpers.major_deprecation 3,\
- "flags passed to commands " \
- "will no longer be automatically remembered. Instead please set flags " \
- "you want remembered between commands using `bundle config set " \
- "<setting name> <setting value>`, i.e. `#{command}`. Once you are " \
- "ready for the new behavior, use `bundle config set forget_cli_options " \
- "true` to get rid of this message. Or if you want to get rid of " \
- "this message and stick with the old behavior for now, run " \
- "`bundle config set forget_cli_options false`, but keep in mind " \
- "that this behavior will be fully removed in future versions of " \
- "bundler."
- end
-
set_local(key, value)
end
end