summaryrefslogtreecommitdiff
path: root/spec/commands/package_spec.rb
diff options
context:
space:
mode:
authorBundlerbot <bot@bundler.io>2019-03-29 08:56:19 +0000
committerBundlerbot <bot@bundler.io>2019-03-29 08:56:19 +0000
commit53989a9812338b804f2c951b6077dfe296d72a99 (patch)
treea949b392e1f3276d14fff9fe6cf1b034b6d87163 /spec/commands/package_spec.rb
parentb4d08a631781703a85649ed21edc24ba73e12b1d (diff)
parentbfc50eda384970b663673cd1f0f48b67d268bdc4 (diff)
downloadbundler-53989a9812338b804f2c951b6077dfe296d72a99.tar.gz
Merge #7070
7070: Improve cross repo integration r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we had on `rubygems`, we're not testing bundler against the rubygems checkout of each PR, but against master. That is confusing because developers assume that the PRs tests will run against the PRs code, but this is currently not true. ### What was your diagnosis of the problem? My diagnosis was that on rubygems we are [specifying `RGV=master`](https://github.com/rubygems/rubygems/blob/fa6e547330e97b417ed11f262d68d03c57abeeda/.travis.yml#L12) in our TravisCI matrix. And what `bundler` does with that is to clone rubygems master under `tmp/rubygems` and use that. Thus your rubygems PR is not really tested. ### What is your fix for the problem, implemented in this PR? My fix is to rework the setup to accept an `RGV` environment variable when it contains. In that case, no git operations will be performed, and that path will be used directly and assumed to contain a rubygems checkout. I also refactored a few things about the setup while at it. ### Why did you choose this fix out of the possible options? There were existing tasks to test bundler against a rubygems checkout, but they were unused and they expected a `RG` environment variable instead. I decided to reuse these tasks, but make them pick up the `RGV` as long as it contains a valid path. I chose this fix because it works and it doesn't make the existing setup too different. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Diffstat (limited to 'spec/commands/package_spec.rb')
0 files changed, 0 insertions, 0 deletions