diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-03-14 12:05:50 +0100 |
---|---|---|
committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-03-14 14:49:09 +0100 |
commit | 79edb8c2cf6bff5ef90d302990bd500ac617149c (patch) | |
tree | 876c6c8cddfc143ca95074afde43c46cc22361c3 /spec/install/gemfile | |
parent | b700a8a3e63cf0e926cdc8461320bd3275fd2824 (diff) | |
download | bundler-79edb8c2cf6bff5ef90d302990bd500ac617149c.tar.gz |
Remove the `have_major_deprecation` matcher
With the `have_major_deprecation` matcher as it was, if a command
printed no deprecations, the expectation
```
expect(err).to have_major_deprecation("anything")
```
would actually succeed!
Instead, do something as readable, but simpler.
Diffstat (limited to 'spec/install/gemfile')
-rw-r--r-- | spec/install/gemfile/sources_spec.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/spec/install/gemfile/sources_spec.rb b/spec/install/gemfile/sources_spec.rb index f9e5d072bf..2ab1f29de5 100644 --- a/spec/install/gemfile/sources_spec.rb +++ b/spec/install/gemfile/sources_spec.rb @@ -30,7 +30,7 @@ RSpec.describe "bundle install with gems on multiple sources" do xit "shows a deprecation" do bundle :install - expect(err).to have_major_deprecation a_string_including("Your Gemfile contains multiple primary sources.") + expect(deprecations).to include("Your Gemfile contains multiple primary sources.") end it "warns about ambiguous gems, but installs anyway, prioritizing sources last to first" do @@ -64,7 +64,7 @@ RSpec.describe "bundle install with gems on multiple sources" do end xit "shows a deprecation" do - expect(err).to have_major_deprecation a_string_including("Your Gemfile contains multiple primary sources.") + expect(deprecations).to include("Your Gemfile contains multiple primary sources.") end it "warns about ambiguous gems, but installs anyway" do @@ -257,7 +257,7 @@ RSpec.describe "bundle install with gems on multiple sources" do end xit "shows a deprecation" do - expect(err).to have_major_deprecation a_string_including("Your Gemfile contains multiple primary sources.") + expect(deprecations).to include("Your Gemfile contains multiple primary sources.") end it "installs from the other source and warns about ambiguous gems" do |