summaryrefslogtreecommitdiff
path: root/spec/other
diff options
context:
space:
mode:
authorBundlerbot <bot@bundler.io>2019-07-20 22:27:57 +0000
committerBundlerbot <bot@bundler.io>2019-07-20 22:27:57 +0000
commita03b11b267503c03b1b009d141b1fed6d193a9e5 (patch)
treefb3db1b7222abaa08c999083a151bc0efde60823 /spec/other
parent3f57b102c76fea2f701152e087c88f53df17d3d0 (diff)
parent69497adf904ef8c231316aba73db1f7524b060e5 (diff)
downloadbundler-a03b11b267503c03b1b009d141b1fed6d193a9e5.tar.gz
Merge #7249
7249: Add `bundle package` functionality to `bundle cache` r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the previous plan provided no migration path from the current `bundle cache` to the future one (an alias to `bundle package`). ### What was your diagnosis of the problem? My diagnosis was that we should probably tell users first that in bundler 3, `bundle cache` will have a different implementation. However, after playing around with it a bit, I noticed that the additions to `bundle cache` provided by `bundle package` are fully backwards compatible. Or maybe I'm missing something but at least all `bundle cache` tests still pass when changing the implementation under the hood to use `bundle package`. As far as I can see, the only backwards incompatible change (start caching `git` and `path` gems by default) is already covered by the exisiting `cache_all` flag), so we should be good. ### What is your fix for the problem, implemented in this PR? My fix is to remove the current implementation of `bundle cache`, and replace it with the current implementation of `bundle package`. ### Why did you choose this fix out of the possible options? I chose this fix because it allows us to remove code and it reduces confusion about `bundle cache` vs `bundle package` making them work exactly the same. On a future PR, I plan to clean this up so that everything (docs, code, tests) use `bundle cache`, and `bundle package` is left only as an alias. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Diffstat (limited to 'spec/other')
-rw-r--r--spec/other/cli_dispatch_spec.rb9
1 files changed, 0 insertions, 9 deletions
diff --git a/spec/other/cli_dispatch_spec.rb b/spec/other/cli_dispatch_spec.rb
index 548539ac89..0082606d7e 100644
--- a/spec/other/cli_dispatch_spec.rb
+++ b/spec/other/cli_dispatch_spec.rb
@@ -17,13 +17,4 @@ RSpec.describe "bundle command names" do
bundle "in"
expect(err).to eq("Ambiguous command in matches [info, init, inject, install]")
end
-
- context "when cache_command_is_package is set" do
- before { bundle! "config set cache_command_is_package true" }
-
- it "dispatches `bundle cache` to the package command" do
- bundle "cache --verbose"
- expect(out).to start_with "Running `bundle package --verbose`"
- end
- end
end