diff options
author | The Bundler Bot <bot@bundler.io> | 2017-07-05 09:00:46 +0000 |
---|---|---|
committer | The Bundler Bot <bot@bundler.io> | 2017-07-05 09:00:46 +0000 |
commit | 5c62240fea87358a2f5aad729fcd27cf71319b4b (patch) | |
tree | 6707c280a91e48d8c0072472247a6aa8ea7e1767 /spec/support | |
parent | bb1bee3b0810744225ef0f4d9f6c82641569f956 (diff) | |
parent | b9add49475bbd2cf59f5e655d7399c924555f670 (diff) | |
download | bundler-5c62240fea87358a2f5aad729fcd27cf71319b4b.tar.gz |
Auto merge of #5819 - bundler:seg-full-index-invalid-deps, r=indirect
[RemoteSpecification] Fail gracefully when deps is an array of array of string
Instead of containing Gem::Dependency objects
### What was the end-user problem that led to this PR?
The problem was some gems have invalid gemspecs served by RubyGems.org. See https://github.com/bundler/bundler/issues/5797.
### Was was your diagnosis of the problem?
My diagnosis was (very old) some gemspecs can have `s.dependencies = [["name", "req"]]` instead of `s.dependencies = [Gem::Dependency.new("name", "req")]`.
### What is your fix for the problem, implemented in this PR?
My fix coerces the invalid dependencies to an array of dependency objects so we can fail more gracefully during installation, without spitting out the error template.
Closes #5797.
### Why did you choose this fix out of the possible options?
I chose this fix because it allows resolution to finish, and falls back upon existing error messages.
Diffstat (limited to 'spec/support')
0 files changed, 0 insertions, 0 deletions