diff options
author | Bundlerbot <bot@bundler.io> | 2019-11-21 11:25:57 +0000 |
---|---|---|
committer | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-12-13 20:07:17 +0100 |
commit | fabf317e41c5998dca4ebf475101cd3eec177e5f (patch) | |
tree | aa043c4c03d5f36f14b46e9bfab8fa509ef6fb09 /spec | |
parent | d8db313c98b7d3733b9ac5764fdad0eed5d0c08e (diff) | |
download | bundler-fabf317e41c5998dca4ebf475101cd3eec177e5f.tar.gz |
Merge #7442
7442: Fix `bundle exec`'ing to rubygems being silent r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that #7401 caused a regression where `bundle exec`'ing to rubygems would silence rubygems output.
### What was your diagnosis of the problem?
My diagnosis was that the removal of:
* Code where `Bundler::RGProxy` would be only set conditionally on `Bundler.ui =` not being passed `nil`.
* Code setting `Bundler.ui` to `nil` right before shelling during `bundle exec`.
caused rubygems UI to be silent during `bundle exec gem`.
### What is your fix for the problem, implemented in this PR?
My fix is to explictly "unsilence" rubygems UI before `bundle exec` calls.
### Why did you choose this fix out of the possible options?
I chose this fix because it's more explicit than the previous one.
Fixes #7441.
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
(cherry picked from commit a11c104c5b6222c018248b585cca2a4f340a9a71)
Diffstat (limited to 'spec')
-rw-r--r-- | spec/commands/exec_spec.rb | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/spec/commands/exec_spec.rb b/spec/commands/exec_spec.rb index 7ae504d360..d2e85a289b 100644 --- a/spec/commands/exec_spec.rb +++ b/spec/commands/exec_spec.rb @@ -55,6 +55,12 @@ RSpec.describe "bundle exec" do expect(out).to eq("hi") end + it "works when exec'ing to rubygems" do + install_gemfile 'gem "rack"' + bundle "exec gem --version" + expect(out).to eq(Gem::VERSION) + end + it "respects custom process title when loading through ruby" do script_that_changes_its_own_title_and_checks_if_picked_up_by_ps_unix_utility = <<~'RUBY' Process.setproctitle("1-2-3-4-5-6-7-8-9-10-11-12-13-14-15") |