diff options
| author | Bundlerbot <bot@bundler.io> | 2019-03-05 08:06:05 +0000 |
|---|---|---|
| committer | Bundlerbot <bot@bundler.io> | 2019-03-05 08:06:05 +0000 |
| commit | 4c817e5632e596c6c811ed31bb26af64c1f0195e (patch) | |
| tree | 9b37e5a26ea2987f890a8f9e902c16268a1be846 /task/release.rake | |
| parent | bca8a4bada7bbedab36bb04d6bdce19630d1b873 (diff) | |
| parent | d53a14d9967891f2009ada602e7790ab23997ff0 (diff) | |
| download | bundler-4c817e5632e596c6c811ed31bb26af64c1f0195e.tar.gz | |
Merge #7016
7016: Fix offenses for more cops r=hsbt a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that a few cops with exceptions in the TODO file have been bothering me recently when moving files around.
### What was your diagnosis of the problem?
My diagnosis was that we can just fix these offenses once and for all, or alternatively disable them inline, or moving them to the permanent config.
### What is your fix for the problem, implemented in this PR?
My fix is to:
* Auto-correct a few simple cops.
* Permanently disable `Style/GuardClause`, because I don't think it always leads to better code, and sometimes it forces artificial refactorings when making changes to methods, making the intention of the changes more obscure.
* Move `rescue Exception` disabling inline, so that when moving that code around, rubocop doesn't complain.
### Why did you choose this fix out of the possible options?
I chose this fix because this is my opinionated approach to this. :)
Co-authored-by: David RodrÃguez <deivid.rodriguez@riseup.net>
Diffstat (limited to 'task/release.rake')
0 files changed, 0 insertions, 0 deletions
