summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Another File::PATH_SEPARATOR fixactions/windowsDavid Rodríguez2020-01-041-3/+3
|
* Try last fixDavid Rodríguez2020-01-041-1/+3
|
* Remove redundant installs and raise if they failDavid Rodríguez2020-01-041-4/+2
|
* Disallow failuresDavid Rodríguez2020-01-041-1/+0
|
* Skip the rest of the failuresDavid Rodríguez2020-01-0430-7/+180
|
* Make sure to pass URI's to `:git`David Rodríguez2020-01-041-7/+7
| | | | | | | | | | | | | Passing paths should work in most cases, but on Windows the driver letter is interpreted as the scheme and causes some case mismatches because ``` irb> URI.parse("E:").to_s => "e:" ``` We fix this by passing file URI's instead.
* Previous fix didn't workDavid Rodríguez2020-01-042-2/+2
|
* Don't rename folders while being insideDavid Rodríguez2020-01-043-0/+6
| | | | Since Windows doesn't like that.
* Extract `in_repo_root`David Rodríguez2020-01-044-15/+19
|
* Move path helpers to a better placeDavid Rodríguez2020-01-042-8/+8
|
* Remove unnecessary setupDavid Rodríguez2020-01-041-4/+0
|
* Remove unnecessary `in_app_root_custom` helperDavid Rodríguez2020-01-043-6/+2
|
* Fix another OS-dependent failureDavid Rodríguez2020-01-041-2/+2
|
* Reuse `in_app_root2` where possibleDavid Rodríguez2020-01-043-5/+5
|
* Try fix another oneDavid Rodríguez2020-01-041-1/+1
|
* Use shellescape instead of manually escapingDavid Rodríguez2020-01-041-2/+1
|
* Avoid spawning a new shell with Open3.popen3David Rodríguez2020-01-041-2/+3
| | | | | So that we don't need to manually escape `$`, that seems to give trouble on Windows.
* Cleanup moreDavid Rodríguez2020-01-041-1/+1
|
* Maybe workaroundDavid Rodríguez2020-01-042-5/+5
|
* Remove stuff making errors harder to figure outDavid Rodríguez2020-01-041-12/+1
|
* Uncomment working codeDavid Rodríguez2020-01-041-1/+1
|
* Try fix some specsDavid Rodríguez2020-01-041-1/+1
| | | | Github actions has lowercase drive letters.
* Migrate Windows CI to Github actionsDavid Rodríguez2020-01-045-95/+34
|
* Skip readline specs on WindowsDavid Rodríguez2020-01-042-1/+2
|
* Tag specs using `readline`David Rodríguez2020-01-046-21/+21
|
* Prefer `bundle!` to `bundle` in more placesDavid Rodríguez2020-01-042-23/+23
|
* Don't use readline on GemHelper specsDavid Rodríguez2020-01-041-1/+1
|
* Simplify `bundle` helperDavid Rodríguez2020-01-041-2/+2
|
* Avoid swallowing errors when possibleDavid Rodríguez2020-01-041-18/+18
|
* Make some `bundle gem` specs more explicitDavid Rodríguez2020-01-041-4/+12
|
* Merge #7537Bundlerbot2020-01-042-1/+18
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7537: Reset `Gemfile` to the empty string after bundler/inline r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that if `BUNDLE_GEMFILE` is not set before requiring `bundler/inline`, we're removing it back again. That means that when requiring gems after that, `bundler` will go through the "Gemfile resolution" logic again and fail if a Gemfile is not found in the filesystem. ### What was your diagnosis of the problem? My diagnosis was that the file resolution logic should be skipped after requiring `bundler/inline`, since we want to use the "inline bundle". ### What is your fix for the problem, implemented in this PR? My fix is to instead reset `BUNDLE_GEMFILE` to the empty string if it had no previous value, since that skips searching the filesystem for a `Gemfile`. ### Why did you choose this fix out of the possible options? I chose this fix because it seems to fix the issue. Fixes #7536. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Reset `Gemfile` to the empty string after bundler/inlinefix/bundler_inlineDavid Rodríguez2020-01-022-1/+18
| | | | | | | | | | To avoid Gemfile resolution afterwards, and use the "inline environment" instead.
* | Merge #7544Bundlerbot2020-01-043-2/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7544: Ignore tests needing file permissions on Windows r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that some specs fail under Windows because permissions are not supported the way they are supported on Unix. ### What is your fix for the problem, implemented in this PR? My fix is to exclude this tests on Windows. ### Why did you choose this fix out of the possible options? I chose this fix because it was proposed at https://github.com/bundler/bundler/issues/6897 and makes sense to me. Closes #6897. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Ignore tests needing file permissions on Windowsskip_permission_tests_on_windowsDavid Rodríguez2020-01-043-2/+3
| |/
* | Merge #7543Bundlerbot2020-01-041-1/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7543: Fix flaky test failures r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was `SharedHelpers#in_bundle?` specs could fail depending on the run order. ### What was your diagnosis of the problem? My diagnosis was that the test Gemfile needs to be removed after the test because other specs rely on it being missing. ### What is your fix for the problem, implemented in this PR? My fix is to remove the `Gemfile` after the test. Closes #6891. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Fix flaky test failuresfix_windows_flakiesDavid Rodríguez2020-01-041-1/+2
| |/ | | | | | | | | The Gemfile was not being removed after another test, so it `in_bundle?` would resolve to it again even if `BUNDLE_GEMFILE` was unset.
* | Merge #7542Bundlerbot2020-01-041-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7542: Make test platform independent r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that a test for the `gemspec` DSL is failing on Windows. ### What was your diagnosis of the problem? My diagnosis was that the test uses local platforms (that change between OS) but asserts for ruby platforms. ### What is your fix for the problem, implemented in this PR? My fix is to add a proper stub. ### Why did you choose this fix out of the possible options? I chose this fix because it was suggested in https://github.com/bundler/bundler/issues/6887 by @janpio and looks good. Closes #6687. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Make test platform independentmake_test_platform_independentDavid Rodríguez2020-01-041-0/+1
| |/
* | Merge #7541Bundlerbot2020-01-041-2/+16
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7541: Adapt `Bundler#which` test to Windows r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that this spec was failing under Windows. ### What was your diagnosis of the problem? My diagnosis was that the test needs Windows specific paths. ### What is your fix for the problem, implemented in this PR? My fix is to separate the test per OS. ### Why did you choose this fix out of the possible options? I chose this fix because it was discussed and considered the better fix at https://github.com/bundler/bundler/issues/6875. Closes https://github.com/bundler/bundler/issues/6875. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Adapt `Bundler#which` test to Windowsadapt_bundler_which_test_to_windowsDavid Rodríguez2020-01-041-2/+16
|/
* Merge #7534Bundlerbot2020-01-011-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 7534: Set master's version to 2.2.0.dev r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that master version is set to the latest patch level release, but the code in master doesn't really match the latest patch level release. ### What is your fix for the problem, implemented in this PR? My fix is to use 2.2.0.dev to name master's development version. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Set master's version to 2.2.0.devbump_master_versionDavid Rodríguez2020-01-011-1/+1
| | | | | | | | | | | | | | So that it's always higher than the latest patch level release. This saves us from having to merge back the version bump after each patch level release, which is also not accurate since master is "bigger" than the latest patch level release anyways.
* | Merge #7533Bundlerbot2020-01-0150-50/+50
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | 7533: Rebuild man pages for January r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was man pages are out of date. ### What is your fix for the problem, implemented in this PR? My fix is to bring them up to date. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Rebuild man pages for Januaryjanuary_man_pagesDavid Rodríguez2020-01-0150-50/+50
|/
* Merge #7519Bundlerbot2019-12-314-83/+104
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7519: Make `bundle config deployment true` equivalent to `bundle install --deployment` in regards to configuration r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that while addressing comments for https://github.com/docker-library/official-images/pull/7188, I noticed that the alternative we're recommending for `bundle install --deployment`, i.e., `bundle config set deployment true`, is not equivalent to it. ### What was your diagnosis of the problem? My diagnosis was that whereas `bundle install --deployment` configures bundler to be frozen AND to install gems to `vendor/bundle`, `bundle config deployment true` only configures bundler to be frozen. ### What is your fix for the problem, implemented in this PR? My fix is to make `bundle config deployment true` behave just like `bundle install --deployment` in regards to configuration. ### Why did you choose this fix out of the possible options? I chose this fix because all the commands we're suggesting as alternatives for deprecations should be actual alternatives that work exactly in the same way. Also, note that there's a change scheduled for bundler 3 where the `deployment` configuration will only mean `frozen`. But for now, we should focus on making sure that people moves away from CLI flags in favor of configuration, so we might want to delay that change to make things less confusing. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Unify deployment setting and flagimprove_deployment_flagDavid Rodríguez2019-12-314-5/+19
| | | | | | | | | | | | Previously, we were recommending `bundle config deployment true; bundle install` as an alternative to `bundle install --deployment`, but they were not working equally.
| * Add missing specsDavid Rodríguez2019-12-311-0/+10
| |
| * Reword spec to be easier to understandDavid Rodríguez2019-12-311-1/+1
| |
| * Split credentials specs out of the surrounding contextDavid Rodríguez2019-12-311-70/+71
| | | | | | | | So that I can change the setup only for them in following commits.
| * Improve readabilityDavid Rodríguez2019-12-311-6/+2
| | | | | | | | The `let` does not add anything.
View Lorry Controller Status