summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* One more fix to subprocess coveragebetter_code_coverageDavid Rodríguez2019-03-261-0/+2
|
* Revert "Maybe this is not needed"David Rodríguez2019-03-261-0/+1
| | | | | | This reverts commit 22b86269db3ba2d7457f0c951f22e5a9f3712103. Maye it's needed.
* Skip coverage here tooDavid Rodríguez2019-03-261-1/+1
|
* Remove uneeded checkDavid Rodríguez2019-03-261-1/+1
|
* Skip coverage for some exec specsDavid Rodríguez2019-03-262-3/+5
| | | | | Simplecov messes with the exit status of the process it's attached to and makes some of these fail.
* Experiment with tracking subprocess coverageDavid Rodríguez2019-03-264-1/+17
|
* Maybe this is not neededDavid Rodríguez2019-03-261-1/+0
|
* Patch vendored fileutils for nowDavid Rodríguez2019-03-261-5/+2
|
* Prefer direct requiresDavid Rodríguez2019-03-261-4/+16
|
* Simplecov should be required as early as possibleDavid Rodríguez2019-03-264-6/+20
|
* Remove unexisting folderDavid Rodríguez2019-03-261-1/+0
|
* Fix coverage report mergingDavid Rodríguez2019-03-261-0/+10
|
* Configure `simplecov` in `.simplecov` fileDavid Rodríguez2019-03-263-23/+12
|
* Better code coverage solutionDavid Rodríguez2019-03-266-17/+22
| | | | This is the setup codeclimate recommends now.
* Remove outdated commentDavid Rodríguez2019-03-261-2/+0
|
* Divide travis phasesDavid Rodríguez2019-03-261-1/+5
| | | | And skip what can be skipped in the linting job
* Merge #7067Bundlerbot2019-03-2612-62/+328
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7067: Tweaking vendoring r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we were not using the latest versions of some of our vendored dependencies. ### What was your diagnosis of the problem? My diagnosis was that we should upgrade them. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade them using `automatiek`, and add a few tweaks to our vendoring setup. ### Why did you choose this fix out of the possible options? I chose this fix because.... I didn't really considered other options. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Bump thor to 0.20.3tweaking_vendoringDavid Rodríguez2019-03-2510-25/+175
| |
| * Bump fileutils to 1.1.0David Rodríguez2019-03-251-26/+123
| |
| * Describe automatiek tasksDavid Rodríguez2019-03-251-0/+11
| |
| * Improve automatiek activationDavid Rodríguez2019-03-251-8/+16
| | | | | | | | | | Make it consistent with how we do it for `ronn`, and give better messages for installing `automatiek` if missing.
| * Little refactorDavid Rodríguez2019-03-251-4/+4
|/
* Merge pull request #7061 from bundler/fix_circular_requiresDavid Rodríguez2019-03-233-3/+0
|\ | | | | Fix circular require warnings
| * Fix circular require warningsDavid Rodríguez2019-03-233-3/+0
|/
* Merge #7055Bundlerbot2019-03-211-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7055: Revert the RSpec format in CI back to dots r=colby-swandale a=colby-swandale ### What was the end-user problem that led to this PR? #7017 introduced made a change that sets the RSpec format to `documentation` in CI. I'm against this change because it now takes _a lot_ more time to scroll to the build errors, and makes the build log have too much information. Maintainers care much more about the failing specs and their errors than the test descriptions in CI. ### What is your fix for the problem, implemented in this PR? Explicitly set the RSpec format to `progress` in CI. Co-authored-by: Colby Swandale <me@colby.fyi>
| * revert the RSpec format in CI back to dotsColby Swandale2019-03-211-1/+1
|/
* Merge #7017Bundlerbot2019-03-205-172/+154
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7017: Development environment cleanup r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was making changes in the development setup was brittle and led to hard to debug errors. For example, the ones in #6980. Also, it was hard to reproduce exactly what's going on in the current CI environment. Which is useful to setup other CI, or run the specs under a docker image. ### What was your diagnosis of the problem? My diagnosis was that we can simplify a lot of this stuff. ### What is your fix for the problem, implemented in this PR? My fix is... a lot of simplifications, but the most important ones being: * Now each binstub activates only its own dependency, not every development dependency. That means a contributor can perfectly work on manual pages installing only `rake` and `ronn` without having to install all development dependencies. Same with styling (`rubocop`), or with specs (`rspec`). * Error messages are better now. * The rake tasks for each main `Rakefile` section (man / spec / vendor) have been extracted to their own files. * Rake tasks now shell out to the proper binstub, so gem activation is only needed there. ### Why did you choose this fix out of the possible options? I chose this fix because it simplifies a lot the development environment in my opinion. Also, specs now pass under a docker image! Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * `finish_resolve` is not actually neededDavid Rodríguez2019-03-203-6/+0
| |
| * Abort when building man pages without ronnDavid Rodríguez2019-03-201-1/+1
| |
| * Improve `ronn` activationDavid Rodríguez2019-03-201-8/+14
| | | | | | | | | | | | Previously having another gem with a `ronn` executable would silently work and fail later with a cryptic error. Now we activate the proper version, and give a proper error if it fails.
| * Simplify globbingDavid Rodríguez2019-03-201-1/+1
| | | | | | | | No .rb files in there.
| * Remove unused requireDavid Rodríguez2019-03-201-1/+0
| |
| * Move the `safe_task` method into the :spec namespaceDavid Rodríguez2019-03-201-7/+7
| |
| * Merge the `:spec` namespace to a single blockDavid Rodríguez2019-03-201-12/+10
| |
| * Simplify rubygems path transmissionDavid Rodríguez2019-03-201-2/+1
| | | | | | | | | | Since the RSpec task now uses the RSpec binstub, we can rely on all the dance done in there.
| * Make `bin/rake` activate only `rake`David Rodríguez2019-03-201-11/+12
| |
| * Remove now dummy being-rescue-end blockDavid Rodríguez2019-03-201-101/+97
| |
| * Simplify rubocop taskDavid Rodríguez2019-03-201-7/+6
| | | | | | | | We shell out to the binstub so we no longer need the activation dance.
| * Remove unnecessary prerequisiteDavid Rodríguez2019-03-201-1/+1
| |
| * Make `bin/rubocop` activate only `rubocop`David Rodríguez2019-03-201-5/+10
| |
| * Simplify RSpec taskDavid Rodríguez2019-03-201-17/+9
| | | | | | | | We shell out to the binstubs, so we don't need any activation dance.
| * Make `bin/rspec` activate only `rspec`David Rodríguez2019-03-201-4/+11
| |
| * Remove unnecessary pre-requisiteDavid Rodríguez2019-03-201-1/+0
| | | | | | | | | | This is already done from the spec helper right before the beginning of the test suite.
| * Remove unnecessary RSpec activationDavid Rodríguez2019-03-201-13/+0
|/ | | | | We are inside the RSpec helper file, so RSpec must be already activated at this point.
* Merge #7045Bundlerbot2019-03-203-3/+135
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7045: Review old `bundle config` interface deprecation r=colby-swandale a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the `bundle config` command interface changes needed a few tweaks. ### What was your diagnosis of the problem? My diagnosis was that: * `bundle config` deprecation was not getting enabled until bundler 3. * `bundle config` documentation was incorrect about `unset` not supporting `--global` or `--local`. * `bundle config` deprecation didn't give actionable suggestions. ### What is your fix for the problem, implemented in this PR? My fix is to move the version to deprecate the old interface to `bundler 2`, to fix the documentation, and to improve the deprecation messages to give actionable suggestions. ### Why did you choose this fix out of the possible options? I chose this fix because it makes `bundle config` better. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Add actionable suggestions to config deprecationmove_bundle_config_deprecation_to_bundler_2David Rodríguez2019-03-152-7/+119
| |
| * Fix docs about `unset` with `--global` / `--local`David Rodríguez2019-03-151-1/+7
| | | | | | | | They are actually compatible.
| * Fix deprecation version for `bundle config`David Rodríguez2019-03-152-1/+15
| | | | | | | | And add specs for it.
* | Merge #7044Bundlerbot2019-03-201-2/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7044: Unskip `--binstubs` flag deprecation r=colby-swandale a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that some deprecation specs were still skipped. ### What was your diagnosis of the problem? My diagnosis was that I should get all of them passing. ### What is your fix for the problem, implemented in this PR? My fix is to uncomment the spec and get it passing. The only fix was to include the full deprecation message so that it matches the assertion. ### Why did you choose this fix out of the possible options? I could've regexp-matched the existing message but I preferred to use the full message in the assertion instead. I chose this fix because although it makes it more brittle since changing the message _will_ break the test, having the whole messages inside the deprecation specs makes it easier to get a quick view and understand the stuff that we are deprecating and the quality of the existing deprecation messages. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Unskip `--binstubs` flag deprecationunskip_binstubs_deprecation_specsDavid Rodríguez2019-03-151-2/+9
| |/
View Lorry Controller Status