summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Bump tested rubies and regenerate cassettesbump_rubiesDavid Rodríguez2019-10-20707-348/+348
|
* Merge #7385Bundlerbot2019-10-205-9/+9
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7385: Remove taint usage on Ruby 2.7+ r=hsbt a=jeremyevans ### What was the end-user problem that led to this PR? Ruby 2.7 is deprecating taint support. See https://bugs.ruby-lang.org/issues/16131 for details. ### What was your diagnosis of the problem? Bundler still uses `untaint` in a few places, which will cause deprecation warnings on Ruby 2.7. ### What is your fix for the problem, implemented in this PR? `s/\.untaint/.tap{|x| x.untaint if RUBY_VERSION < "2.7" }/g` ### Why did you choose this fix out of the possible options? It seemed simplest. Co-authored-by: Jeremy Evans <code@jeremyevans.net>
| * Only untaint strings on Ruby <2.7Jeremy Evans2019-10-185-9/+9
| | | | | | | | | | | | | | | | Ruby 2.7 deprecates taint and it no longer has an effect. This attempts to leave the behavior the same on older Ruby versions, but avoid the use of untaint on Ruby 2.7+. See https://bugs.ruby-lang.org/issues/16131 for details.
* | Merge #7379Bundlerbot2019-10-191-2/+2
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | 7379: Switch to double quotes to match rest of file r=deivid-rodriguez a=jonathanhefner ### What was your diagnosis of the problem? It is common to prefer double quotes, unless single quotes are needed. It is also generally preferred to use a consistent quote style (whether double quotes or single quotes). ### What is your fix for the problem, implemented in this PR? Switch the anomalous single quotes to double quotes. Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
| * Switch to double quotes to match rest of fileJonathan Hefner2019-10-141-2/+2
| |
* | Merge #4474Bundlerbot2019-10-144-131/+292
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4474: Improve readability of outdated r=deivid-rodriguez a=tlynam Haven't fixed tests since wanted buy-in. Before: ``` Outdated gems included in the bundle: * active_model_serializers (newest 0.9.5, installed 0.8.3, requested ~> 0.8.0) in group "default" * activerecord-import (newest 0.13.0, installed 0.10.0) in group "default" * addressable (newest 2.4.0, installed 2.3.5, requested = 2.3.5) in group "default" * airbrake (newest 5.2.3, installed 5.1.0) in group "default" * bootstrap-sass (newest 3.3.6, installed 3.3.5.1) in group "default" * capistrano (newest 3.5.0, installed 3.4.0, requested ~> 3.4) in group "development" * capistrano-rails (newest 1.1.6, installed 1.1.3, requested ~> 1.1.1) in group "development" ``` After: ``` --pretty Outdated gems included in the bundle: Gem Name New Installed Requested Groups airbrake 5.3.0 5.0.3 default better_errors 2.1.1 1.0.1 ~> 1.0.1 development bootstrap-sass 3.3.6 3.3.0.1 ~> 3.3.0.1 default factory_girl_rails 4.7.0 4.4.1 test, development --pretty --verbose Outdated gems included in the bundle: Gem Name New Installed Requested Groups Load Path airbrake 5.3.0 5.0.3 default /Users/todd/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/specifications/airbrake-5.3.0.gemspec better_errors 2.1.1 1.0.1 ~> 1.0.1 development /Users/todd/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/specifications/better_errors-2.1.1.gemspec bootstrap-sass 3.3.6 3.3.0.1 ~> 3.3.0.1 default /Users/todd/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/specifications/bootstrap-sass-3.3.6.gemspec factory_girl 4.7.0 4.4.0 /Users/todd/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/specifications/factory_girl-4.7.0.gemspec factory_girl_rails 4.7.0 4.4.1 test, development /Users/todd/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/specifications/factory_girl_rails-4.7.0.gemspec ``` Co-authored-by: Todd Lynam <tlynam@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Rename "Locked" to "Current"David Rodríguez2019-10-123-54/+54
| |
| * Split --verbose option to a separate specDavid Rodríguez2019-10-121-2/+35
| |
| * Normalize `bundle outdated --verbose` option handlingDavid Rodríguez2019-10-121-2/+2
| | | | | | | | | | `--parseable` checks `Bundler.ui.debug?` instead of look at the option directly.
| * Inline one methodDavid Rodríguez2019-10-121-7/+3
| | | | | | | | | | All the other screen output and checks for `--parseable` are doing inline, so let's do it here too.
| * Don't include table header when orderingDavid Rodríguez2019-10-122-4/+27
| |
| * Remove --pretty option and make it the defaultDavid Rodríguez2019-10-124-109/+193
| |
| * Strip row trailing spacesDavid Rodríguez2019-10-121-1/+1
| |
| * Move row justification logic to a methodDavid Rodríguez2019-10-121-5/+7
| |
| * Consistenly pass strings to method that prints a tableDavid Rodríguez2019-10-121-3/+3
| |
| * Change "Installed" column to "Locked"David Rodríguez2019-10-121-1/+1
| | | | | | | | | | The "Latest" version may also be installed, so I think it's more accurate to use "Locked" here.
| * Change "Load Path" header to just "Path"David Rodríguez2019-10-121-1/+1
| |
| * Tighten some expectationsDavid Rodríguez2019-10-121-5/+6
| |
| * Remove unnecessary expectationsDavid Rodríguez2019-10-122-3/+0
| | | | | | | | If bundler crashes, specs should fail anyways.
| * Remove outdated headerDavid Rodríguez2019-10-122-14/+0
| | | | | | | | I don't think it adds much to the output?
| * Change "New" header to "Latest"David Rodríguez2019-10-121-1/+1
| | | | | | | | | | The output feels a bit cleaner because there's more space, and the term is more clear in my opinion.
| * Change "Gem Name" header to just "Gem"David Rodríguez2019-10-121-1/+1
| |
| * Add a bit more space between columnsDavid Rodríguez2019-10-121-1/+1
| |
| * Rename outdated_gems_listDavid Rodríguez2019-10-121-8/+8
| | | | | | | | The list part doesn't add much and it's very implementation dependent.
| * Make hash alignment style more diff-friendlyDavid Rodríguez2019-10-121-4/+6
| | | | | | | | | | With this, if we rename the hash, we don't have to change the indentation of every entry to keep it consistent.
| * Extract table header to a methodDavid Rodríguez2019-10-121-4/+7
| |
| * Improve readability of outdatedTodd Lynam2019-10-122-0/+34
| |
| * Reword one specDavid Rodríguez2019-10-121-1/+1
|/
* Merge #7375Bundlerbot2019-10-073-112/+132
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7375: Bump vendored fileutils to 1.3.0 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we were not using a released version of fileutils. ### What was your diagnosis of the problem? My diagnosis was that we can upgrade, because 1.3.0 has been released. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Bump vendored fileutils to 1.3.0next_fileutilsDavid Rodríguez2019-10-043-112/+132
| |
* | Merge #7373Bundlerbot2019-10-072-320/+151
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7373: Refactor new gem specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I rebased #6455 and I had trouble getting the specs to pass. ### What was your diagnosis of the problem? My diagnosis was that the new gemspecs could use a refactor. ### What is your fix for the problem, implemented in this PR? My fix is to refactor these specs so that they are easier to read and modify. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Don't run `bundle gem` twice when testing `--ext` flagrefactor_new_gem_specsDavid Rodríguez2019-10-031-4/+4
| |
| * Remove unneded `after` hookDavid Rodríguez2019-10-031-3/+0
| |
| * No need to switch folders, we're already thereDavid Rodríguez2019-10-031-29/+2
| |
| * Extract a shared context for the different gem namingsDavid Rodríguez2019-10-031-191/+35
| |
| * Remove hardcoded require pathsDavid Rodríguez2019-10-031-36/+40
| |
| * Remove hardcoded gem namesDavid Rodríguez2019-10-031-89/+89
| |
| * Move `--ext` flag spec under the right contextDavid Rodríguez2019-10-031-34/+34
| | | | | | | | | | It was under "gem naming with dashed" but this flag doesn't work this dashed gem names.
| * Rename some specs to be more genericDavid Rodríguez2019-10-031-7/+7
| |
| * Don't do unnecessary workDavid Rodríguez2019-10-031-4/+22
| | | | | | | | | | | | Most inner context create a gem on their own setup, and don't need the outtermost gem creation. So move that inline to every spec that needs it.
| * Reuse `generated_gemspec` letDavid Rodríguez2019-10-031-2/+1
| |
| * Remove now unnecessary parameter to `gem_skeleton_assertions`David Rodríguez2019-10-031-7/+7
| |
| * Adapt `gem_skeleton_assertions` to different gem namesDavid Rodríguez2019-10-031-3/+7
| |
| * Move `gem_name` to the outtermost levelDavid Rodríguez2019-10-031-20/+16
| |
| * Add missing requireDavid Rodríguez2019-10-031-0/+1
| | | | | | | | Detected while running `bin/rspec --bisect`.
| * Remove unnecessary indirectionDavid Rodríguez2019-10-031-14/+11
| |
| * Remove unnecessary cache clearingDavid Rodríguez2019-10-031-3/+1
|/ | | | Don't use the cache instead.
* Merge #7374Bundlerbot2019-10-033-7/+7
|\ | | | | | | | | | | | | | | 7374: Fix typos r=hsbt a=biow0lf Fix typos Co-authored-by: Igor Zubkov <igor.zubkov@ag-force.com>
| * Fix typoIgor Zubkov2019-10-031-1/+1
| |
| * Fix typoIgor Zubkov2019-10-033-6/+6
| |
View Lorry Controller Status