summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Use the latest rubygems 3.0.6 in CIbump_rubygemsDavid Rodríguez2019-08-172-5/+5
|
* Merge #7303Bundlerbot2019-08-1611-111/+87
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7303: Refactor ruby core integration r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that sometimes we break specs when integrating bundler changes into core. ### What was your diagnosis of the problem? My diagnosis was that sometimes we use paths dependent on the structure of this repo, but that break under ruby-core's structure. ### What is your fix for the problem, implemented in this PR? My fix is only some refactoring so that usage of structure independent helpers is encouraged. After this set of changes, if you grep the repo for `ruby_core?`, the only result will be `spec/support/path.rb`. That means that all logic dealing with repo folder structure lives in a single place. ### Why did you choose this fix out of the possible options? I chose this fix because it makes the integration in core cleaner. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Extract a `gemspec_dir` helperrefactor_ruby_core_integrationDavid Rodríguez2019-08-162-2/+5
| |
| * Extract yet another helper methodDavid Rodríguez2019-08-162-20/+19
| |
| * Extract a `root_gemspec` local variableDavid Rodríguez2019-08-161-3/+4
| |
| * Extract a `with_root_gemspec` helperDavid Rodríguez2019-08-163-14/+14
| |
| * Only chdir when necessaryDavid Rodríguez2019-08-161-16/+14
| |
| * Make sure gem has been built before deleteng itDavid Rodríguez2019-08-161-11/+13
| |
| * Cleanup in a location independent wayDavid Rodríguez2019-08-161-1/+1
| |
| * Remove obvious commentDavid Rodríguez2019-08-161-1/+0
| |
| * Remve another unneeded `to_s`David Rodríguez2019-08-161-1/+1
| | | | | | | | `FileUtils.rm` supports a `Pathname` argument.
| * Remove unneeded `to_s` callsDavid Rodríguez2019-08-162-3/+3
| | | | | | | | They are implicit inside `gem_command!`.
| * Consistently use `Path` over `Spec::Path`David Rodríguez2019-08-161-1/+1
| |
| * Extract single gem installation logicDavid Rodríguez2019-08-161-3/+7
| |
| * Unalias `install_gem`David Rodríguez2019-08-162-3/+1
| | | | | | | | Since I plan to reuse it for something else.
| * Use `join` consistentlyDavid Rodríguez2019-08-161-1/+1
| |
| * Extract a `lib_tracked_files` path helperDavid Rodríguez2019-08-162-4/+4
| |
| * Rename a variableDavid Rodríguez2019-08-161-4/+4
| | | | | | | | Otherwise I get conflicts when extracting the helper.
| * Extract a `tracked_files` path helperDavid Rodríguez2019-08-162-4/+4
| |
| * Rename some variablesDavid Rodríguez2019-08-161-19/+19
| | | | | | | | | | | | I want to extract these to path helper methods, but the name `files` conflict with some builder methods that are also available at the same level.
| * Reconcile testDavid Rodríguez2019-08-161-3/+1
| | | | | | | | The `:bundler` gem is not needed in the regular repo either.
| * Reuse `gem_bin` helper inside `gem_command`David Rodríguez2019-08-161-2/+1
| | | | | | | | | | The logic for choosing `gem_bin` should work here too even if it's not identical.
| * Always use `--backtrace` when invoking `gem` CLIDavid Rodríguez2019-08-161-1/+1
| | | | | | | | For debuggability.
| * Extract a `gem_bin` path helperDavid Rodríguez2019-08-162-1/+5
| |
| * Reuse `gem_command!` helperDavid Rodríguez2019-08-161-8/+4
| |
| * Remove more dead codeDavid Rodríguez2019-08-161-5/+1
| |
| * Remove dead codeDavid Rodríguez2019-08-161-1/+1
| |
| * Remove unnecessary rubygems requireDavid Rodríguez2019-08-161-1/+1
| |
| * Use path helpers to find bundle binDavid Rodríguez2019-08-161-2/+1
| |
| * Fix bundle bin location in core repoDavid Rodríguez2019-08-162-2/+2
| |
| * Reuse more shared path helpersDavid Rodríguez2019-08-163-18/+4
| |
| * Remove unnecessary assignmentDavid Rodríguez2019-08-161-2/+2
| |
| * Remove unnecessary `let`David Rodríguez2019-08-161-3/+2
| | | | | | | | Use shared helper instead.
| * Move `lib` helper together with path helpersDavid Rodríguez2019-08-162-4/+4
| |
| * Reuse `lib` methodDavid Rodríguez2019-08-161-1/+0
| |
| * Remove duplicated methodDavid Rodríguez2019-08-164-8/+4
|/
* Merge #7306Bundlerbot2019-08-161-0/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7306: Fixup #7297 r=hsbt a=hsbt ### What was the end-user problem that led to this PR? `build_metadata_spec.rb` was inconsistency structure. ### What was your diagnosis of the problem? I missed checking the file location of #7297 ### What is your fix for the problem, implemented in this PR? Move file under `spec/bundler`. ### Why did you choose this fix out of the possible options? Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org>
| * Fixup #7297Hiroshi SHIBATA2019-08-161-0/+0
|/
* Merge #7301Bundlerbot2019-08-166-9/+11
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7301: Track changes from ruby core master r=hsbt a=hsbt ### What was the end-user problem that led to this PR? I'm going to merge https://github.com/bundler/bundler/pull/7274. But the ruby-core source has some of the changes for bundler source. ### What was your diagnosis of the problem? ### What is your fix for the problem, implemented in this PR? ruby core team fixed them: * Removed circular require warning at `shared_helper.rb` * Support test at GitHub Actions, It helps that bundler will migrate Actions from Azure Pipelines too. * Fixed broken examples at ruby core repository ### Why did you choose this fix out of the possible options? Co-authored-by: ohbarye <over.rye@gmail.com> Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org> Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
| * Fixed rubocop errortrack-ruby-core-masterHiroshi SHIBATA2019-08-161-2/+2
| |
| * lib/bundler/shared_helpers.rb: remove require "rubygems"Yusuke Endoh2019-08-141-1/+0
| | | | | | | | Because it causes circular require.
| * Fixed up 365ee22d73ec73c119a842de271504e04bed6f45Hiroshi SHIBATA2019-08-141-1/+1
| |
| * Fixed the broken example with ruby core structure.Hiroshi SHIBATA2019-08-141-1/+2
| |
| * Added example filter for Linux of GitHub Actions.Hiroshi SHIBATA2019-08-142-1/+2
| |
| * Re-use GITHUB_ACTION variables for filtering bundler examples.Hiroshi SHIBATA2019-08-142-4/+4
| |
| * GitHub Actions does not support ANSI color code. Skip failing examples.Hiroshi SHIBATA2019-08-141-1/+1
| |
| * Explicitly ignored GEMRC environmental variable.Hiroshi SHIBATA2019-08-141-0/+1
| |
| * Fix typo: duplicated the [skip-ci]ohbarye2019-08-141-1/+1
| |
* | Merge #7242Bundlerbot2019-08-156-153/+155
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7242: Restore remembered options in manpages r=deivid-rodriguez a=uasi ### What was the end-user problem that led to this PR? The problem was that the remembered options of `bundle install` were not documented in manpages. ### What is your fix for the problem, implemented in this PR? Restore the section on remembered options from https://github.com/bundler/bundler/commit/e120f40f72fe53f55e05db9204f98d28f1065e81 and add description for some options. ### Why did you choose this fix out of the possible options? They should be fully documented. Closes #7198. Co-authored-by: Tomoki Aonuma <uasi@uasi.jp> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Remove mention to remembered optionsDavid Rodríguez2019-08-143-22/+15
| | | | | | | | | | | | And instead educate users on the preferred, non deprecated, way.
View Lorry Controller Status