summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix failing spec in the bundle exec system gem speccolby/fix-exec-failing-testColby Swandale2018-01-261-1/+1
| | | | | | | | | There was an issue where a spec was failing because it was activating the version of bundler inside of RubyGems and not the development version that we're working on. This would cause the Lockfile to raise an error because we were generating a Bundler 2 lockfile but Bundler 1 was being activated.
* Auto merge of #6272 - bundler:colby/update-small-bugs-link, r=colby-swandaleThe Bundler Bot2018-01-241-1/+1
|\ | | | | | | | | | | Update contributing documentation to use new tags Github has defined a couple of tags to use for classifying issues that are suitable for new contributors to fix/contribute towards. We have started using these tags in Github so we should start linking to them in our documentation as well.
| * Update contributing documentation to use new tagscolby/update-small-bugs-linkColby Swandale2018-01-241-1/+1
|/ | | Github has defined a couple of tags to use for classifying issues that are suitable for new contributors to fix/contribute towards. We have started using these tags in Github so we should start linking to them in our documentation as well.
* Auto merge of #6267 - christhekeele:scaffold-error-class, r=colby-swandaleThe Bundler Bot2018-01-232-0/+5
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add base error class to new gems. Closes #6260. Room for discussion: - Which error class to use (`StandardError` makes sense to me) - What formatting to use (the three-lines-with-comment seemed nicest to me) - Whether or not using the flag to provide a different error base class is useful, and if it should validate the user's choice or not (I threw it in because it seemed harmless; is it? a boolean flag would work fine too) --- ### What was the end-user problem that led to this PR? Libraries don't always follow best practice from discussion in linked issue. ### What was your diagnosis of the problem? Bundler could encourage best practice by adding it to the gem scaffold. ### What is your fix for the problem, implemented in this PR? I added a base error class to the templates, and provided a flag to change/disable this behaviour. ### Why did you choose this fix out of the possible options? Like any best-practice-by-default, this could ruin someones workflow/go against someone's preferences so I made it as configurable as possible.
| * Simplify error class stuff.Chris Keele2018-01-194-53/+1
| |
| * Add base error class to new gems.Chris Keele2018-01-194-0/+57
| | | | | | | | Closes #6260.
* | Auto merge of #6262 - bundler:colby/update-bundler-authors, r=colby-swandaleThe Bundler Bot2018-01-221-1/+1
|\ \ | |/ |/| | | | | | | | | | | add the new team members of the bundler core team to the author list in the Bundler gemspec Just adding myself and Hiroshi-san to the list of authors in the Bundler gemspec \cc @indirect
| * add the new team members of the bundler core team to the author list in the ↵colby/update-bundler-authorsColby Swandale2018-01-181-1/+1
| | | | | | | | Bundler gemspec
* | Auto merge of #6264 - bundler:colby/client-index-gzip-error, r=indirectThe Bundler Bot2018-01-192-6/+19
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | handle gzip corruption errors in the compact index client ### What was the end-user problem that led to this PR? Bundler will raise an exception and crash if the Gzip that the Compact Client Index downloaded was corrupt. ### What was your diagnosis of the problem? See #6261 ### What is your fix for the problem, implemented in this PR? Handle the exception and allow Bundler to continue without crashing
| * | handle gzip corruption errors in the compact index clientcolby/client-index-gzip-errorColby Swandale2018-01-192-6/+19
| |/
* | Auto merge of #6254 - bundler:seg-friendly-error-fallback, r=segiddinsThe Bundler Bot2018-01-161-0/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [FriendlyErrors] Fallback to the original error if the friendly message raises ### What was the end-user problem that led to this PR? This would have made diagnosing https://github.com/bundler/bundler/issues/6220 much easier ### What was your diagnosis of the problem? My diagnosis was we do a lot in our error handler, so it needs a fallback ### What is your fix for the problem, implemented in this PR? My fix falls back to just re-raising the original error
| * | [FriendlyErrors] Fallback to the original error if the friendly message raisesseg-friendly-error-fallbackSamuel Giddins2018-01-121-0/+2
| |/ | | | | | | This would have made diagnosing https://github.com/bundler/bundler/issues/6220 much easier
* | Auto merge of #6235 - Debian:samueloph_typo, r=colby-swandaleThe Bundler Bot2018-01-161-1/+1
|\ \ | | | | | | | | | | | | | | | [man] fix typo on bundle-binstubs Typo found while i was packaging 1.16.1 for Debian
| * | [man] fix typo on bundle-binstubsSamuel Henrique2017-12-281-1/+1
| | |
* | | Auto merge of #6257 - bundler:seg-rename-bundler-frozen, r=segiddinsThe Bundler Bot2018-01-168-14/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename Bundler.frozen? to avoid Object method conflict ### What was the end-user problem that led to this PR? The problem was `Bundler` overrode the `Object#frozen?` method to mean something else, breaking anything that checks that method to determine if an object is frozen. Closes #6252. ### What was your diagnosis of the problem? My diagnosis was the method name had to be changed.
| * | | Rename Bundler.frozen? to avoid Object method conflictseg-rename-bundler-frozenSamuel Giddins2018-01-158-14/+14
| | | |
* | | | Auto merge of #6258 - bundler:seg-fix-travis-ruby-2.5, r=colby-swandaleThe Bundler Bot2018-01-161-0/+2
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Source::RubyGems] Ensure the bindir exists before installing ### What was the end-user problem that led to this PR? The problem was occasional failures on CI w/ ruby 2.5 ### What was your diagnosis of the problem? My diagnosis was that there was a race condition in the rubygems installer, see https://github.com/rubygems/rubygems/pull/2148 for the fix there. ### What is your fix for the problem, implemented in this PR? My fix will ensure that directory is created before we get into that rubygems code path
| * | | [Source::RubyGems] Ensure the bindir exists before installingseg-fix-travis-ruby-2.5Samuel Giddins2018-01-151-0/+2
|/ / / | | | | | | | | | This will help avoid a potential race condition in RubyGems
* | | Auto merge of #6238 - bundler:seg-outdated-fips, r=olleolleolleThe Bundler Bot2018-01-131-0/+2
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [CLI] Skip the outdated bundler check when MD5 is not available ### What was the end-user problem that led to this PR? The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception. Closes #6032. ### What was your diagnosis of the problem? My diagnosis was we needed to skip the check when MD5 is unavailable. ### Why did you choose this fix out of the possible options? I chose this fix because using `#available?` would make network requests, which is not acceptable.
| * | [CLI] Skip the outdated bundler check when MD5 is not availableseg-outdated-fipsSamuel Giddins2017-12-301-0/+2
| | |
* | | Auto merge of #6168 - akhramov:fix/clean-extensions, r=colby-swandaleThe Bundler Bot2018-01-103-2/+44
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make `bundle clean` clean extension directories ### What was the end-user problem that led to this PR? The problem was that `bundle clean` command doesn't remove gem extensions (#5596) ### What was your diagnosis of the problem? I've looked into `Bundler::Runtime#clean` and realized that extension dirs are not removed ### What is your fix for the problem, implemented in this PR? My fix is to tweak `Bundler::Runtime#clean` to remove extensions dirs as well. ### Why did you choose this fix out of the possible options? I chose this fix because I didn't see any other option.
| * | | Make `bundle clean` clean extension directoriesArtyom Khramov2018-01-103-2/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `bundle clean` command doesn't remove gem extensions, because extensions reside out of gem directories. This change tweaks `Bundler::Runtime#clean` to remove extensions dirs as well.
* | | | Auto merge of #6249 - bundler:typo-fix, r=hsbtThe Bundler Bot2018-01-102-2/+2
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | Fixed typos Found by misspell.
| * | | typofix by misspelltypo-fixSHIBATA Hiroshi2018-01-102-2/+2
|/ / /
* | | Auto merge of #6241 - KrauseFx:patch-1, r=segiddinsThe Bundler Bot2018-01-081-2/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | Update unencrypted http links to https To avoid human-in-the-middle attacks
| * | | Update unencrypted http links to httpsFelix Krause2018-01-041-2/+2
| | |/ | |/| | | | To avoid human-in-the-middle attacks
* | | Auto merge of #6244 - bundler:seg-audit-man-links, r=colby-swandaleThe Bundler Bot2018-01-0816-55/+55
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Man] Audit links to other manpages ### What was the end-user problem that led to this PR? The problem was links to many of our man pages were broken. Closes https://github.com/bundler/bundler-site/issues/355. ### What was your diagnosis of the problem? My diagnosis was we were omitting the section in the link ID. ### What is your fix for the problem, implemented in this PR? My fix manually updates the link IDs to be correct.
| * | | [Man] Audit links to other manpagesseg-audit-man-linksSamuel Giddins2018-01-0416-55/+55
| |/ /
* | | Auto merge of #6177 - bundler:colby/bundle-show-paths, r=indirectThe Bundler Bot2018-01-084-0/+46
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add `--paths` option to `bundle list` command. See #6172 This option mimics the `--paths` options in `bundle show` which is being removed in Bundler 2. Example Usage: ``` $ bundle list --paths /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actioncable-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionmailer-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionpack-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionview-5.1.4 ```
| * | | [CLI::List] Raise when incompatible options are passedcolby/bundle-show-pathsSamuel Giddins2017-12-011-1/+1
| | | |
| * | | add git and gemspec examples to list --paths spec and raise error when ↵Colby Swandale2017-12-012-2/+29
| | | | | | | | | | | | | | | | --only-names + --paths are used together
| * | | add `--paths` option to `bundle list` command.Colby Swandale2017-11-194-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This option mimics the `--paths` options in `bundle show` which is being removed in bundler 2. Example Usage: $ bundle list --paths /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actioncable-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionmailer-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionpack-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionview-5.1.4
* | | | Auto merge of #6237 - MSP-Greg:fix_src_loc_warning, r=segiddinsThe Bundler Bot2018-01-041-2/+4
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix warning in rubygems testing re __FILE__ Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? Testing with trunk & rubygems, many warnings of: `rubygems/lib/rubygems.rb:940: warning: __FILE__ in eval may not return location in binding; use Binding#source_location instead` ### What was your diagnosis of the problem? Updates for warnings & 'security' in trunk are showing issues that should be addressed. ### What is your fix for the problem, implemented in this PR? It's one line... ### Why did you choose this fix out of the possible options? Unaware of other options... Not sure if this will work with all ruby versions. Did not test my fork...
| * | | Fix warning in rubygems testing re __FILE__MSP-Greg2017-12-301-2/+4
|/ / /
* | | Auto merge of #6226 - bundler:seg-travis-2-5, r=segiddinsThe Bundler Bot2017-12-283-6/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | [Travis] Test against Ruby 2.5 The problem was Ruby 2.5 was released yesterday! So this updates Bundler to test against it on CI, as well as acknowledging 2.6 as a new minor.
| * | | [Travis] Test against latest RubyGems versionseg-travis-2-5Samuel Giddins2017-12-262-4/+4
| | | |
| * | | [Travis] Test against latest ruby versionsSamuel Giddins2017-12-261-2/+2
| | | |
| * | | [CurrentRuby] Add 2.6 as a known minorSamuel Giddins2017-12-261-0/+1
| | | | | | | | | | | | | | | | See https://github.com/ruby/ruby/commit/0af050993e9cc55e2f58d8f4677c1521bacf5bea
| * | | [Travis] Test against Ruby 2.5Samuel Giddins2017-12-261-0/+1
| | | |
* | | | Auto merge of #6232 - bundler:fix-ruby25-failing, r=hsbtThe Bundler Bot2017-12-286-86/+87
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | Fix failing examples with Ruby 2.5 Followed up https://github.com/bundler/bundler/pull/6226
| * | | To use exe instead of default name. Because bin name is conflict with Ruby ↵SHIBATA Hiroshi2017-12-281-1/+2
| | | | | | | | | | | | | | | | 2.5 or later
| * | | Added hostname for file protocol in GemfileSHIBATA Hiroshi2017-12-285-85/+85
|/ / /
* | | Merge tag 'v1.16.1'Samuel Giddins2017-12-2722-170/+219
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Version 1.16.1 # gpg: Signature made Fri Dec 22 01:46:37 2017 +07 # gpg: using ? key C3DA1D6CEFC720FA # gpg: Can't check signature: unknown pubkey algorithm # Conflicts: # lib/bundler/version.rb # spec/commands/exec_spec.rb # spec/realworld/double_check_spec.rb # spec/runtime/with_clean_env_spec.rb # spec/spec_helper.rb
| * | | Version 1.16.1 with changelogv1.16.1Samuel Giddins2017-12-212-1/+14
| | | |
| * | | Added workarounds for Travis specific issues.SHIBATA Hiroshi2017-12-214-10/+14
| | | |
| * | | Try to get specs passing on old RubyGemsSamuel Giddins2017-12-217-35/+49
| | | |
| * | | Remove the bundler default spec consistently across ruby versionsSamuel Giddins2017-12-211-2/+9
| | | |
| * | | Fix the pristine spec so it still can access the default gemSamuel Giddins2017-12-212-1/+2
| | | |
| * | | Unregister the bundler default spec in the testsSamuel Giddins2017-12-212-14/+14
| | | |
| * | | [Travis] Use the old trusty image temporarilySamuel Giddins2017-12-121-0/+3
| | | | | | | | | | | | | | | | Woraround for https://github.com/travis-ci/travis-ci/issues/8892
View Lorry Controller Status