summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* fix documented init gems rb config env varcolby/fix-new-init-env-varColby Swandale2017-08-041-1/+1
|
* Auto merge of #5906 - arbonap:pa-add-aliases, r=colby-swandaleThe Bundler Bot2017-07-286-10/+14
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add missing flag aliases to docs 🌟 Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was... - I noticed in the documentation that a lot of aliases for flags were missing. ### What was your diagnosis of the problem? My diagnosis was... - I added missing aliases for flags into the documentation. ### What is your fix for the problem, implemented in this PR? My fix... - I added the missing flag aliases into the docs, so that users can more easily access this information. 💖 - I also added in a line describing how RSpec is the default testing framework ### Why did you choose this fix out of the possible options? I chose this fix because... - more bundler knowledge for bundler users is helpful 🍒
| * Add missing flag aliases to docsPatricia Arbona2017-07-286-10/+14
|/
* Auto merge of #5901 - bundler:seg-bundler-2-tasks, r=indirectThe Bundler Bot2017-07-262-0/+18
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add tasks to make running in 2.0 mode easier ### What was the end-user problem that led to this PR? The problem was it was too difficult to run Bundler in 2.0 mode. ### What was your diagnosis of the problem? My diagnosis was we needed a way to install a dev version of 2.0, and also to run commands as bundler 2. ### What is your fix for the problem, implemented in this PR? My fix adds a `bin/bundle2` bin stub that runs bundler as 2.0.0.dev, and a `bundle_2:install` rake task that will install `bundler-2.0.0.dev`
| * Add a task to install a bundler 2 dev gemseg-bundler-2-tasksSamuel Giddins2017-07-261-0/+10
| |
| * Add bundle2 binstubSamuel Giddins2017-07-261-0/+8
|/
* Auto merge of #5896 - bundler:seg-globally-cache-git-repos, r=indirectThe Bundler Bot2017-07-254-15/+21
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Source::Git] Cache repos globally ### What was the end-user problem that led to this PR? Closes https://github.com/bundler/bundler/issues/5895. The problem was: > Now that we have a "global" user-wide cache of gems, it would be great to also have a user-wide place to keep git repos. In 1.x, the default system path provided that user-wide cache, and losing it because of the default 2.0 path will slow down installs with git repos by a lot. ### What was your diagnosis of the problem? My diagnosis was we needed to change the git cache location to something global ### What is your fix for the problem, implemented in this PR? My fix uses the global "~/.bundle/cache" directory to cache git gems ### Why did you choose this fix out of the possible options? I chose this fix because it means the cache (which only contains _downloaded_ information, nothing evaluated at runtime) can be shared across every app and every ruby version
| * [Source::Git] Cache repos globallyseg-globally-cache-git-reposSamuel Giddins2017-07-254-15/+21
| |
* | Auto merge of #5892 - arbonap:pa-gemfile-doc-changes, r=colby-swandaleThe Bundler Bot2017-07-251-0/+31
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add more background explanations to bundle-install and gemfile docs Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was... - I thought the `bundle-install` and `gemfile` docs could have more background explanations. ### What was your diagnosis of the problem? My diagnosis was... - Given more clarifying background information regarding some Ruby-specific domain knowledge, this can help those newer to the Ruby community. ♦️ ### What is your fix for the problem, implemented in this PR? My fix... - I gave a general overview of various Ruby implementations, and explained what git submodules and gemspecs are. ### Why did you choose this fix out of the possible options? I chose this fix because... - @rubymorillo and @indirect gave me the go-ahead to give more background information about these topics 👍🏽 - please let me know what y'all think, I'm happy to incorporate edits
| * | Add bundle-install and gemfile background explanationsPatricia Arbona2017-07-231-0/+31
| | |
* | | Auto merge of #5897 - bundler:colby/gem-empty-name-validation, r=segiddinsThe Bundler Bot2017-07-253-0/+13
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add clear error message when using a gem in the Gemfile with an empty name ### What was the end-user problem that led to this PR? Users are allowed to add a gem to the Gemfile with an empty string as the name but Bundler won't find a gem with an empty and does not make this clear as possible to the end user. Using a Gemfile like: ``` source 'https://rubygems.org' gem '', git: 'https://github.com/rack/rack' ``` Bundler will print the following: ``` › dbundler install Fetching https://github.com/rack/rack Fetching gem metadata from https://rubygems.org/. Fetching gem metadata from https://rubygems.org/........... Fetching gem metadata from https://rubygems.org/... Could not find gem '' in https://github.com/rack/rack (at master@8693330). The source does not contain any versions of '' ``` ### What is your fix for the problem, implemented in this PR? Check the name of the gem in the DSL. If the name is empty print a clear message to the user that using an empty name is not allowed ``` [!] There was an error parsing `Gemfile`: an empty gem name is not valid. Bundler cannot continue. # from /Users/c/Desktop/Projects/testapp/Gemfile:2 # ------------------------------------------- # source 'https://rubygems.org' > gem '', git: 'https://github.com/rack/rack' # ------------------------------------------- ```
| * | add more clear error message for user when adding a gem in the Gemfile with ↵colby/gem-empty-name-validationColby Swandale2017-07-253-0/+13
|/ / | | | | | | an empty name
* | Auto merge of #5860 - bundler:seg-validate-settings, r=segiddinsThe Bundler Bot2017-07-2546-187/+518
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce the notion of settings validation & default install to ./.bundle Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was... ### What was your diagnosis of the problem? My diagnosis was... ### What is your fix for the problem, implemented in this PR? My fix... ### Why did you choose this fix out of the possible options? I chose this fix because...
| * | Ensure sudo specs are run against system gems for consistencyseg-validate-settingsSamuel Giddins2017-07-241-0/+3
| | |
| * | [Validator] Inspect array of symbols for 1.8.7 compatibilitySamuel Giddins2017-07-241-1/+1
| | |
| * | Untangle the system gem path and the default bundle path in the specsSamuel Giddins2017-07-2423-85/+123
| | |
| * | fixup! Add unit tests for the settings validatorSamuel Giddins2017-07-231-2/+2
| | |
| * | Hash#to_h does not exist on old rubiesSamuel Giddins2017-07-231-1/+1
| | |
| * | Add unit tests for the settings validatorSamuel Giddins2017-07-233-6/+117
| | |
| * | Make the doctor specs robust against SystemExitSamuel Giddins2017-07-231-9/+6
| | |
| * | nil out @configured in Bundler.reset!Samuel Giddins2017-07-231-0/+1
| | | | | | | | | | | | Ensures the unit tests can safely use different bundle paths
| * | [EndpointSpecification] Ensure all ivars are initializedSamuel Giddins2017-07-231-0/+1
| | |
| * | Update the specs for the default bundle path being ./.bundleSamuel Giddins2017-07-2310-35/+75
| | |
| * | Default the install path to ./bundle in Bundler 2Samuel Giddins2017-07-2315-46/+90
| | |
| * | Introduce the notion of settings validationSamuel Giddins2017-07-235-22/+118
| |/
* | Auto merge of #5891 - arbonap:master, r=segiddinsThe Bundler Bot2017-07-251-30/+30
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Alphabetize install flags; add links to Rubygems docs Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was... - I noticed the flag options for the `bundle install` docs weren't alphabetized. - Also, at the end of the `bundle install` page, I created links to the RubyGems docs regarding the `gem install` command. ### What was your diagnosis of the problem? My diagnosis was... - I asked around and found out the flags weren't ordered by importance or anything like that, so I decided to alphabetize them. ### What is your fix for the problem, implemented in this PR? My fix... - I alphabetized the flags on the `bundle install` page ✨ ### Why did you choose this fix out of the possible options? I chose this fix because... - Hopefully this can help users more quickly find the `bundle install` flag they want to read up on. 🙌🏽
| * | Alphabetize install flags; add links to Rubygems docsPatricia Arbona2017-07-211-30/+30
| | |
* | | Auto merge of #5874 - rubymorillo:rubymorillo-edits-1, r=segiddinsThe Bundler Bot2017-07-241-6/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated Development setup page Hey @indirect @segiddins, I've implemented the suggested updates that @arbonap provided. Specifically, adding a new step 1 (how to fork a repo), and adding instructions for creating aliases in bash.
| * | | Updated Development setup pageStephanie Morillo2017-07-191-6/+8
| | | | | | | | | | | | | | | | | | | | Hey @indirect @segiddins, I've implemented the suggested updates that @arbonap provided. Specifically, adding a new step 1, and adding instructions for creating aliases in bash.
* | | | Auto merge of #5878 - bundler:seg-bundler-binstubs, r=indirectThe Bundler Bot2017-07-249-19/+225
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a special bundler binstub that ensures the correct version is activated ### What was the end-user problem that led to this PR? Closes https://github.com/bundler/bundler/issues/5876. > Once Bundler 2 ships, each application will depend on a 1.x or 2.x version of Bundler. We want to make sure that the user always has an _easy_ and _convenient_ way to activate the version of Bundler their app is depending upon. ### What was your diagnosis of the problem? > One way to ensure that the application will always get the version of Bundler that it needs is with an application-and-bundler-version specific binstub. Let's make it so that bundle binstubs bundler will generate a binstub for the correct version of Bundler, and simply running bin/bundle will always provide the correct version of Bundler. ### What is your fix for the problem, implemented in this PR? My fix implements a `bundle` binstub when `bundle binstubs bundler` is run ### Why did you choose this fix out of the possible options? I chose this fix because it allows us to dynamically select the correct Bundler version (with appropriate overrides, such as `$BUNDLER_VERSION` and `bundle update --bundler`), both when invoking `bin/bundle`, and also when invoking other bundler-generated binstubs.
| * | | Update binstubs specs to handle legacy rubygemsseg-bundler-binstubsSamuel Giddins2017-07-211-1/+4
| | | |
| * | | Quote env var values for ruby < 2 popenSamuel Giddins2017-07-211-1/+1
| | | |
| * | | Re-format the bundle binstub to conform to Bundler standardSamuel Giddins2017-07-211-10/+19
| | | |
| * | | Handle when Bundler is only available on the load pathSamuel Giddins2017-07-213-7/+20
| | | |
| * | | Add a special bundler binstub that ensures the correct version is activatedSamuel Giddins2017-07-217-15/+196
| | | |
* | | | Auto merge of #5893 - greysteil:add-prerelease-spec, r=segiddinsThe Bundler Bot2017-07-222-0/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Add spec for prerelease dependency resolution Bundler-specific version of https://github.com/CocoaPods/Resolver-Integration-Specs/pull/12. We didn't have any specs for resolving pre-release versions before, and I'm nervous about https://github.com/CocoaPods/Molinillo/pull/69 breaking this when introduced.
| * | | | Add spec for prerelease dependency resolutionGrey Baker2017-07-222-0/+9
|/ / / /
* | | | Auto merge of #5882 - bundler:rubymorillo-patch-1, r=colby-swandaleThe Bundler Bot2017-07-221-0/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add graph re: bundle exec modifying lockfile Hey team, I've added a graph to the documentation that explains why bundle exec makes changes to Gemfile.lock. It was originally referenced in this issue: https://github.com/bundler/bundler/issues/5245 Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was lack of clarity around why the `bundle exec` command modified the lock file. A user brought it up here: https://github.com/bundler/bundler/issues/5245 and the determination was to add it to the man page. ### What was your diagnosis of the problem? My diagnosis was to add a graph in the "Environmental Modifications" section to explain the issue. ### What is your fix for the problem, implemented in this PR? My fix was to update the docs! \o/ ### Why did you choose this fix out of the possible options? I chose this fix because enough users referenced it as a problem that needed to be addressed.
| * | | | Removed whitespaceStephanie Morillo2017-07-211-5/+5
| | | | | | | | | | | | | | | From lines 66-71.
| * | | | Add graph re: bundle exec modifying lockfileStephanie Morillo2017-07-201-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | Hey team, I've added a graph to the documentation that explains why bundle exec makes changes to Gemfile.lock. It was originally referenced in this issue: https://github.com/bundler/bundler/issues/5245
* | | | | Auto merge of #5883 - bundler:rubymorillo-patch-2, r=colby-swandaleThe Bundler Bot2017-07-221-0/+1
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add line re: CGI escape Added a sentence in line 291 re: CGI escaping passwords and usernames. Resolves issue: https://github.com/bundler/bundler/issues/5643 Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was needing to make it clear that users had to CGI escape usernames and passwords before pushing to remote. Referenced here: https://github.com/bundler/bundler/issues/5643 ### What was your diagnosis of the problem? My diagnosis was to add a sentence to the man page as a reminder. ### What is your fix for the problem, implemented in this PR? My fix was to add a sentence to the man page :) ### Why did you choose this fix out of the possible options? I chose this fix because it would make things clearer for users.
| * | | | Add line re: CGI escapeStephanie Morillo2017-07-201-0/+1
| |/ / / | | | | | | | | Added a sentence in line 291 re: CGI escaping passwords and usernames. Resolves issue: https://github.com/bundler/bundler/issues/5643
* | | | Merge tag 'v1.15.3'Samuel Giddins2017-07-212-1/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Version 1.15.3 # Conflicts: # lib/bundler/cli.rb # spec/bundler/cli_spec.rb
| * | | | Version 1.15.3 with changelogv1.15.3Samuel Giddins2017-07-212-1/+8
| | | | |
| * | | | Auto merge of #5890 - bundler:seg-require-gemdeps, r=colby-swandaleThe Bundler Bot2017-07-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [RubyGemsIntegration] Require bundler/gemdeps before using it ### What was the end-user problem that led to this PR? The problem was `Bundler.rubygems.use_gemdeps` would raise a missing constant error. ### What was your diagnosis of the problem? My diagnosis was we needed to require the gemdeps file ### What is your fix for the problem, implemented in this PR? My fix requires the gemdeps file. ### Why did you choose this fix out of the possible options? I chose this fix because watching autocorrect struggle to understand that `gemdeps` is not the same as `genders` is priceless. (cherry picked from commit 4bcb475eecedf2a84c3aa6cf077e137f430784d1)
| * | | | Auto merge of #5885 - bundler:seg-yaml-empty-string-values, r=segiddinsThe Bundler Bot2017-07-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [YAMLSerializer] Handle empty strings properly ### What was the end-user problem that led to this PR? The problem was that empty strings in YAML were being read in as empty hashes. Closes https://github.com/bundler/bundler/issues/5881. ### What was your diagnosis of the problem? My diagnosis was we needed to fix the YAML Serializer to understand `""` as an empty string. ### What is your fix for the problem, implemented in this PR? My fix ensures that a hash isn't created when the parser encounters `""`. (cherry picked from commit d273f2116e5e7de1f8c453a15487e1699d2c08f5)
| * | | | Auto merge of #5884 - bundler:seg-no-bundler-versio-warning-when-parseable, ↵The Bundler Bot2017-07-212-7/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=segiddins [CLI] Dont print an outdated version warning when running a parseable command ### What was the end-user problem that led to this PR? The problem was the outdated bundler version warning could be printed when running a command whose output should be parseable. @schneems pointed this out on twitter ### What was your diagnosis of the problem? My diagnosis was parsable commands needed to have such extraneous output suppressed. ### What is your fix for the problem, implemented in this PR? My fix was to use the blacklist from printing the running command to bail out on the outdated bundler version warning as well. ### Why did you choose this fix out of the possible options? I chose this fix because it means we can have a single list of parseable command. (cherry picked from commit 4da6724d61257d658c048b83e5b60be91d6658a6) # Conflicts: # lib/bundler/cli.rb # spec/bundler/cli_spec.rb
* | | | | Auto merge of #5888 - bundler:rubymorillo-patch-3, r=indirectThe Bundler Bot2017-07-211-0/+11
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding graphs explaining binstubs Added a paragraph that explains what binstubs is and how it works, per feedback from @arbonap. Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was...without an explanation of what binstubs is and what it does, it's difficult for users to understand where to apply the binstubs command. Shout out to @arbonap for calling this out! ### What was your diagnosis of the problem? My diagnosis was...to take a wonderful explanation given by @indirect about what binstubs are and turn it into a paragraph! 😄 ### What is your fix for the problem, implemented in this PR? My fix...is two intro paragraphs in the "DESCRIPTION" section, before going into what the command does. ### Why did you choose this fix out of the possible options? I chose this fix because...explanations help users 👍
| * | | | Remove whitespace, change sentenceStephanie Morillo2017-07-211-7/+7
| | | | | | | | | | | | | | | Removed the whitespace in sentences 10, 11, 13, 17, and 18, and edited one of the sentences per @indirect's recommendation.
| * | | | Adding graphs explaining binstubsStephanie Morillo2017-07-201-0/+11
| | |/ / | |/| | | | | | Added a paragraph that explains what binstubs is and how it works, per feedback from @arbonap.
View Lorry Controller Status