summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Address additional feedback.indirect/policies-docAndre Arko2018-03-042-10/+16
|
* Fix unclear bits h/t @deivid-rodriguezAndre Arko2018-02-021-3/+3
|
* Add a POLICIES documentAndre Arko2018-01-312-1/+72
|
* Auto merge of #6129 - ajwann:check-permissions-in-doctor-command, ↵The Bundler Bot2018-01-312-36/+131
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=colby-swandale check permissions in doctor command Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was... #5786 > We should have a check in bundle doctor for the file/folder permissions in the Bundler home directory. >We should print a warning if there are any files/folders that is owned by another user but is readable/writable but prints an error when a file cannot be read or written to. ### What is your fix for the problem, implemented in this PR? Created private method ```check_home_permissions``` that will print a warning if there are any files/folders that are owned by another user but are readable/writable, and print an error when the bundler home dir contains a file cannot be read or written to ### Why did you choose this fix out of the possible options? I chose this fix because it's what was requested in the open issue.
| * wrap similar tests in context blocksAdam Wanninger2018-01-251-75/+78
| |
| * warn user if a file is not R/W and owned by another userAdam Wanninger2018-01-252-1/+29
| |
| * corrected spelling of stil to stillAdam Wanninger2018-01-252-2/+2
| |
| * readable/writable is more descriptive than read/writeAdam Wanninger2018-01-251-1/+1
| |
| * 'to the current user' should be 'by the current user'Adam Wanninger2018-01-252-2/+2
| |
| * [CLI::Doctor] Avoid looping over all files twiceSamuel Giddins2018-01-252-27/+30
| |
| * prefix outputted files with a - for readabilityAdam Wanninger2018-01-252-4/+6
| |
| * use Bundler.ui.info instead of exceptionAdam Wanninger2018-01-252-13/+13
| |
| * check Bundler.home permissions in doctor commandAdam Wanninger2018-01-252-15/+74
| |
* | Auto merge of #6273 - joelvh:feature/bundle_update_gemfile_option, ↵The Bundler Bot2018-01-314-0/+83
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=colby-swandale Added `--gemfile` option to `bundle update` Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was that `BUNDLE_GEMFILE` is not respected when `.bundle/config` specifies an alternate Gemfile. However, my specific issue is that `bundle install --gemfile Gemfile2` is an option, but `bundle update` won't let me specify an alternate Gemfile. ### What was your diagnosis of the problem? My diagnosis was that Bundler copies `BUNDLE_GEMFILE` environment variable to `BUNDLE_ORIG_GEMFILE` and always uses `.bundle/config`. Simplest solution was to add parity to `bundle update` rather than diagnose why environment variables don't override `.bundle/config` settings across the board. ### What is your fix for the problem, implemented in this PR? My fix is to add the `--gemfile` option to `bundle update` for parity with `bundle install`. ### Why did you choose this fix out of the possible options? I chose this fix because this allows installing and updating alternative Gemfiles without untangling environment variables. It's the most direct use case that I'm having this issue with. Ideally, the environment variables specified for a command should be respected and override settings in `.bundle/config` (https://github.com/bundler/bundler/issues/6270).
| * | fix whitespace to make rubocop happy and add spacing between `it blocksColby Swandale2018-01-271-1/+2
| | |
| * | Added a note about why `BUNDLE_GEMFILE` is specified in these specsJoel Van Horn2018-01-252-0/+4
| | |
| * | Added spacing and `before` in specJoel Van Horn2018-01-251-2/+4
| | |
| * | Added spec from `spec/commands/install_spec.rb`Joel Van Horn2018-01-251-0/+13
| | |
| * | Added `--gemfile` option to `bundle update`Joel Van Horn2018-01-242-0/+63
| | |
* | | Auto merge of #6266 - nilsding:init-check-dir-writable, r=colby-swandaleThe Bundler Bot2018-01-302-0/+23
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Init] Check if the current directory is writeable ### What was the end-user problem that led to this PR? The problem was that when running `bundle init` inside a directory which is not writable by the current user (e.g. `/` as demonstrated in #6219) Bundler prints out an `EACCES` error with a huge backtrace. In the mentioned PR @segiddins suggested to print out a better error message. This PR addresses that. ### What was your diagnosis of the problem? See [this comment on said PR](https://github.com/bundler/bundler/issues/6219#issuecomment-359002919). ### What is your fix for the problem, implemented in this PR? My fix is simple: adding a check whether the current directory is writeable before trying to create `gems.rb`/`Gemfile`. If that's not the case, print out an error and exit. ### Why did you choose this fix out of the possible options? I chose this fix because... it was really simple to implement.
| * | | Remove >= 2 tag; manually chmod a-w the dirGeorg Gadinger2018-01-201-2/+4
| | | |
| * | | Make writable spec pass on Ruby < 2.4Georg Gadinger2018-01-191-2/+2
| | | |
| * | | [Init] Check if the current directory is writableGeorg Gadinger2018-01-192-0/+21
| | | |
* | | | Auto merge of #6275 - bundler:colby/fix-exec-failing-test, r=segiddinsThe Bundler Bot2018-01-301-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix failing spec in the bundle exec system gem spec ### What was your diagnosis of the problem? There is an issue where a spec was failing because it was activating the version of Bundler inside of RubyGems and not the development version that we're working on. This would cause the Lockfile to raise an error because we were generating a Bundler 2 lockfile in our tests but Bundler 1 was being activated making it complain. ### What is your fix for the problem, implemented in this PR? Add the Bundler development dir in the Ruby include argument. ### Why did you choose this fix out of the possible options? This error is raising in CI and is preventing PRs from being merged. See https://travis-ci.org/bundler/bundler/jobs/333434747
| * | | | Fix failing spec in the bundle exec system gem speccolby/fix-exec-failing-testColby Swandale2018-01-261-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was an issue where a spec was failing because it was activating the version of bundler inside of RubyGems and not the development version that we're working on. This would cause the Lockfile to raise an error because we were generating a Bundler 2 lockfile but Bundler 1 was being activated.
* | | | Auto merge of #6272 - bundler:colby/update-small-bugs-link, r=colby-swandaleThe Bundler Bot2018-01-241-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Update contributing documentation to use new tags Github has defined a couple of tags to use for classifying issues that are suitable for new contributors to fix/contribute towards. We have started using these tags in Github so we should start linking to them in our documentation as well.
| * | | | Update contributing documentation to use new tagscolby/update-small-bugs-linkColby Swandale2018-01-241-1/+1
|/ / / / | | | | | | | | Github has defined a couple of tags to use for classifying issues that are suitable for new contributors to fix/contribute towards. We have started using these tags in Github so we should start linking to them in our documentation as well.
* | | | Auto merge of #6267 - christhekeele:scaffold-error-class, r=colby-swandaleThe Bundler Bot2018-01-232-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add base error class to new gems. Closes #6260. Room for discussion: - Which error class to use (`StandardError` makes sense to me) - What formatting to use (the three-lines-with-comment seemed nicest to me) - Whether or not using the flag to provide a different error base class is useful, and if it should validate the user's choice or not (I threw it in because it seemed harmless; is it? a boolean flag would work fine too) --- ### What was the end-user problem that led to this PR? Libraries don't always follow best practice from discussion in linked issue. ### What was your diagnosis of the problem? Bundler could encourage best practice by adding it to the gem scaffold. ### What is your fix for the problem, implemented in this PR? I added a base error class to the templates, and provided a flag to change/disable this behaviour. ### Why did you choose this fix out of the possible options? Like any best-practice-by-default, this could ruin someones workflow/go against someone's preferences so I made it as configurable as possible.
| * | | | Simplify error class stuff.Chris Keele2018-01-194-53/+1
| | | | |
| * | | | Add base error class to new gems.Chris Keele2018-01-194-0/+57
| | | | | | | | | | | | | | | | | | | | Closes #6260.
* | | | | Auto merge of #6262 - bundler:colby/update-bundler-authors, r=colby-swandaleThe Bundler Bot2018-01-221-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | add the new team members of the bundler core team to the author list in the Bundler gemspec Just adding myself and Hiroshi-san to the list of authors in the Bundler gemspec \cc @indirect
| * | | | add the new team members of the bundler core team to the author list in the ↵colby/update-bundler-authorsColby Swandale2018-01-181-1/+1
| | | | | | | | | | | | | | | | | | | | Bundler gemspec
* | | | | Auto merge of #6264 - bundler:colby/client-index-gzip-error, r=indirectThe Bundler Bot2018-01-192-6/+19
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | handle gzip corruption errors in the compact index client ### What was the end-user problem that led to this PR? Bundler will raise an exception and crash if the Gzip that the Compact Client Index downloaded was corrupt. ### What was your diagnosis of the problem? See #6261 ### What is your fix for the problem, implemented in this PR? Handle the exception and allow Bundler to continue without crashing
| * | | | handle gzip corruption errors in the compact index clientcolby/client-index-gzip-errorColby Swandale2018-01-192-6/+19
| |/ / /
* | | | Auto merge of #6254 - bundler:seg-friendly-error-fallback, r=segiddinsThe Bundler Bot2018-01-161-0/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [FriendlyErrors] Fallback to the original error if the friendly message raises ### What was the end-user problem that led to this PR? This would have made diagnosing https://github.com/bundler/bundler/issues/6220 much easier ### What was your diagnosis of the problem? My diagnosis was we do a lot in our error handler, so it needs a fallback ### What is your fix for the problem, implemented in this PR? My fix falls back to just re-raising the original error
| * | | | [FriendlyErrors] Fallback to the original error if the friendly message raisesseg-friendly-error-fallbackSamuel Giddins2018-01-121-0/+2
| |/ / / | | | | | | | | | | | | This would have made diagnosing https://github.com/bundler/bundler/issues/6220 much easier
* | | | Auto merge of #6235 - Debian:samueloph_typo, r=colby-swandaleThe Bundler Bot2018-01-161-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | [man] fix typo on bundle-binstubs Typo found while i was packaging 1.16.1 for Debian
| * | | | [man] fix typo on bundle-binstubsSamuel Henrique2017-12-281-1/+1
| | | | |
* | | | | Auto merge of #6257 - bundler:seg-rename-bundler-frozen, r=segiddinsThe Bundler Bot2018-01-168-14/+14
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename Bundler.frozen? to avoid Object method conflict ### What was the end-user problem that led to this PR? The problem was `Bundler` overrode the `Object#frozen?` method to mean something else, breaking anything that checks that method to determine if an object is frozen. Closes #6252. ### What was your diagnosis of the problem? My diagnosis was the method name had to be changed.
| * | | | | Rename Bundler.frozen? to avoid Object method conflictseg-rename-bundler-frozenSamuel Giddins2018-01-158-14/+14
| | | | | |
* | | | | | Auto merge of #6258 - bundler:seg-fix-travis-ruby-2.5, r=colby-swandaleThe Bundler Bot2018-01-161-0/+2
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Source::RubyGems] Ensure the bindir exists before installing ### What was the end-user problem that led to this PR? The problem was occasional failures on CI w/ ruby 2.5 ### What was your diagnosis of the problem? My diagnosis was that there was a race condition in the rubygems installer, see https://github.com/rubygems/rubygems/pull/2148 for the fix there. ### What is your fix for the problem, implemented in this PR? My fix will ensure that directory is created before we get into that rubygems code path
| * | | | | [Source::RubyGems] Ensure the bindir exists before installingseg-fix-travis-ruby-2.5Samuel Giddins2018-01-151-0/+2
|/ / / / / | | | | | | | | | | | | | | | This will help avoid a potential race condition in RubyGems
* | | | | Auto merge of #6238 - bundler:seg-outdated-fips, r=olleolleolleThe Bundler Bot2018-01-131-0/+2
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [CLI] Skip the outdated bundler check when MD5 is not available ### What was the end-user problem that led to this PR? The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception. Closes #6032. ### What was your diagnosis of the problem? My diagnosis was we needed to skip the check when MD5 is unavailable. ### Why did you choose this fix out of the possible options? I chose this fix because using `#available?` would make network requests, which is not acceptable.
| * | | | [CLI] Skip the outdated bundler check when MD5 is not availableseg-outdated-fipsSamuel Giddins2017-12-301-0/+2
| | | | |
* | | | | Auto merge of #6168 - akhramov:fix/clean-extensions, r=colby-swandaleThe Bundler Bot2018-01-103-2/+44
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make `bundle clean` clean extension directories ### What was the end-user problem that led to this PR? The problem was that `bundle clean` command doesn't remove gem extensions (#5596) ### What was your diagnosis of the problem? I've looked into `Bundler::Runtime#clean` and realized that extension dirs are not removed ### What is your fix for the problem, implemented in this PR? My fix is to tweak `Bundler::Runtime#clean` to remove extensions dirs as well. ### Why did you choose this fix out of the possible options? I chose this fix because I didn't see any other option.
| * | | | | Make `bundle clean` clean extension directoriesArtyom Khramov2018-01-103-2/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `bundle clean` command doesn't remove gem extensions, because extensions reside out of gem directories. This change tweaks `Bundler::Runtime#clean` to remove extensions dirs as well.
* | | | | | Auto merge of #6249 - bundler:typo-fix, r=hsbtThe Bundler Bot2018-01-102-2/+2
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | Fixed typos Found by misspell.
| * | | | | typofix by misspelltypo-fixSHIBATA Hiroshi2018-01-102-2/+2
|/ / / / /
* | | | | Auto merge of #6241 - KrauseFx:patch-1, r=segiddinsThe Bundler Bot2018-01-081-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update unencrypted http links to https To avoid human-in-the-middle attacks
| * | | | | Update unencrypted http links to httpsFelix Krause2018-01-041-2/+2
| | |/ / / | |/| | | | | | | | To avoid human-in-the-middle attacks
View Lorry Controller Status