Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Move local variable to only branch where it's usedissue-4436 | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | |||||
* | Fix open default gem error | Zehan Zhao | 2019-08-16 | 2 | -5/+22 |
| | |||||
* | Wrap `open` specs with a context | David Rodríguez | 2019-08-16 | 1 | -69/+71 |
| | | | | So I can add another context that doesn't run the `before` block. | ||||
* | Prefer `before` to `before :each` | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | |||||
* | Merge #7303 | Bundlerbot | 2019-08-16 | 11 | -111/+87 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7303: Refactor ruby core integration r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that sometimes we break specs when integrating bundler changes into core. ### What was your diagnosis of the problem? My diagnosis was that sometimes we use paths dependent on the structure of this repo, but that break under ruby-core's structure. ### What is your fix for the problem, implemented in this PR? My fix is only some refactoring so that usage of structure independent helpers is encouraged. After this set of changes, if you grep the repo for `ruby_core?`, the only result will be `spec/support/path.rb`. That means that all logic dealing with repo folder structure lives in a single place. ### Why did you choose this fix out of the possible options? I chose this fix because it makes the integration in core cleaner. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> | ||||
| * | Extract a `gemspec_dir` helperrefactor_ruby_core_integration | David Rodríguez | 2019-08-16 | 2 | -2/+5 |
| | | |||||
| * | Extract yet another helper method | David Rodríguez | 2019-08-16 | 2 | -20/+19 |
| | | |||||
| * | Extract a `root_gemspec` local variable | David Rodríguez | 2019-08-16 | 1 | -3/+4 |
| | | |||||
| * | Extract a `with_root_gemspec` helper | David Rodríguez | 2019-08-16 | 3 | -14/+14 |
| | | |||||
| * | Only chdir when necessary | David Rodríguez | 2019-08-16 | 1 | -16/+14 |
| | | |||||
| * | Make sure gem has been built before deleteng it | David Rodríguez | 2019-08-16 | 1 | -11/+13 |
| | | |||||
| * | Cleanup in a location independent way | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | | |||||
| * | Remove obvious comment | David Rodríguez | 2019-08-16 | 1 | -1/+0 |
| | | |||||
| * | Remve another unneeded `to_s` | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | | | | | | | | `FileUtils.rm` supports a `Pathname` argument. | ||||
| * | Remove unneeded `to_s` calls | David Rodríguez | 2019-08-16 | 2 | -3/+3 |
| | | | | | | | | They are implicit inside `gem_command!`. | ||||
| * | Consistently use `Path` over `Spec::Path` | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | | |||||
| * | Extract single gem installation logic | David Rodríguez | 2019-08-16 | 1 | -3/+7 |
| | | |||||
| * | Unalias `install_gem` | David Rodríguez | 2019-08-16 | 2 | -3/+1 |
| | | | | | | | | Since I plan to reuse it for something else. | ||||
| * | Use `join` consistently | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | | |||||
| * | Extract a `lib_tracked_files` path helper | David Rodríguez | 2019-08-16 | 2 | -4/+4 |
| | | |||||
| * | Rename a variable | David Rodríguez | 2019-08-16 | 1 | -4/+4 |
| | | | | | | | | Otherwise I get conflicts when extracting the helper. | ||||
| * | Extract a `tracked_files` path helper | David Rodríguez | 2019-08-16 | 2 | -4/+4 |
| | | |||||
| * | Rename some variables | David Rodríguez | 2019-08-16 | 1 | -19/+19 |
| | | | | | | | | | | | | I want to extract these to path helper methods, but the name `files` conflict with some builder methods that are also available at the same level. | ||||
| * | Reconcile test | David Rodríguez | 2019-08-16 | 1 | -3/+1 |
| | | | | | | | | The `:bundler` gem is not needed in the regular repo either. | ||||
| * | Reuse `gem_bin` helper inside `gem_command` | David Rodríguez | 2019-08-16 | 1 | -2/+1 |
| | | | | | | | | | | The logic for choosing `gem_bin` should work here too even if it's not identical. | ||||
| * | Always use `--backtrace` when invoking `gem` CLI | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | | | | | | | | For debuggability. | ||||
| * | Extract a `gem_bin` path helper | David Rodríguez | 2019-08-16 | 2 | -1/+5 |
| | | |||||
| * | Reuse `gem_command!` helper | David Rodríguez | 2019-08-16 | 1 | -8/+4 |
| | | |||||
| * | Remove more dead code | David Rodríguez | 2019-08-16 | 1 | -5/+1 |
| | | |||||
| * | Remove dead code | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | | |||||
| * | Remove unnecessary rubygems require | David Rodríguez | 2019-08-16 | 1 | -1/+1 |
| | | |||||
| * | Use path helpers to find bundle bin | David Rodríguez | 2019-08-16 | 1 | -2/+1 |
| | | |||||
| * | Fix bundle bin location in core repo | David Rodríguez | 2019-08-16 | 2 | -2/+2 |
| | | |||||
| * | Reuse more shared path helpers | David Rodríguez | 2019-08-16 | 3 | -18/+4 |
| | | |||||
| * | Remove unnecessary assignment | David Rodríguez | 2019-08-16 | 1 | -2/+2 |
| | | |||||
| * | Remove unnecessary `let` | David Rodríguez | 2019-08-16 | 1 | -3/+2 |
| | | | | | | | | Use shared helper instead. | ||||
| * | Move `lib` helper together with path helpers | David Rodríguez | 2019-08-16 | 2 | -4/+4 |
| | | |||||
| * | Reuse `lib` method | David Rodríguez | 2019-08-16 | 1 | -1/+0 |
| | | |||||
| * | Remove duplicated method | David Rodríguez | 2019-08-16 | 4 | -8/+4 |
|/ | |||||
* | Merge #7306 | Bundlerbot | 2019-08-16 | 1 | -0/+0 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7306: Fixup #7297 r=hsbt a=hsbt ### What was the end-user problem that led to this PR? `build_metadata_spec.rb` was inconsistency structure. ### What was your diagnosis of the problem? I missed checking the file location of #7297 ### What is your fix for the problem, implemented in this PR? Move file under `spec/bundler`. ### Why did you choose this fix out of the possible options? Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org> | ||||
| * | Fixup #7297 | Hiroshi SHIBATA | 2019-08-16 | 1 | -0/+0 |
|/ | |||||
* | Merge #7301 | Bundlerbot | 2019-08-16 | 6 | -9/+11 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7301: Track changes from ruby core master r=hsbt a=hsbt ### What was the end-user problem that led to this PR? I'm going to merge https://github.com/bundler/bundler/pull/7274. But the ruby-core source has some of the changes for bundler source. ### What was your diagnosis of the problem? ### What is your fix for the problem, implemented in this PR? ruby core team fixed them: * Removed circular require warning at `shared_helper.rb` * Support test at GitHub Actions, It helps that bundler will migrate Actions from Azure Pipelines too. * Fixed broken examples at ruby core repository ### Why did you choose this fix out of the possible options? Co-authored-by: ohbarye <over.rye@gmail.com> Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org> Co-authored-by: Yusuke Endoh <mame@ruby-lang.org> | ||||
| * | Fixed rubocop errortrack-ruby-core-master | Hiroshi SHIBATA | 2019-08-16 | 1 | -2/+2 |
| | | |||||
| * | lib/bundler/shared_helpers.rb: remove require "rubygems" | Yusuke Endoh | 2019-08-14 | 1 | -1/+0 |
| | | | | | | | | Because it causes circular require. | ||||
| * | Fixed up 365ee22d73ec73c119a842de271504e04bed6f45 | Hiroshi SHIBATA | 2019-08-14 | 1 | -1/+1 |
| | | |||||
| * | Fixed the broken example with ruby core structure. | Hiroshi SHIBATA | 2019-08-14 | 1 | -1/+2 |
| | | |||||
| * | Added example filter for Linux of GitHub Actions. | Hiroshi SHIBATA | 2019-08-14 | 2 | -1/+2 |
| | | |||||
| * | Re-use GITHUB_ACTION variables for filtering bundler examples. | Hiroshi SHIBATA | 2019-08-14 | 2 | -4/+4 |
| | | |||||
| * | GitHub Actions does not support ANSI color code. Skip failing examples. | Hiroshi SHIBATA | 2019-08-14 | 1 | -1/+1 |
| | | |||||
| * | Explicitly ignored GEMRC environmental variable. | Hiroshi SHIBATA | 2019-08-14 | 1 | -0/+1 |
| | |