| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit 63917c1c9db60b87e14ffb3a8a162e4f58dc4276.
|
| |
|
|
|
| |
Co-Authored-By: David Rodríguez <deivid.rodriguez@riseup.net>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without shelling out. It should be faster, and it avoids a ruby 2.3
issue where gems installed through a subprocess are not picked up by the
currently running rubygems.
I'm also removing some unneeded `travis_retry` from the TravisCI
configure. These steps shouldn't timeout and if they do, we should
figure out why. Also, they could be hiding other issues not related to
the network. In this case, `travis_retry bin/rake spec:parallel_deps`
was hiding the issue installing dev dependencies being fixed by this
commit.
|
| |
|
|
|
|
| |
This reverts commit a39e100be885f72a261a4c78032655d13502e44e.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit f018c6dd687b33c71b5ddb42c5e437704e73bd15.
|
| |
|
| |
|
| |
|
| |
|
|
|
| |
Co-Authored-By: David Rodríguez <deivid.rodriguez@riseup.net>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
7665: Fix sudo specs environment r=hsbt a=deivid-rodriguez
### What was the end-user or developer problem that led to this PR?
The developer problem is that sudo specs are not correctly setting the environment (except for ruby 2.3). The specs are accidentally passing but you can tell that they are running against the system ruby by the [warning messages they print](https://travis-ci.org/rubygems/bundler/jobs/658272719#L531-L558).
This causes problems when migrating to github actions. See https://github.com/rubygems/bundler/pull/7660#discussion_r385616844.
Another problem is that the environment is setup manually outside of `rake spec:sudo`, so there's no easy way of running sudo specs manually if your system does not have the right sudoers configuration.
### What is your fix for the problem, implemented in this PR?
My fix is to properly set sudo configuration to preserve the environment so that the correct ruby can be found by sudo specs, and also to move the logic inside `rake spec:sudo` so that the specs can easily be run manually without side effects.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, sudo specs were running against system ruby, not against RVM
ruby. We need to make sure `sudo` is always configured to preserve the
path the `ruby`. This was previously done only for ruby 2.3, but needs
to be done everywhere to ensure that the specs run against the correct
ruby.
Together with this change, I added a bare test to make sure that "sudo
specs" run against the correct ruby.
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
7661: Revise CoC based on Contributor Covenant 2.0 r=deivid-rodriguez a=indirect
Bundler has had a code of conduct since before the Contributor Covenant was available as an option. In my (admittedly somewhat vague) memory, we continued to use our own custom CoC based on wanting clear enforcement examples directly in the CoC. The Contributor Covenant now contains enforcement examples as of 2.0, so I am proposing that we migrate Bundler's CoC to CC 2.0.
Additional benefits:
- Merging with RubyGems gets easier, since RubyGems uses CC already (rubygems/rubygems#3157).
- The `bundle gem` template and Bundler itself will now use the same CoC.
Co-authored-by: André Arko <andre@arko.net>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Bundler has had a code of conduct since before the Contributor Covenant was available as an option. In my (admittedly somewhat vague) memory, we continued to use our own custom CoC based on wanting clear enforcement examples directly in the CoC. The Contributor Covenant now contains enforcement examples as of 2.0, so I am proposing that we migrate Bundler's CoC to CC 2.0.
Additional benefits:
- Merging with RubyGems gets easier, since RubyGems uses CC already (rubygems/rubygems#3157).
- The `bundle gem` template and Bundler itself will now use the same CoC.
|