summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Bump vendored fileutils to 1.3.0next_fileutilsDavid Rodríguez2019-10-043-112/+132
|
* Merge #7374Bundlerbot2019-10-033-7/+7
|\ | | | | | | | | | | | | | | 7374: Fix typos r=hsbt a=biow0lf Fix typos Co-authored-by: Igor Zubkov <igor.zubkov@ag-force.com>
| * Fix typoIgor Zubkov2019-10-031-1/+1
| |
| * Fix typoIgor Zubkov2019-10-033-6/+6
| |
| * Fix typoIgor Zubkov2019-10-033-4/+4
|/
* Merge #7372Bundlerbot2019-10-0250-50/+50
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 7372: October manpages r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that outdated manpages. ### What is your fix for the problem, implemented in this PR? My fix is to update them. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * October manpagesoctober_manpagesDavid Rodríguez2019-10-0150-50/+50
|/
* Merge #7368Bundlerbot2019-09-291-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 7368: Bump version to latest pre-release r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I forgot to merge the version increase back to master after release. ### What is your fix for the problem, implemented in this PR? My fix is to bump it. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Bump version to latest pre-releasebump_version_to_latest_preDavid Rodríguez2019-09-271-1/+1
| | | | | | | | Forgot to merge the version increase back to master after release.
* | Merge #7370Bundlerbot2019-09-292-6/+39
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7370: Fix `bunde outdated` regression with groupless dependencies r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the refactoring in #7365 introduced a regression involving groupless dependencies. ### What was your diagnosis of the problem? My diagnosis was that `nil` groups were not being properly handled when sorting groups by name, and when this kind of outdated deps would be involved, `bundle outdated` would crash with a backtrace like the following: ``` NoMethodError: undefined method `split' for nil:NilClass /home/deivid/Code/bundler/lib/bundler/cli/outdated.rb:105:in `block in run' /home/deivid/Code/bundler/lib/bundler/cli/outdated.rb:104:in `each' /home/deivid/Code/bundler/lib/bundler/cli/outdated.rb:104:in `run' /home/deivid/Code/bundler/lib/bundler/cli.rb:412:in `outdated' /home/deivid/Code/bundler/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run' /home/deivid/Code/bundler/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command' /home/deivid/Code/bundler/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch' /home/deivid/Code/bundler/lib/bundler/cli.rb:26:in `dispatch' /home/deivid/Code/bundler/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start' /home/deivid/Code/bundler/lib/bundler/cli.rb:17:in `start' /home/deivid/Code/bundler/exe/bundle:46:in `block in <main>' /home/deivid/Code/bundler/lib/bundler/friendly_errors.rb:123:in `with_friendly_errors' /home/deivid/Code/bundler/exe/bundle:34:in `<main>' ``` ### What is your fix for the problem, implemented in this PR? My fix is to consider `nil` groups as empty instead, so that sorting them works. ### Why did you choose this fix out of the possible options? I chose this fix because it's reasonable simple. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Fix outdated regression with groupless dependenciesfix_outdated_regressionDavid Rodríguez2019-09-272-5/+38
| | |
| * | Improve one spec descriptionDavid Rodríguez2019-09-271-1/+1
| |/
* | Merge #7362Bundlerbot2019-09-282-14/+32
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7362: Fix spec warnings r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that our specs print some warnings to screen. ### What was your diagnosis of the problem? My diagnosis was that specs should have a clean output. ### What is your fix for the problem, implemented in this PR? My fix is to remove the warnings. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Avoid printing deprecation messages during specsfix_warningsDavid Rodríguez2019-09-261-8/+18
| |
| * Fix warning during ruby_version specsDavid Rodríguez2019-09-261-6/+14
| | | | | | | | | | | | | | | | The following warning: ``` /path/to/spec/bundler/ruby_version_spec.rb:404: warning: instance variable @ruby_version not initialized ```
* | Merge #7361Bundlerbot2019-09-273-11/+24
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7361: Add caller information to some deprecation messages r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that some deprecations mention usage of deprecated methods, but include no information about where the deprecated method is being called. ### What was your diagnosis of the problem? My diagnosis was that we should include this information with this kind of deprecation messages, to make migration easier. ### What is your fix for the problem, implemented in this PR? My fix is to add an optional argument to the `major_deprecation` method, to print the location of the deprecated caller. ### Why did you choose this fix out of the possible options? I chose this fix because it required little code changes. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Add caller information to some deprecation messagesadd_info_to_some_deprecation_messagesDavid Rodríguez2019-09-233-11/+24
| | | | | | | | | | | | | | | Some deprecations would be fixed more easily if they included the location where the deprecated method was called.
* | | Merge #7365Bundlerbot2019-09-262-33/+20
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7365: Refactor `bundle outdated` r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that while working on a better `bundle outdated` format (essentially getting #4474 ready to merge), I noticed a bunch of logic in `bundle outdated` that's overly complicated and not necessary. ### What was your diagnosis of the problem? My diagnosis was that I should simplify the implementation before changing the output. ### What is your fix for the problem, implemented in this PR? My fix is to add my improvements as a separate PR. Afterwards I'll rebase and get #4474 ready. ### Why did you choose this fix out of the possible options? I chose this fix because including this improvements with #4474 made that PR too big and hard to understand. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Remove unnecessary `outdated_gems_by_groups`refactor_outdatedDavid Rodríguez2019-09-251-6/+2
| | |
| * | Indentation fixesDavid Rodríguez2019-09-251-8/+8
| | |
| * | Remove some artificial line breaksDavid Rodríguez2019-09-251-4/+2
| | |
| * | Remove unnecessary `next`David Rodríguez2019-09-251-2/+0
| | | | | | | | | | | | Groups are only added to this hash if they have gems.
| * | Invert yet another `if` to `unless` for readabilityDavid Rodríguez2019-09-251-1/+1
| | |
| * | Merge condition to a single lineDavid Rodríguez2019-09-251-2/+1
| | | | | | | | | | | | I think this kind of artificial line breaks are distracting.
| * | Unify to a single `next` callDavid Rodríguez2019-09-251-2/+2
| | |
| * | Move local variable to where it's usedDavid Rodríguez2019-09-251-1/+2
| | |
| * | Invert another `if` for readabilityDavid Rodríguez2019-09-251-1/+1
| | |
| * | Traverse `outdated_gems_by_groups` in a simpler wayDavid Rodríguez2019-09-251-2/+1
| | |
| * | There should be no `nil` keys hereDavid Rodríguez2019-09-251-1/+1
| | |
| * | Spare a local variableDavid Rodríguez2019-09-251-2/+1
| | |
| * | Little reformatDavid Rodríguez2019-09-251-1/+1
| | | | | | | | | | | | Move each `next` to the variable it uses for its condition.
| * | `unless` is much more readable than `if` hereDavid Rodríguez2019-09-251-1/+1
| | |
| * | Little optimization to `bundle outdated`David Rodríguez2019-09-251-1/+2
| | | | | | | | | | | | No need to check the target group if the group has no outdated gems.
| * | SImplify outdated commandDavid Rodríguez2019-09-251-6/+2
|/ / | | | | | | | | I don't know why a nil group was being artificially added and then always skipped.
* | Merge #7364Bundlerbot2019-09-251-1/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7364: Follow up to `ENV["RGV"]` handling refactor r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that #7296 broke rubygems CI. ### What was your diagnosis of the problem? My diagnosis was that the handling of `ENV["RGV"]` when it contains the path of a rubygems checkout instead of a rubygems version (like it happens in the rubygems repo) was incorrect. ### What is your fix for the problem, implemented in this PR? My fix is to correct the behaviour. I was able to reproduce the CI failures in https://github.com/rubygems/rubygems/pull/2924, and verify they are be fixed by this PR by patching the vendored bundler locally. Fixes #7363. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Properly expand rubygems path when not in the root folderfollow_up_to_rgv_handling_refactorDavid Rodríguez2019-09-241-1/+3
| | |
| * | Properly version target rubygems when RGV is a pathDavid Rodríguez2019-09-241-0/+2
| |/
* | Merge #7360Bundlerbot2019-09-244-4/+2
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7360: Consistenly use the default RSpec formatter r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that our default RSpec formatter is `--documentation`, but we're overriding it almost everywhere to use `--progress`. ### What was your diagnosis of the problem? My diagnosis was that we should probably use the default formatter, since I think we all prefer it. ### What is your fix for the problem, implemented in this PR? My fix is to do that. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Consistenly use the default RSpec formatternormalize_rspec_formatterDavid Rodríguez2019-09-234-4/+2
|/
* Merge #7296Bundlerbot2019-09-2221-131/+175
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7296: Improve exec'ing to the proper rubygems version r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the `with_rubygems` script is hard to work with, because it does complicated ARGV manipulation before exec'ing. ### What was your diagnosis of the problem? My diagnosis was that we don't need it. ### What is your fix for the problem, implemented in this PR? My fix is to implement the same thing in a simpler way. ### Why did you choose this fix out of the possible options? I chose this fix because it simplifies things. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Remove no longer needed rubygems updateremove_with_rubygemsDavid Rodríguez2019-09-191-3/+0
| | | | | | | | We never use system rubygems anymore. Always the local clone.
| * Always go through our `rake` binstub in TravisCIDavid Rodríguez2019-09-191-5/+6
| |
| * Only change cloned copy version if necessaryDavid Rodríguez2019-09-191-2/+15
| | | | | | | | This should make binstubs more responsive when using `ENV["RGV"]`.
| * Replace `with_rubygems` scriptDavid Rodríguez2019-09-1914-121/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead, use a better rubygems version manager that makes sure that `ENV["RGV"]` usage is always applied, and its usage is centralized at a single place. This simplifies the rake task organization and makes it much simpler to run locally exactly what's run in CI. For example, since it doesn't rely on the `RGV` being deleted for subsequent subprocesses, it also running `bin/rake spec:travis` task locally which previously would lead to ``` rake aborted! RubyGems version is required on Travis! ``` It also reduces duplication making it so that we only need to change the `.travis.yml` file when updating tested rubies, and not the `Rakefile` as well.
| * Move some global requires to their few usagesDavid Rodríguez2019-09-187-3/+11
| |
| * Reuse existing helperDavid Rodríguez2019-09-171-6/+8
| | | | | | | | | | So that we don't include a `run` method at the top level, which can conflict with other `run` methods our specs use.
| * Consistenly pass strings to `run` helperDavid Rodríguez2019-09-171-5/+5
| |
| * Move require to the only file that needs itDavid Rodríguez2019-09-172-1/+2
| |
| * Explicitly require test helpersDavid Rodríguez2019-09-171-4/+15
| | | | | | | | We don't need to keep adding exceptions.
| * Remove duplicated conditionDavid Rodríguez2019-09-171-1/+1
|/ | | | We're checking the same thing in the previous line
View Lorry Controller Status