| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| |
| | |
[Thor] Update to v0.19.4
Closes #4876
@rafaelfranca
|
| | | |
|
| | | |
|
| |\ \
| |/
|/|
| | |
Version 1.14.4
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
[Fix #5358] Handle files conflicts when using `bundle gem`
`bundle gem` command fails with an exception when creating a gem having
the same name of a file in the specified path.
For instance:
> touch hello
> bundle gem hello
This bug is due to Thor gem. At the moment, Thor does not handle
conflicts between files and directories. This commit mitigates the
problem by rescuing the exception from Thor and gracefully exit with an
error message.
Fixes https://github.com/bundler/bundler/issues/5358
(cherry picked from commit f93accce1e9d948eaef79e2f380fd7d396687808)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Properly set native extension build args for git gems
Closes https://github.com/bundler/bundler/pull/5399
Closes https://github.com/bundler/bundler/issues/5401
(cherry picked from commit 74341aaaa949e914cd1cffb163cd99bdf14b91df)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Permissive temporary home directory
We're deploying to a server with several Ruby applications each with it's own user. However, the home directory of these users is *not* writable by the users.
Since Bundler 1.14.x, a temporary home directoy in the `tmpdir` is used as a fallback. This works well for only one user, but will fail with more than one:
1. user1 execs `bundle`
2. `/tmp/bundler/home/user1` is created usually with 0755 modes
3. user2 execs `bundle`
4. `/tmp/bundler/home/user2` cannot be created since user2 can't write to `home`
This PR adds a `chmod` to apply mode 0777 to `home`. It rescues to nil in order to silently fail on step 4 (user2 cannot chmod `home` since it's owned by user1) as well as in case of any other problem performing chmod. Since we're in a fallback here, I guess it's okay to do this. However, if this is too much code smell, a `unless File.exist?` will do the trick as well.
(cherry picked from commit 311b090449b591d4fb96a725e548b4d35ac95ed0)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Update vendored Molinillo to 0.5.6
See https://github.com/CocoaPods/Molinillo/releases/0.5.6
closes #5359
closes #5362
(cherry picked from commit 3360aac96610f640ddfef0d65303d15bc99539d9)
|
| | |
| |
| |
| |
| |
| |
| |
| | |
[UI::Silent] Ensure all the same methods as Shell are implemented
Finish up the work of #5368
(cherry picked from commit cad91be3c8f4ab5a71eee284c051cb2e7c2cb3a2)
|
| | |
| |
| |
| |
| |
| |
| |
| | |
[RubyVersion] Ensure passed-in versions are valid during init
Closes #5380
(cherry picked from commit 427f07f77f414f43d693c87c104546af3d9fe984)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
r=segiddins
Fix silent.rb method interface
Hi,
This is my first contribution to bundler, so I started by covering bundler/friendly_errors.rb with unit tests.
After covering it, I spotted a bug in lib/bundler/ui/silent.rb, trace method interface, so I fix it in this PR.
Waiting for feedback!
(cherry picked from commit c0de8f625f0ae2ed5cc2b26673c875e2900a9829)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fix misleading warning message when a dependency is unused on any platform
The current warning message for a dep with empty platform is misleading/confusing. You see a sort of the below warning when you `bundle install`,
```
The dependency tzinfo-data (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x86-mswin32, x64-mingw32, java. To add those platforms to the bundle, run `bundle lock --add-platform mingw, mswin, x64_mingw, jruby`.
```
However, there two issues exist in this message "run `bundle lock --add-platform mingw, mswin, x64_mingw, jruby`":
- You must not have comma (,) for separators
- these commas will be considered as comma itself. see [here](https://github.com/bundler/bundler/blob/242fcbcb2d15d39c63e3441756b77fbfcc1b73b2/lib/bundler/cli/lock.rb#L34-L41)
- mingw, mswin, x64_mingw, jruby are not valid platforms
- platforms must be specified as the formats that rubygems can understand, like (x86-mingw32, x86-mswin32, x64-mingw32, java)
This fixes these issues.
(cherry picked from commit cd872ef1e8281252786535df960275cd391933bc)
|
| | |
| |
| |
| |
| |
| |
| |
| | |
marketing-ify the post-install message
/cc @segiddins @mrb
(cherry picked from commit 5db7e161e9057603188600549c226a1b40807e6e)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Show inject usage when args are passed incorrectly
Closes #5384
Now it shows the error :
```
$ bundle inject "gem_name" 1 "v"
ERROR: "bundle inject" was called with arguments ["gem_name", "1", "v"]
Usage: "bundle inject GEM VERSION"
$ bundle inject "gem_name" "v" 1
ERROR: "bundle inject" was called with arguments ["gem_name", "v", "1"]
Usage: "bundle inject GEM VERSION"
```
(cherry picked from commit ec5cab34d3b12467433ca1a1eafc460e42834084)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bundle show --outdated shouldn't be updating versions
This PR is for #5375. I have added a spec (currently failing) of the desired behavior for `bundle show --outdated`
I'm currently looking into a fix for this but welcome anyone else to come in as well.
(cherry picked from commit d9d699c174a06da8052bc7da0d5ba64438968653)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
[FriendlyErrors] Update ISSUES.md URL
This URL no longer exists after the docs reorganization
\c @feministy
I'd like to release this as 1.14.x so people aren't frustrated when opening new issues
(cherry picked from commit fb8c5a7e509cb0a54a4b34f8a93b86484241a747)
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
r=indirect
[Definition] Fail when installing in frozen mode & gemspec deps have changed
Closes #5264
- [x] Specs
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
[Release] Coerce PR numbers to strings for the regexp matching
Today in 'testing release code is hard'...
|
| | |/ / |
|
| |\ \ \
| |/ /
|/| |
| | | |
Allow the gem helper spec to pass much faster without a net connection
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
s/@disable_extentions/@disable_extensions/
Typo.
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[Fix #5358] Handle files conflicts when using `bundle gem`
`bundle gem` command fails with an exception when creating a gem having
the same name of a file in the specified path.
For instance:
> touch hello
> bundle gem hello
This bug is due to Thor gem. At the moment, Thor does not handle
conflicts between files and directories. This commit mitigates the
problem by rescuing the exception from Thor and gracefully exit with an
error message.
Fixes https://github.com/bundler/bundler/issues/5358
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`bundle gem` command fails with an exception when creating a gem having
the same name of a file in the specified path.
For instance:
> touch hello
> bundle gem hello
This bug is due to Thor gem. At the moment, Thor does not handle
conflicts between files and directories. This commit mitigates the
problem by rescuing the exception from Thor and gracefully exit with an
error message.
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[Release] Fix pulling PRs from milestone
Implement pagination
Account for the fact that only issues can be filtered by milestone, not PRs
|
| |/ / /
| | |
| | |
| | |
| | |
| | | |
Implement pagination
Account for the fact that only issues can be filtered by milestone, not PRs
|
| |\ \ \
| | | |
| | | |
| | | | |
[Release] Pull PRs to backport from GH milestone
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Properly set native extension build args for git gems
Closes https://github.com/bundler/bundler/pull/5399
Closes https://github.com/bundler/bundler/issues/5401
|
| | | |/ /
| |/| | |
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Permissive temporary home directory
We're deploying to a server with several Ruby applications each with it's own user. However, the home directory of these users is *not* writable by the users.
Since Bundler 1.14.x, a temporary home directoy in the `tmpdir` is used as a fallback. This works well for only one user, but will fail with more than one:
1. user1 execs `bundle`
2. `/tmp/bundler/home/user1` is created usually with 0755 modes
3. user2 execs `bundle`
4. `/tmp/bundler/home/user2` cannot be created since user2 can't write to `home`
This PR adds a `chmod` to apply mode 0777 to `home`. It rescues to nil in order to silently fail on step 4 (user2 cannot chmod `home` since it's owned by user1) as well as in case of any other problem performing chmod. Since we're in a fallback here, I guess it's okay to do this. However, if this is too much code smell, a `unless File.exist?` will do the trick as well.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
When falling back to a temporary home directory, make sure the "home" directory has mode 0777 to prevent "permission denied" when this mechanism is used by more than one login.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix links in READMEs causing 404 errors in Github
In doc/contributing/README.md, doc/documentation/README.md, and
doc/development/README.md, there were links that referenced files in the
same doc directory but prepended the directory name. This lead to urls
that were broken due to having the directory name stated twice.
I didn't want to clog the issues section with this since it isn't actually an issue with bundler. But I can create an issue of that would be better. Just noticed as I was trying to figure out how to get started. This will be my first OS contribution, so even though it is minor, please let me know if I did anything wrong. Thanks.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In doc/contributing/README.md, doc/documentation/README.md, and
doc/development/README.md, there were links that referenced files in the
same doc directory but prepended the directory name. This lead to urls
that were broken due to having the directory name stated twice.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Update vendored Molinillo to 0.5.6
See https://github.com/CocoaPods/Molinillo/releases/0.5.6
closes #5359
closes #5362
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[UI::Silent] Ensure all the same methods as Shell are implemented
Finish up the work of #5368
|
| | | |_|/ /
| |/| | | |
|
