summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Allow the gem helper spec to pass much faster without a net connectionseg-unit-test-no-internetSamuel Giddins2017-02-091-2/+3
|
* Auto merge of #5414 - bundler:seg-patch-release-milestone, r=segiddinsThe Bundler Bot2017-02-091-2/+22
|\ | | | | | | [Release] Pull PRs to backport from GH milestone
| * [Release] Pull PRs to backport from GH milestoneseg-patch-release-milestoneSamuel Giddins2017-02-081-2/+22
| |
* | Auto merge of #5410 - bundler:seg-git-build-args, r=indirectThe Bundler Bot2017-02-093-6/+56
|\ \ | | | | | | | | | | | | | | | | | | Properly set native extension build args for git gems Closes https://github.com/bundler/bundler/pull/5399 Closes https://github.com/bundler/bundler/issues/5401
| * | Properly set native extension build args for git gemsseg-git-build-argsSamuel Giddins2017-02-073-6/+56
| | |
* | | Auto merge of #5363 - svoop:permissive_tmp_home_dirs, r=indirectThe Bundler Bot2017-02-093-21/+71
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Permissive temporary home directory We're deploying to a server with several Ruby applications each with it's own user. However, the home directory of these users is *not* writable by the users. Since Bundler 1.14.x, a temporary home directoy in the `tmpdir` is used as a fallback. This works well for only one user, but will fail with more than one: 1. user1 execs `bundle` 2. `/tmp/bundler/home/user1` is created usually with 0755 modes 3. user2 execs `bundle` 4. `/tmp/bundler/home/user2` cannot be created since user2 can't write to `home` This PR adds a `chmod` to apply mode 0777 to `home`. It rescues to nil in order to silently fail on step 4 (user2 cannot chmod `home` since it's owned by user1) as well as in case of any other problem performing chmod. Since we're in a fallback here, I guess it's okay to do this. However, if this is too much code smell, a `unless File.exist?` will do the trick as well.
| * | Hack to work around rspec-mocks 3.5 broken on Ruby 1.8Sven Schwyn2017-02-081-0/+8
| | |
| * | Permissive temporary home directorySven Schwyn2017-02-082-21/+63
| | | | | | | | | | | | When falling back to a temporary home directory, make sure the "home" directory has mode 0777 to prevent "permission denied" when this mechanism is used by more than one login.
* | | Auto merge of #5406 - roseaboveit:fix_doc_sub_dir_readme_links, r=feministyThe Bundler Bot2017-02-083-12/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix links in READMEs causing 404 errors in Github In doc/contributing/README.md, doc/documentation/README.md, and doc/development/README.md, there were links that referenced files in the same doc directory but prepended the directory name. This lead to urls that were broken due to having the directory name stated twice. I didn't want to clog the issues section with this since it isn't actually an issue with bundler. But I can create an issue of that would be better. Just noticed as I was trying to figure out how to get started. This will be my first OS contribution, so even though it is minor, please let me know if I did anything wrong. Thanks.
| * | | Fix links in READMEs causing 404 errors in GithubWhitney-Rose Levis2017-02-053-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In doc/contributing/README.md, doc/documentation/README.md, and doc/development/README.md, there were links that referenced files in the same doc directory but prepended the directory name. This lead to urls that were broken due to having the directory name stated twice.
* | | | Auto merge of #5413 - bundler:seg-molinillo-0.5.6, r=segiddinsThe Bundler Bot2017-02-085-10/+37
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update vendored Molinillo to 0.5.6 See https://github.com/CocoaPods/Molinillo/releases/0.5.6 closes #5359 closes #5362
| * | | | Update vendored Molinillo to 0.5.6seg-molinillo-0.5.6Samuel Giddins2017-02-085-10/+37
|/ / / /
* | | | Auto merge of #5408 - bundler:seg-ensure-silent-shell-parity, r=segiddinsThe Bundler Bot2017-02-082-0/+38
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | [UI::Silent] Ensure all the same methods as Shell are implemented Finish up the work of #5368
| * | | | [UI::Silent] Ensure all the same methods as Shell are implementedseg-ensure-silent-shell-paritySamuel Giddins2017-02-072-0/+38
| | |_|/ | |/| |
* | | | Auto merge of #5391 - bundler:seg-ruby-version-requirement-valid, r=indirectThe Bundler Bot2017-02-082-1/+25
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | [RubyVersion] Ensure passed-in versions are valid during init Closes #5380
| * | | Use RUBY_VERSION for ruby dsl specseg-ruby-version-requirement-validSamuel Giddins2017-02-011-1/+1
| | | | | | | | | | | | | | | | Gem.ruby_version includes the patch level, which we dont want
| * | | [RubyVersion] Keep versions as stringsSamuel Giddins2017-02-011-1/+5
| | | |
| * | | [RubyVersion] Ensure passed-in versions are valid during initSamuel Giddins2017-02-012-1/+21
| | | |
* | | | Auto merge of #5368 - savionok:sav-cover-Bundler-FriendlyErrors-with-tests, ↵The Bundler Bot2017-02-072-3/+183
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=segiddins Fix silent.rb method interface Hi, This is my first contribution to bundler, so I started by covering bundler/friendly_errors.rb with unit tests. After covering it, I spotted a bug in lib/bundler/ui/silent.rb, trace method interface, so I fix it in this PR. Waiting for feedback!
| * | | | fix syntax error on 1.8.7Sava Virtosu2017-01-281-5/+11
| | | | |
| * | | | fix interface of a methodSava Virtosu2017-01-241-1/+1
| | | | |
| * | | | cover log_error methodSava Virtosu2017-01-241-2/+133
| | | | |
| * | | | rename form exception to errorSava Virtosu2017-01-231-10/+12
| | | | |
| * | | | cover method request_issue_report_for in FriendlyErrorsSava Virtosu2017-01-231-0/+17
| | | | |
| * | | | cover method exit_status on Bundler::FriendlyErrorsSava Virtosu2017-01-231-0/+24
| | | | |
* | | | | Auto merge of #5393 - 5t111111:fix-warning-when-a-dependency-unused, r=segiddinsThe Bundler Bot2017-02-072-4/+6
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix misleading warning message when a dependency is unused on any platform The current warning message for a dep with empty platform is misleading/confusing. You see a sort of the below warning when you `bundle install`, ``` The dependency tzinfo-data (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x86-mswin32, x64-mingw32, java. To add those platforms to the bundle, run `bundle lock --add-platform mingw, mswin, x64_mingw, jruby`. ``` However, there two issues exist in this message "run `bundle lock --add-platform mingw, mswin, x64_mingw, jruby`": - You must not have comma (,) for separators - these commas will be considered as comma itself. see [here](https://github.com/bundler/bundler/blob/242fcbcb2d15d39c63e3441756b77fbfcc1b73b2/lib/bundler/cli/lock.rb#L34-L41) - mingw, mswin, x64_mingw, jruby are not valid platforms - platforms must be specified as the formats that rubygems can understand, like (x86-mingw32, x86-mswin32, x64-mingw32, java) This fixes these issues.
| * | | | Extract the platforms array from map for warning into a variableHirofumi Wakasugi2017-02-021-2/+3
| | | | |
| * | | | Fix warning message when a dependency is unused on any platformHirofumi Wakasugi2017-02-022-3/+4
| | | | |
* | | | | Auto merge of #5405 - koic:ci_against_ruby_2_1_10, r=segiddinsThe Bundler Bot2017-02-051-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CI against Ruby 2.1.10 Ruby 2.1.10 was released. https://www.ruby-lang.org/en/news/2016/04/01/ruby-2-1-10-released
| * | | | | CI against Ruby 2.1.10Koichi ITO2017-02-061-2/+2
|/ / / / /
* | | | | Auto merge of #5392 - bundler:improve-messaging, r=segiddinsThe Bundler Bot2017-02-031-4/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | marketing-ify the post-install message /cc @segiddins @mrb
| * | | | | add improvingimprove-messagingAndre Arko2017-02-011-4/+4
| | | | | |
| * | | | | marketing-ify the post-install messageAndre Arko2017-02-011-4/+4
| |/ / / /
* | | | | Auto merge of #5389 - Shekharrajak:5384_inject_usage, r=segiddinsThe Bundler Bot2017-02-033-5/+17
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Show inject usage when args are passed incorrectly Closes #5384 Now it shows the error : ``` $ bundle inject "gem_name" 1 "v" ERROR: "bundle inject" was called with arguments ["gem_name", "1", "v"] Usage: "bundle inject GEM VERSION" $ bundle inject "gem_name" "v" 1 ERROR: "bundle inject" was called with arguments ["gem_name", "v", "1"] Usage: "bundle inject GEM VERSION" ```
| * | | | test case addedshekharrajak2017-02-021-0/+10
| | | | |
| * | | | minor changeshekharrajak2017-02-012-2/+3
| | | | |
| * | | | do not take more than one gem and version as argshekharrajak2017-02-012-5/+6
| | |/ / | |/| |
* | | | Auto merge of #5376 - colby-swandale:bundle-show-update-lock, r=segiddinsThe Bundler Bot2017-02-012-0/+28
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bundle show --outdated shouldn't be updating versions This PR is for #5375. I have added a spec (currently failing) of the desired behavior for `bundle show --outdated` I'm currently looking into a fix for this but welcome anyone else to come in as well.
| * | | | fix rubocop feedbackColby Swandale2017-01-311-1/+1
| | | | |
| * | | | fix for bundle show updating gems and spec feedbackColby Swandale2017-01-312-4/+7
| | | | |
| * | | | remove redundant bundle installColby Swandale2017-01-271-2/+0
| | | | |
| * | | | add failing spec for bundle update —outdatedColby Swandale2017-01-271-0/+27
| |/ / /
* | | | Auto merge of #5382 - bundler:seg-error-template-issues-url, r=segiddinsThe Bundler Bot2017-02-011-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [FriendlyErrors] Update ISSUES.md URL This URL no longer exists after the docs reorganization \c @feministy I'd like to release this as 1.14.x so people aren't frustrated when opening new issues
| * | | [FriendlyErrors] Update ISSUES.md URLseg-error-template-issues-urlSamuel Giddins2017-01-291-1/+1
|/ / / | | | | | | This URL no longer exists after the docs reorganization
* | | Merge tag 'v1.14.3'Samuel Giddins2017-01-242-1/+8
|\ \ \ | | | | | | | | | | | | Version 1.14.3
| * | | Version 1.14.3 with changelogv1.14.3Samuel Giddins2017-01-242-1/+8
| | | |
| * | | Auto merge of #5361 - bundler:seg-1-8-7-spec-install, r=segiddinsThe Bundler Bot2017-01-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | Ensure rack is always installed first on 1.8.7 in the specs (cherry picked from commit d3c50f80d34d1ee7fa84d3d8a6a930c55186fbab)
| * | | Auto merge of #5355 - bundler:seg-resolver-restrict-platforms, r=indirectThe Bundler Bot2017-01-243-5/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Resolver] Restrict activated platforms to those in the Gemfile This ensures that deps that come from the lockfile, which might only have the "ruby" platform, dont cause us to attempt to activate/resolve all "ruby" platform gems Closes #5349 (cherry picked from commit 6e69db334661fd31f559fb72463e7911b6f9c6a1)
| * | | Auto merge of #5354 - bundler:seg-gemspec-dev-deps-no-resolve, r=indirectThe Bundler Bot2017-01-242-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Definition] Avoid re-resolving when a gemspec has dev deps Inspired by #5349. Since dev deps are added with `type: :development`, they are `!=` to the deps retrieved from the lockfile, which have no type. This compares the deps ignoring type completely (cherry picked from commit df20d19972f251ec4dec5cb7cba7e178f98df9e9)
* | | | Auto merge of #5361 - bundler:seg-1-8-7-spec-install, r=segiddinsThe Bundler Bot2017-01-241-1/+2
|\ \ \ \ | |_|_|/ |/| | | | | | | Ensure rack is always installed first on 1.8.7 in the specs
View Lorry Controller Status