| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| |
| |
| | |
Use correct hook name in comment
I checked `Bundler::Source::Path::Installer#post_install` - it's definitely `pre_install` and not `post_install` twice though I wasn't sure given the method name 😄
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Specs for multiple platform bug fix in outdated.
This supersedes PR #4734, which fixed a bug but didn't have proper spec
coverage. Since that PR was submitted, a different commit (291a807c in
PR #5176) fixed a similar bug at the same time. That caused a merge
conflict in #4734. It was unknown if the same fix fixed both bugs,
since there were no successfully implemented specs. These specs show
that the bug was properly fixed.
These specs were mostly already implemented by @b-ggs, just needed a
little additional guidance.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This supersedes PR #4734, which fixed a bug but didn't have proper spec
coverage. Since that PR was submitted, a different commit (291a807c in
PR #5176) fixed a similar bug at the same time. That caused a merge
conflict in #4734. It was unknown if the same fix fixed both bugs,
since there were no successfully implemented specs. These specs show
that the bug was properly fixed.
These specs were mostly already implemented by @b-ggs, just needed a
little additional guidance.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Improve -rbundler performance
Along with https://github.com/rubygems/rubygems/pull/1801, speeds up `-rbundler` by ~5x
Profiled via
```ruby
# frozen_string_literal: true
REQUIRE_TIMES = {} # rubocop:disable Style/MutableConstant
module Kernel
require "benchmark"
alias_method :require_before_req, :require
def require(path)
ret = nil
Benchmark.realtime do
ret = require_before_req(path)
end.tap do |t|
if ret
from = begin
caller[2]
rescue
nil
end
::REQUIRE_TIMES["#{path} : #{from}"] ||= t
end
end
ret
end
end
at_exit { puts REQUIRE_TIMES.to_a.sort_by(&:last).reverse.map {|k, v| "#{k} =>\n\t#{v}" } }
```
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | |
| | | | |
Random spec improvements
Called "sam has a flight and forgot to run `rake spec:deps`"
|
| | | |
| | | |
| | | |
| | | | |
This is so persistent will use our override class
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This avoids loading rack, which conflicts with some specs
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This will avoid printing out every single cached spec
|
| | | | |
|
| |/ / |
|
|\ \ \
| |/ /
|/| |
| | | |
Fix the specs on Ruby 2.4
|
| | | |
|
| |/ |
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add a new line for before priring BundlerError errors
This PR is fixing a problem where the warnings and errors on a `bundle install` using an invalid source are not being put on a newline correctly.
```
› bundle install
Fetching source index from https://www.google.com/
Retrying fetcher due to error (2/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/
Retrying fetcher due to error (3/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/
Retrying fetcher due to error (4/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/Could not fetch specs from https://www.google.com/
```
This is happening because the new lines for the warnings are being printed before the error itself. This behaviour is happening due to another UI problem, see https://github.com/bundler/bundler/commit/2ac26bc88ba30b28aba6e11c9b2d04cdb0276a25.
Maybe a better way of fixing this problem is to add a new line to the exception message itself rather then what i have submitted. Its a bit of a weird one.
Let me know.
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | | |
`bundle update` post install messages
Currently post install messages are only displayed for `bundle install` not for `bundle update`. This PR fixes that so they're displayed for both, and includes a small refactor of some duplicated functionality between `install` and `update`
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Fix typo in man page.
|
| |/ / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
[CLI::Gem] When using rspec, configure persistence file
aka make my life easier when working with new gems.
|
| | |/
| |/| |
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | | |
[Lock] Fix --add-platform ruby
Necessary since the ruby platform is a string instead of a platform object
Closes #5230
|
| |/
| |
| |
| | |
Necessary since the ruby platform is a string instead of a platform object
|
|\ \
| | |
| | |
| | |
| | |
| | | |
[CompactIndex] Disable when openssl is in fips mode
Should close #4989
|
| | | |
|
| |/ |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
r=indirect
[SharedHelpers] Handle generic SystemCallErrors in #filesystem_access
Closes #5134
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
[Env] Print as GFM
I don't know if this is a good idea, but it might help increase the proportion of new issues we get that are properly formatted?
|
| | | | |
|
| | | | |
|
| |/ / |
|
|\ \ \
| |_|/
|/| | |
Fix typo in man page.
|