summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* [Worker] Fail gracefully when creating threads failsseg-worker-thread-creation-failureSamuel Giddins2016-12-253-5/+50
|
* Auto merge of #5270 - pixeltrix:fix-hook-name, r=segiddinsThe Bundler Bot2016-12-241-1/+1
|\ | | | | | | | | | | Use correct hook name in comment I checked `Bundler::Source::Path::Installer#post_install` - it's definitely `pre_install` and not `post_install` twice though I wasn't sure given the method name 😄
| * Use correct hook name in commentAndrew White2016-12-221-1/+1
| |
* | Auto merge of #5273 - chrismo:new-pr-4734, r=segiddinsThe Bundler Bot2016-12-231-0/+27
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Specs for multiple platform bug fix in outdated. This supersedes PR #4734, which fixed a bug but didn't have proper spec coverage. Since that PR was submitted, a different commit (291a807c in PR #5176) fixed a similar bug at the same time. That caused a merge conflict in #4734. It was unknown if the same fix fixed both bugs, since there were no successfully implemented specs. These specs show that the bug was properly fixed. These specs were mostly already implemented by @b-ggs, just needed a little additional guidance.
| * | Specs for multiple platform bug fix in outdated.chrismo2016-12-231-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This supersedes PR #4734, which fixed a bug but didn't have proper spec coverage. Since that PR was submitted, a different commit (291a807c in PR #5176) fixed a similar bug at the same time. That caused a merge conflict in #4734. It was unknown if the same fix fixed both bugs, since there were no successfully implemented specs. These specs show that the bug was properly fixed. These specs were mostly already implemented by @b-ggs, just needed a little additional guidance.
* | | Auto merge of #5260 - bundler:seg-require-speed, r=indirectThe Bundler Bot2016-12-224-14/+16
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve -rbundler performance Along with https://github.com/rubygems/rubygems/pull/1801, speeds up `-rbundler` by ~5x Profiled via ```ruby # frozen_string_literal: true REQUIRE_TIMES = {} # rubocop:disable Style/MutableConstant module Kernel require "benchmark" alias_method :require_before_req, :require def require(path) ret = nil Benchmark.realtime do ret = require_before_req(path) end.tap do |t| if ret from = begin caller[2] rescue nil end ::REQUIRE_TIMES["#{path} : #{from}"] ||= t end end ret end end at_exit { puts REQUIRE_TIMES.to_a.sort_by(&:last).reverse.map {|k, v| "#{k} =>\n\t#{v}" } } ```
| * | | [ParallelInstaller] Pre-require gem_remote_fetcher on 1.8.7seg-require-speedSamuel Giddins2016-12-211-0/+4
| | | |
| * | | [SharedHelpers] Speed up #clean_load_pathSamuel Giddins2016-12-211-10/+8
| | | |
| * | | [SharedHelpers] Document why we’re overriding #requirementSamuel Giddins2016-12-211-0/+1
| | | |
| * | | [SharedHelpers] Remove unused attributeSamuel Giddins2016-12-211-2/+0
| | | |
| * | | Improve -rbundler performance by using autoloadsSamuel Giddins2016-12-212-2/+3
| | | |
* | | | Auto merge of #5209 - bundler:seg-spec-improvements, r=indirectThe Bundler Bot2016-12-224-26/+41
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | Random spec improvements Called "sam has a flight and forgot to run `rake spec:deps`"
| * | | Define the artifice module in fail.rbseg-spec-improvementsSamuel Giddins2016-12-221-0/+2
| | | | | | | | | | | | | | | | This is so persistent will use our override class
| * | | Also load net/https before stubbing Net::HTTPSamuel Giddins2016-12-211-1/+11
| | | |
| * | | Avoid using the Fail endpoint when we want to request against localhostSamuel Giddins2016-12-211-2/+2
| | | |
| * | | Don’t use Artifice for the fail endpointSamuel Giddins2016-12-211-10/+17
| | | | | | | | | | | | | | | | This avoids loading rack, which conflicts with some specs
| * | | Verify no un-mocked requests are being made in the specsSamuel Giddins2016-12-211-1/+3
| | | |
| * | | [Source] Add an inspect methodSamuel Giddins2016-12-211-0/+4
| | | | | | | | | | | | | | | | This will avoid printing out every single cached spec
| * | | Use the bundle helper when calling bundle_rubySamuel Giddins2016-12-211-12/+2
| | | |
| * | | Use a regexp instead of a convoluted start_with? method callSamuel Giddins2016-12-211-1/+1
| |/ /
* | | Auto merge of #5261 - bundler:seg-specs-2.4-fix, r=segiddinsThe Bundler Bot2016-12-212-4/+6
|\ \ \ | |/ / |/| | | | | Fix the specs on Ruby 2.4
| * | Fix the specs on Ruby 2.4seg-specs-2.4-fixSamuel Giddins2016-12-201-0/+2
| | |
| * | Remove rubygems.org from gemfiles in the specsSamuel Giddins2016-12-182-4/+4
| |/
* | Auto merge of #5247 - colby-swandale:missing-new-line-on-fetch, r=segiddinsThe Bundler Bot2016-12-193-3/+22
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a new line for before priring BundlerError errors This PR is fixing a problem where the warnings and errors on a `bundle install` using an invalid source are not being put on a newline correctly. ``` › bundle install Fetching source index from https://www.google.com/ Retrying fetcher due to error (2/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/ Retrying fetcher due to error (3/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/ Retrying fetcher due to error (4/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/Could not fetch specs from https://www.google.com/ ``` This is happening because the new lines for the warnings are being printed before the error itself. This behaviour is happening due to another UI problem, see https://github.com/bundler/bundler/commit/2ac26bc88ba30b28aba6e11c9b2d04cdb0276a25. Maybe a better way of fixing this problem is to add a new line to the exception message itself rather then what i have submitted. Its a bit of a weird one. Let me know.
| * [Retry] Add newline before printing the final errorSamuel Giddins2016-12-183-4/+6
| |
| * remove old heredoc terminatorColby Swandale2016-12-171-1/+0
| |
| * add missing slashColby Swandale2016-12-171-1/+1
| |
| * add failing spec for error not being printed on a new lineColby Swandale2016-12-171-0/+18
| |
* | Auto merge of #5240 - smathy:update_post_install_messages, r=segiddinsThe Bundler Bot2016-12-174-27/+101
|\ \ | | | | | | | | | | | | | | | `bundle update` post install messages Currently post install messages are only displayed for `bundle install` not for `bundle update`. This PR fixes that so they're displayed for both, and includes a small refactor of some duplicated functionality between `install` and `update`
| * | Use `bundle!` in specsJason King2016-12-091-4/+4
| | |
| * | Specs for update post-install messagesJason King2016-12-081-0/+77
| | |
| * | Output post_install_message during updateJason King2016-12-081-1/+2
| | |
| * | DRY up some duplication between install and updateJason King2016-12-083-26/+22
| | |
* | | Auto merge of #5237 - smlx:patch-2, r=segiddinsThe Bundler Bot2016-12-171-1/+1
|\ \ \ | | | | | | | | | | | | Fix typo in man page.
| * | | Fix typo in man page.smlx2016-12-071-1/+1
| |/ /
* | | Auto merge of #5216 - bundler:seg-bundle-gem-rspec-persistence, r=indirectThe Bundler Bot2016-12-172-1/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | [CLI::Gem] When using rspec, configure persistence file aka make my life easier when working with new gems.
| * | | [CLI::Gem] When using rspec, configure persistence fileseg-bundle-gem-rspec-persistenceSamuel Giddins2016-12-172-1/+15
| | |/ | |/|
* | | Auto merge of #5231 - bundler:seg-lock-add-platform-ruby, r=indirectThe Bundler Bot2016-12-172-1/+7
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | [Lock] Fix --add-platform ruby Necessary since the ruby platform is a string instead of a platform object Closes #5230
| * | [Lock] Fix --add-platform rubyseg-lock-add-platform-rubySamuel Giddins2016-12-052-1/+7
| |/ | | | | | | Necessary since the ruby platform is a string instead of a platform object
* | Auto merge of #5222 - bundler:seg-fips, r=indirectThe Bundler Bot2016-12-152-2/+30
|\ \ | | | | | | | | | | | | | | | [CompactIndex] Disable when openssl is in fips mode Should close #4989
| * | [CompactIndex] Only check for fips constant when it is definedseg-fipsSamuel Giddins2016-12-012-2/+2
| | |
| * | [CompactIndex] Disable when openssl is in fips modeSamuel Giddins2016-12-012-2/+30
| |/
* | Auto merge of #5219 - bundler:seg-filesystem-access-generic-system-error, ↵The Bundler Bot2016-12-143-0/+47
|\ \ | | | | | | | | | | | | | | | | | | | | | r=indirect [SharedHelpers] Handle generic SystemCallErrors in #filesystem_access Closes #5134
| * | [SharedHelpers] Ignore EEXIST and ENOENT in #filesystem_accessseg-filesystem-access-generic-system-errorSamuel Giddins2016-11-301-0/+2
| | |
| * | [SharedHelpers] Handle generic SystemCallErrors in #filesystem_accessSamuel Giddins2016-11-303-0/+45
| | |
* | | Auto merge of #5218 - bundler:seg-bundle-env-markdown, r=indirectThe Bundler Bot2016-12-143-30/+51
|\ \ \ | | | | | | | | | | | | | | | | | | | | [Env] Print as GFM I don't know if this is a good idea, but it might help increase the proportion of new issues we get that are properly formatted?
| * | | [FriendlyErrors] Prettify, taking into account formatting suggestionsseg-bundle-env-markdownSamuel Giddins2016-11-302-6/+20
| | | |
| * | | [FriendlyErrors] Use GFM in issue report templateSamuel Giddins2016-11-302-5/+7
| | | |
| * | | [Env] Print as GFMSamuel Giddins2016-11-302-23/+28
| |/ /
* | | Merge pull request #5236 from smlx/patch-1André Arko2016-12-091-1/+1
|\ \ \ | |_|/ |/| | Fix typo in man page.