| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
| |
This effectively changes the output of commands that use Source::Git#to_s
(ie. `bundle install`). For example:
Using rack 1.0.0 from git@github.com:rack/rack.git (at master@574b147)
Closes #3433.
|
| |\
| |
| | |
Send X-Gemfile-Source header to source mirrors
|
| | |
| |
| |
| |
| | |
Since gemstash will only support RubyGems >= 2.4 (bundler/gemstash#32),
we only set this header in RubyGems 2.0+.
|
| | |
| |
| |
| |
| | |
This is essentially Gem::RemoteFetcher with added support for setting
extra HTTP headers to be sent when fetching the gems.
|
| | | |
|
| |/
|
|
|
| |
Using `Source::Rubygems::Remote#original_uri` we can now retrieve the
original, unmirrored rubygem source URI.
|
| |\
| |
| |
| |
| | |
[RuboCop] Update to 0.34.2
|
| | | |
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| |
| | |
[Resolver] Resolve for a given ruby version
Take the definition's ruby version into account when resolving, to try and avoid conflicts with incompatible `required_ruby_version`s. This will mostly help once the compact index is in use.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | | |
[Index] Handle when comparing against an index with no gemspec
Closes #4004.
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Remove excessive periods from DSL error messages
Apparently, a period is already added when interpolating those messages,
some lines below.
|
| | | |
| | |
| | |
| | |
| | | |
Apparently, a period is already added when interpolating those messages,
some lines below.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
Remove `autoload :Specification`
This constant isn't defined anymore
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
- This class was removed in 2010 but the autoload was neglected 64b8b5
- Closes #4050
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Refactoring config.rb
My main goal was to show the structure of the run method:
1. Guard Clauses
2. Message to user
3. Save new settings
and to separate the message texts from the rest of the logic.
So the class and methods are easier to understand read.
While doing that I reduced the complexity of the run method by
extracting methods. This should improve the Code Climate rating of
Bundler::CLI::Config substantially.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
My main goal was to show the structure of the run method:
1. Guard Clauses
2. Message to user
3. Save new settings
and to separate the message texts from the rest of the logic.
So the class and methods are easier to understand read.
While doing that I reduced the complexity of the run method by
extracting methods. This should improve the Code Climate rating of
Bundler::CLI::Config substantially.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Add more `Env` tests
|
| | |/ / / |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add missing backtick in Bundler::GemHelper#sh
Since across the codebase and documentation shell commands are displayed
wrapped in backticks, the command included in the error output of
Bundler::GemHelper#sh should also be displayed in the same format.
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
Since across the codebase and documentation shell commands are displayed
wrapped in backticks, the command included in the error output of
Bundler::GemHelper#sh should also be displayed in the same format.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
clean: add test for not removing git extensions artifacts
Unfortunately https://github.com/bundler/bundler/pull/4030 was merged before I had a chance to write a test. I confirmed that the test did not pass before my patch.
Any ETA of 1.10.7 which includes #4030? :heart:
@indirect @segiddins @andremedeiros @skottler
|
| | |/ / |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
this speeds up these tests by a huge amount, since we stop downloading
and installing a crapton of gems live over the internet
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | | |
Fix Style/SpaceInsideStringInterpolation
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Also print gemspecs in `bundle env`
This change has the nice side-effect that `bundle env` will throw an error for Gemfiles with invalid DSLs.
Closes https://trello.com/c/QOX9jyYN.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
This change has the nice side-effect that `bundle env` will throw an error
for Gemfiles with invalid DSLs.
Closes https://trello.com/c/QOX9jyYN.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
Show ruby engine and version
instead of a static string.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Outdent access modifiers like private
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I wanted to fix some minor Rubocop issues and got confused by
'#{ruby_engine}/#{ruby_version}'. I managed to confuse two other people
working on bundler as well, so I decided to refactor the part around it.
I wanted to encapsulate the file creation, so it's (even) more obvious
from the context that another ruby file is created. So having an
uninterpolated string with interpolation syntax in it isn't so unusual.
To be extra sure I added a comment here as Rubocop might lead others to
the same spot.
I found that Standalone works quite well as its own object. While
extracting the class I shortened some expressions and extracted methods
that made sense as a unit to me. I ended up with a generate method that
only deals with file output.
What I think might be controversial:
* The tendency to use methods instead of variables for small things like
version_dir and bundler_path:
I think it's easier to understand because methdos are "read_only",
while values of variables might change during code execution.
* Array(spec.require_paths) instead of
"next if spec.require_paths.nil? # builtin gems".
We lose the comment here, but I thought Array was more concise and
that the information about the type of gems isn't crucial here.
* flat_map { map { ... } } instead of "collecting" in paths
My perspective is that paths is the result of a transformation of
@specs and that's best expressed by using map. It's also shorter.
|
| |\ \ \
| |_|/
|/| |
| | |
| | |
| | | |
include 'pkg/' in rake/clean's CLOBBER array
closes #3676
|
| | | |
| | |
| | |
| | |
| | |
| | | |
rake's built-in clean and clobber tasks are now included
test that 'pkg' is added to CLOBBER filelist
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Fix Style/TrailingUnderscoreVariable
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Update binstubs command description for multiple gems
The current long description or the `binstubs` command does not provide
any hint that it can accept multiple gems as arguments and generate
binstubs for all of them.
This PR enhances the description using similar phrasing for usage
with multiple gem arguments, to the `outdated` command.
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The current long description or the `binstubs` command does not provide
any hint that it can accept multiple gems as arguments and generate
binstubs for all of them.
This commit enhances the description using similar phrasing for usage
with multiple gem arguments, to the `outdated` command.
|
| |\ \ \
| |/ /
|/| | |
runtime: avoid cleaning up extensions directory
|
