summaryrefslogtreecommitdiff
path: root/Rakefile
Commit message (Collapse)AuthorAgeFilesLines
...
| * Use progress in the "co" task tooDavid Rodríguez2019-03-281-1/+1
| | | | | | | | Since it's meant for CI.
| * Remove clone rubygems taskDavid Rodríguez2019-03-281-22/+2
| | | | | | | | Delegate everything to `bin/with_rubygems` instead.
| * Remove option already set by defaultDavid Rodríguez2019-03-281-1/+1
| |
| * Remove NULL_DEVICEDavid Rodríguez2019-03-281-2/+1
| |
* | Merge #7074Bundlerbot2019-03-291-5/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7074: Remove unnecessary test stuff r=colby-swandale a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that our test setup could be simpler. ### What was your diagnosis of the problem? My diagnosis was that some lines installing test gem dependencies could be removed from the Rakefile, because the tests already detect this situation and auto-install test gems appropriately. ### What is your fix for the problem, implemented in this PR? My fix is to remove the lines. However, removing the lines led to a single test failure that can be explained becase `FileUtils` ends up being required too late, thus skipping one call to `Gem.clear_paths` done in the tests setup so that stuff memoized by `rubygems` is cleared and tests can assume is not loaded yet. The situation is very intricate but I tried to explain it in the commit message. ### Why did you choose this fix out of the possible options? I chose this fix because it fixes the test failure, but I also plan to propose to eliminate the `autoload` calls in rubygems that also contributed to this issue. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Remove unnecessary stuffsimplify_gems_used_by_tests_installationDavid Rodríguez2019-03-281-5/+0
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tests automatically download and install the test gems they need if not installed, so this should be unnecessary. However, removing it create a single spec failure only reproducible on a fresh clone (where the path where the test gems are installed, `tmp/gems`, has not yet been populated. The problem was that the code branch that installs the gems uses the `FileUtils` constant. Accessing that constant makes [this autoload] trigger the custom rubygems `require` behavior which will end up setting and memoizing `gem_home` to the value it has at that point (when calling `to_spec` on the selected default gem). But at that point, `Gem.clear_paths` call has already happened, that means `gem_home` won't be changed during the duration of the test because it's memoized. This situation makes a specific test that updates `ENV["HOME"]` and expects he path to the configuration file rubygems uses to be updated fail. This could be fixed by removing the `FileUtils` autoload, or stop memoizing `Gem.home`, but the simplest fix seemed to require `fileutils` early, so that `Gem.home` is not memoized again after calling `Gem.clear_paths`. [this autoload]: https://github.com/rubygems/rubygems/blob/511a0f5105ca95b8e389bf477b6c7cf3e90be7d1/lib/rubygems/source.rb#L3
* | Merge #7035Bundlerbot2019-03-281-6/+0
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7035: Unify the certificates for rubygems.org to rubygems store. r=deivid-rodriguez a=hsbt ### What was the end-user problem that led to this PR? The problem was the users have duplicated certificates in their boxes. ### What was your diagnosis of the problem? I wonder why bundler has a certificates copy from rubygems. It raised up in the tracker of ruby core. https://bugs.ruby-lang.org/issues/15384 ### What is your fix for the problem, implemented in this PR? I removed the duplicated certificates from bundler, and fallback to rubygems's one. ### Why did you choose this fix out of the possible options? Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
| * Unify the certificates for rubygems.org to rubygems store.SHIBATA Hiroshi2019-03-141-6/+0
| | | | | | | | | | * Removed CertificateManager and related rake tasks. * Removed the certificates from bundler internal.
* | Try removing hacksDavid Rodríguez2019-03-261-5/+0
| |
* | Bump to MRI 2.5.4David Rodríguez2019-03-261-2/+2
| | | | | | | | MRI 2.5.4 now regressed and suffers from the same issue as 2.6.2 :S
* | Bump to MRI 2.6.2David Rodríguez2019-03-261-4/+2
| |
* | Describe automatiek tasksDavid Rodríguez2019-03-251-0/+11
| |
* | Improve automatiek activationDavid Rodríguez2019-03-251-8/+16
| | | | | | | | | | Make it consistent with how we do it for `ronn`, and give better messages for installing `automatiek` if missing.
* | Little refactorDavid Rodríguez2019-03-251-4/+4
| |
* | revert the RSpec format in CI back to dotsColby Swandale2019-03-211-1/+1
| |
* | Abort when building man pages without ronnDavid Rodríguez2019-03-201-1/+1
| |
* | Improve `ronn` activationDavid Rodríguez2019-03-201-8/+14
| | | | | | | | | | | | Previously having another gem with a `ronn` executable would silently work and fail later with a cryptic error. Now we activate the proper version, and give a proper error if it fails.
* | Simplify globbingDavid Rodríguez2019-03-201-1/+1
| | | | | | | | No .rb files in there.
* | Remove unused requireDavid Rodríguez2019-03-201-1/+0
| |
* | Move the `safe_task` method into the :spec namespaceDavid Rodríguez2019-03-201-7/+7
| |
* | Merge the `:spec` namespace to a single blockDavid Rodríguez2019-03-201-12/+10
| |
* | Simplify rubygems path transmissionDavid Rodríguez2019-03-201-2/+1
| | | | | | | | | | Since the RSpec task now uses the RSpec binstub, we can rely on all the dance done in there.
* | Remove now dummy being-rescue-end blockDavid Rodríguez2019-03-201-101/+97
| |
* | Simplify rubocop taskDavid Rodríguez2019-03-201-7/+6
| | | | | | | | We shell out to the binstub so we no longer need the activation dance.
* | Remove unnecessary prerequisiteDavid Rodríguez2019-03-201-1/+1
| |
* | Simplify RSpec taskDavid Rodríguez2019-03-201-17/+9
| | | | | | | | We shell out to the binstubs, so we don't need any activation dance.
* | Remove unnecessary pre-requisiteDavid Rodríguez2019-03-201-1/+0
| | | | | | | | | | This is already done from the spec helper right before the beginning of the test suite.
* | Fix `graphviz` installation on TravisCIDavid Rodríguez2019-03-151-1/+3
|/
* Use rubygems 2.7.9 in CIDavid Rodríguez2019-03-091-1/+1
|
* Use rubygems 3.0.3 in CIDavid Rodríguez2019-03-091-2/+2
|
* Auto-correct `Style/RescueStandardError` offensesDavid Rodríguez2019-03-041-1/+1
|
* Auto-correct `Style/Encoding` rubocop issuesDavid Rodríguez2019-03-041-1/+0
|
* Merge #6958Bundlerbot2019-02-131-5/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6958: Remove rdiscount indirect development dependency r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I was confused about the `rdiscount` dependency since I didn't see it used anywhere. ### What was your diagnosis of the problem? My diagnosis was that it's just an indirect dependency (through ronn). ### What is your fix for the problem, implemented in this PR? My fix is to remove the dependency. ### Why did you choose this fix out of the possible options? I chose this fix because it will no longer confuse devs into thinking we're actually using it directly. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Remove rdiscount indirect dependencyremove_rdiscount_indirect_dependencyDavid Rodríguez2019-02-111-5/+2
| | | | | | | | | | | | We don't use this dependency directly so this is not needed. We put it there at some point because we needed to pin to a specific version, but that's no longer the case.
* | Bump base rubygems version to 3.0.2bump_base_rubygems_versionDavid Rodríguez2019-02-121-1/+1
|/
* Bump Travis entries to use rubygems 2.7.8bump_base_rubygems_and_ruby_2.3_in_travisDavid Rodríguez2019-02-101-1/+1
|
* Bump main tested rubygems to 3.0.2travis_experimentsDavid Rodríguez2019-02-081-1/+1
|
* Bump main tested ruby to 2.6.1David Rodríguez2019-02-081-0/+7
|
* Move Rubocop development dependency into gemspecAlyssa Ross2019-01-231-8/+3
| | | | | | | | | Now that Bundler no longer supports Ruby <2.3, the Ruby minimum version requirement that prevented Rubocop from being specified as a development dependency in the gemspec no longer applies. Having Rubocop in the gemspec is useful for tools like RubyGems.org or Bundix that use it as the source of truth for dependencies.
* Test against Ruby 2.6 and RubyGems 3Samuel Giddins2018-12-281-1/+1
|
* move rubocop into a separate stage in Travis-CIColby Swandale2018-12-061-5/+0
|
* Remove unnecessary stuff from specsDavid Rodríguez2018-10-261-11/+4
| | | | Since we no longer test against rubygems versions that old.
* Make RakeTask spec:deps OS agnosticLeo Arnold2018-10-171-1/+2
| | | | | | | | @segiddins encouraged contributions towards support for Windows https://github.com/bundler/bundler/issues/5992#issuecomment-326809543 As a first step towards this goal this commit fixes file path specification in the first pieces of Ruby code called when setting up a test environment.
* To use --no-document option after RubyGems 2.0. RubyGems will remove --no-ri ↵SHIBATA Hiroshi2018-07-121-1/+1
| | | | and --no-rdoc options at RubyGems 3.0
* Cleanup rubygems version listDavid Rodríguez2018-06-271-1/+1
|
* Test against latest rubygems versionDavid Rodríguez2018-06-271-1/+1
|
* [Travis] Test against latest RubyGems versionseg-travis-2-5Samuel Giddins2017-12-261-1/+1
|
* [Travis] Test against RubyGems 2.7.1Samuel Giddins2017-11-031-1/+1
|
* Auto merge of #6054 - walf443:improve_rubocop_todo, r=segiddinsThe Bundler Bot2017-10-061-2/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | improve .rubocop_todo.yml ### What was the end-user problem that led to this PR? No ### What was your diagnosis of the problem? No ### What is your fix for the problem, implemented in this PR? My fix reduce ruboco_todo.yml lines. - Style/EmptyLinesAroundExceptionHandlingKeywords - Style/SpaceAroundOperators - Style/SpaceInsideBlockBraces - Lint/DuplicateMethods - Lint/Void - Style/IfUnlessModifier - Style/MixinGrouping - Style/NestedParenthesizedCalls - Style/OrAssignment - Style/RedundantParentheses - Style/TernaryParentheses
| * improve rubocop_todo.ymlKeiji Yoshimi2017-09-241-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Style/EmptyLinesAroundExceptionHandlingKeywords - Style/SpaceAroundOperators - Style/SpaceInsideBlockBraces - Lint/DuplicateMethods - Lint/Void - Style/IfUnlessModifier - Style/MixinGrouping - Style/NestedParenthesizedCalls - Style/OrAssignment - Style/RedundantParentheses - Style/TernaryParentheses
View Lorry Controller Status