| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
Since we no longer use `git` to find out the list of files, the comment
is misleading.
|
| |
|
|
|
|
| |
And refactor development setup.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
I was hoping this would turn up new cops or changes. It did not end up
changing anything.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Fix config and regenerate TODO config.
|
|
|
|
| |
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
|
|
|
|
|
| |
We don't use this dependency directly so this is not needed. We put it
there at some point because we needed to pin to a specific version, but
that's no longer the case.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6926: Move Rubocop development dependency into gemspec r=hsbt a=alyssais
### What was the end-user problem that led to this PR?
The problem was that tools like RubyGems.org or Bundix that use the gemspec as the source of truth for dependencies didn't pick up on the development dependency on Rubocop.
### What was your diagnosis of the problem?
My diagnosis was that the reason for this, which was that Rubocop had a minimum Ruby version of 2.0.0, was no longer an issue, since Bundler 2 doesn't support Rubies that old anyway.
### What is your fix for the problem, implemented in this PR?
My fix was to move the Rubocop requirement into the gemspec.
### Why did you choose this fix out of the possible options?
I chose this fix because it addresses the problem I was having, feels right, and the old workaround doesn't look like it's necessary any more.
Co-authored-by: Alyssa Ross <hi@alyssa.is>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Now that Bundler no longer supports Ruby <2.3, the Ruby minimum version
requirement that prevented Rubocop from being specified as a development
dependency in the gemspec no longer applies.
Having Rubocop in the gemspec is useful for tools like RubyGems.org or
Bundix that use it as the source of truth for dependencies.
|
|/
|
|
| |
Ruby 2.7.0-dev added the warnings about Object =~. We need to avoid it.
|
| |
|
| |
|
| |
|
|
|
|
| |
spec/runtime/setup_spec.rb:896
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Bundler gemspec
|
|
|
|
| |
f06405 caused a regression with warbler, described in #6165
|
|
|
|
| |
This will keep the (development) binstubs working
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove uneeded files packaged into bunder's gem build on rubygems
What was the end-user problem that led to this PR?
--------------------------------------------------
I noticed while doing a `bundle open bundler` (inception!) that we have included the `bin/` directory in the packaged gem. While this is not hurting anything, it provides a bunch of scripts that won't function properly in any capacity when installed through ruby gems.
While doing that, I noticed that the dotfiles for CI were also packaged up in the gem, so I made sure to only include specific files from there that seemed to provide value when being shipped as a gem.
What is your fix for the problem, implemented in this PR?
---------------------------------------------------------
Change the reduction of the results from `git ls-files` to be a whitelist instead of a blacklist. This was to reduce the complexity of the regexp that would have resulted from change what directories to include, not ship CI files in the top level dir, while also still wanting to ship the `CHANGELOG.md`, `LICENSE.md`, and `README.md` files along with the build, since I think they do provide value being included with the packaged gem.
Why did you choose this fix out of the possible options?
--------------------------------------------------------
Some of the choices here were a bit subjective, especially what I decided on as "necessary" regarding the `.md` files that I included. Projects like rails went with these three, so I decided to use that as a base, but some might think that the `CHANGELOG.md` being included is a bit excessive and is a large file that most won't even read in this form, and I don't have a hard opinion one way or the other.
That said, I do think that developer files should not be packaged in the gem, and this precedent has already been set with the original blacklist, it just wasn't very complete. How I did it could probably be changed based on developer preference, but I tried to stay as true to what was already there before all else.
|
| |
| |
| |
| |
| |
| | |
While not required for the build to function, they provide links and
information to developers who find themselves in the codebase of the gem
they have installed on their system.
|
| |
| |
| |
| |
| |
| |
| | |
The `bin/` dir was getting included as part of the bundler release,
along with all of the files from the top level directory in the project,
most of which don't need to be there (CI config files mostly). Only the
`lib/` and `exe/` dirs are needed from git.
|
|/ |
|
| |
|
|
|
|
| |
Run `rubocop -a --only Style/PercentLiteralDelimiters` and `rubocop --auto-gen-config`.
|
|
|
|
| |
Including new changelog link
|
| |
|
| |
|
|
|
|
|
|
| |
as demonstrated on twitter[1], this message was unfortunately convincing people that Ruby Together pays for the rubygems.org servers. let's remove it and come up with something clearer later.
[1]: https://twitter.com/MelissaKaulfuss/status/829504864229023744
|
| |
|
| |
|
| |
|