Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix RubyVersion specs failuresseg-ruby-version-fixes | Samuel Giddins | 2016-02-01 | 1 | -2/+2 |
| | |||||
* | [Fetcher] Update user agent construction for new RubyVersion API | Samuel Giddins | 2016-02-01 | 1 | -2/+2 |
| | |||||
* | Compatibility with frozen string literals | Samuel Giddins | 2016-01-31 | 1 | -4/+7 |
| | |||||
* | [RuboCop] Fix Style/MutableConstant | Samuel Giddins | 2016-01-31 | 1 | -7/+7 |
| | |||||
* | [RuboCop] Address Style/GuardClause | Samuel Giddins | 2016-01-31 | 1 | -7/+5 |
| | |||||
* | ArgumentErrors are not really retriable | Andre Arko | 2016-01-25 | 1 | -1/+1 |
| | |||||
* | BadRequirementError guard | Andre Arko | 2016-01-25 | 1 | -0/+1 |
| | |||||
* | add BadRequirementError to known failures list | Andre Arko | 2016-01-25 | 1 | -1/+1 |
| | |||||
* | [fetcher] stop retrying on known failure errors | Andre Arko | 2016-01-25 | 1 | -1/+1 |
| | |||||
* | cancel retries on 404 Not Found | Andre Arko | 2016-01-25 | 1 | -2/+2 |
| | | | by raising FallbackError on 404 as well as 413, and then adding FallbackError to the list of errors to not retry, we both cancel retries for 404s and incidentally also cancel retries on 413s. | ||||
* | responses aren’t strings, but bodies are | Andre Arko | 2016-01-25 | 1 | -1/+1 |
| | |||||
* | build spec objects only in Fetcher#specs | Andre Arko | 2016-01-25 | 1 | -2/+8 |
| | |||||
* | remove fetchers that aren’t available | Andre Arko | 2016-01-25 | 1 | -0/+1 |
| | |||||
* | make --full-index fall back to specs.4.8.gz | Andre Arko | 2016-01-25 | 1 | -5/+10 |
| | |||||
* | [Fetcher] Dont check dependency api unless compact index is unavailable | Samuel E. Giddins | 2016-01-25 | 1 | -1/+1 |
| | |||||
* | [CompactIndex] Use vendored compact_index_client | Samuel E. Giddins | 2016-01-25 | 1 | -1/+0 |
| | |||||
* | [RuboCop] Fix violations | Samuel E. Giddins | 2016-01-25 | 1 | -1/+1 |
| | |||||
* | [Fetcher] Make checking for API availability Ruby 1.8.7 compatible | Samuel E. Giddins | 2016-01-25 | 1 | -1/+1 |
| | |||||
* | [Fetcher::Index] Fix the returned specifications | Samuel E. Giddins | 2016-01-25 | 1 | -1/+2 |
| | |||||
* | [Fetcher] Fix availability logic to avoid multiple calls | Samuel E. Giddins | 2016-01-25 | 1 | -2/+2 |
| | |||||
* | Actually implement the vision for the new index | Samuel E. Giddins | 2016-01-25 | 1 | -12/+6 |
| | |||||
* | [Fetcher] Add Fetchers for the new index format! | Samuel E. Giddins | 2016-01-25 | 1 | -3/+5 |
| | |||||
* | Move `Bundler#ruby_version` functionality to `Bundler::RubyVersion#system` | James Wen | 2016-01-14 | 1 | -1/+1 |
| | | | | | - Part of design direction to move more functionality out of the `Bundler` top-level module. | ||||
* | Extract safe const_get logic into `SharedHelpers#const_get_safely` | James Wen | 2016-01-02 | 1 | -9/+7 |
| | |||||
* | Add `Net#HTTP--` errors safely (only if in version of ruby stdlib) | James Wen | 2016-01-01 | 1 | -4/+10 |
| | |||||
* | Add more exception classes not to retry on to the Fetcher | James Wen | 2015-12-13 | 1 | -1/+4 |
| | | | | | - These are all Exception classes that indicate scenarios where retrying the fetch/request would not suddenly have a successful result. | ||||
* | Auto merge of #4124 - bundler:seg-rubocop, r=indirect | Homu | 2015-11-27 | 1 | -7/+6 |
|\ | | | | | | | More rubocop_todo cleanup | ||||
| * | [RuboCop] Enable Style/IfUnlessModifier | Samuel Giddins | 2015-11-26 | 1 | -3/+1 |
| | | |||||
| * | [RuboCop] Enable Style/EmptyLinesAroundModuleBody | Samuel Giddins | 2015-11-26 | 1 | -1/+0 |
| | | |||||
| * | [RuboCop] Enable Style/EmptyElse | Samuel Giddins | 2015-11-26 | 1 | -2/+0 |
| | | |||||
| * | [RuboCop] Enable Style/RescueModifier | Samuel Giddins | 2015-11-26 | 1 | -1/+5 |
| | | |||||
* | | Auto merge of #4103 - jingweno:master, r=indirect | Homu | 2015-11-27 | 1 | -0/+7 |
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Retry `Fetcher#specs` with `Bundler::Retry` As mentioned in https://github.com/heroku/heroku-buildpack-ruby/pull/435, bundler failed at the step of fetching version metadata: ``` Fetching version metadata from https://rubygems.org/Net::HTTPInternalServerError: <?xml version=\"1.0\" encoding=\"UTF-8\"?> <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>E7402EA19C5D6803</RequestId><HostId>hzuvaA1JAZX6ST+OL4ARYeAqZ/tgkM2yOjZgBq6Panu10YzWtfNNozOg8N5qR3gxFE/sUfYGP48=</HostId></Error> ``` It turns out the retry logic doesn’t cover fetching source index, gem metadata, version metadata and dependency metadata. A new method `Fetcher#specs_with_retry` is added to wrap `Fetcher#specs` with `Bundler::Retry` which reties when bundler fails in the mentioned cases. /cc @schneems | ||||
| * | Retry `Fetcher#specs` with `Bundler::Retry` | Jingwen Owen Ou | 2015-11-11 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | As mentioned in https://github.com/heroku/heroku-buildpack-ruby/pull/435, bundler failed at the step of fetching version metadata: ``` Fetching version metadata from https://rubygems.org/Net::HTTPInternalServerError: <?xml version=\"1.0\" encoding=\"UTF-8\"?> <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>E7402EA19C5D6803</RequestId><HostId>hzuvaA1JAZX6ST+OL4ARYeAqZ/tgkM2yOjZgBq6Panu10YzWtfNNozOg8N5qR3gxFE/sUfYGP48=</HostId></Error> ``` It turns out the retry logic doesn’t cover fetching source index, gem metadata, version metadata and dependency metadata. A new method `Fetcher#specs_with_retry` is added to wrap `Fetcher#specs` with `Bundler::Retry` which reties when bundler fails in the mentioned cases. | ||||
* | | Auto merge of #4091 - smellsblue:full-index-x-gemfile-source, r=segiddins | Homu | 2015-11-12 | 1 | -13/+1 |
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | Send X-Gemfile-Source when bundling with --full-index This fixes #4090 I did a little refactoring that made sense to me along the way, but if I went too far or might be breaking something I'm not aware of, please let me know. **Existing issue:** This doesn't fix bundling with full index when using Rubygems < 2.0, as that code path seemed a bit trickier to fix. I added a *TODO* comment at the relevant method. I thought of a couple possibilities: * Subclass `Gem::SpecFetcher` like `Bundler::GemRemoteFetcher`, it seems like it might be as simple as calling the super constructor and then replace `@fetcher` with a `Bundler::GemRemoteFetcher` with the headers added ahead of time (see https://github.com/rubygems/rubygems/blob/v1.8.30/lib/rubygems/spec_fetcher.rb#L66). This may involve different solutions the further back in Rubygems you go. * Use the newer implementation of `fetch_all_remote_specs` for older Rubygems as well (I don't know if that would work though, but it might be worth a try). I haven't yet added additional specs for this, but I wanted to get this out there first to get some feedback if possible. | ||||
| * | Pass remote as is to fetcher | Mike Virata-Stone | 2015-11-02 | 1 | -13/+1 |
| | | | | | | | | | | | | | | Move fetch_uri into the base fetcher Expose remote for base fetcher Set and restore gem sources only seems to be neccessary in one form of fetch_all_remote_specs Send X-Gemfile-Source header when fetching the specs | ||||
* | | Require Zlib on the Fetcherretry-http-on-zlib-error | Andre Medeiros | 2015-11-09 | 1 | -0/+1 |
| | | | | | | | | | | I really don't like this solution, but it's the simplest one so we can recover from that error on 1.8.7. | ||||
* | | Retry Fetch operation on Zlib error. | Andre Medeiros | 2015-10-28 | 1 | -1/+1 |
|/ | | | | This fixes #4074 | ||||
* | Set X-Gemfile-Source when fetching dependencies | Agis Anastasopoulos | 2015-10-20 | 1 | -0/+1 |
| | |||||
* | add http:// | masarakki | 2015-09-13 | 1 | -1/+1 |
| | |||||
* | Append specs. | Hirotaka Azuma | 2015-08-14 | 1 | -0/+8 |
| | |||||
* | Don't call Gem::configuration in Bundler::Fetcher | Hirotaka Azuma | 2015-08-14 | 1 | -1/+1 |
| | |||||
* | considerate .gemrc when determine http_proxy | Hirotaka Azuma | 2015-08-14 | 1 | -0/+3 |
| | |||||
* | Fix Style/MethodDefParentheses | Victor Koronen | 2015-08-14 | 1 | -1/+1 |
| | |||||
* | [RuboCop] Update to 0.33.0 | Samuel E. Giddins | 2015-08-07 | 1 | -1/+1 |
| | |||||
* | Fix Lint/UnusedBlockArgument | Erick Sasse | 2015-07-20 | 1 | -1/+1 |
| | |||||
* | Fix Style/SelfAssignment | Erick Sasse | 2015-07-19 | 1 | -1/+1 |
| | |||||
* | Fix Style/SpaceInsideBlockBraces | Andre Arko | 2015-07-18 | 1 | -1/+1 |
| | | | | closes #3853 | ||||
* | Fix Style/SpaceInsideBlockBraces | Andre Arko | 2015-07-18 | 1 | -5/+5 |
| | | | | closes #3850 | ||||
* | [RuboCop] Enable Style/StringLiterals | Samuel E. Giddins | 2015-07-15 | 1 | -11/+11 |
| | |||||
* | [RuboCop] Enable Style/EmptyLines | Samuel E. Giddins | 2015-07-15 | 1 | -1/+0 |
| |