| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
7465: December manpages r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that man pages are out of date.
### What is your fix for the problem, implemented in this PR?
My fix is to update them.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit 88bc81b26e1fa409a384925ae865e477073b4f03)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
7410: November man pages r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that man pages are outdated after the month change.
Well, the problem actually is that I need to fix in a better way (like a monthly scheduled rebuild or something), but I keep just updating the man pages every month... :sweat_smile:
### What is your fix for the problem, implemented in this PR?
My fix to run `bin/rake man:build` and commit the result.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit 49f585ca9e5ecf2f0cf5529e1b320ce07d443de9)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
7389: Wrap up `bundle cache` migration to current `bundle package` r=indirect a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that after https://github.com/bundler/bundler/pull/7249, we added the current `bundle package` functionality to the current `bundle cache` command, so that these commands are now aliases of each other.
The initial plan was to do this in a more careful manner but we concluded that this was only _adding_ functionality to `bundle cache`, so not backwards incompatible.
We still need to wrap up the original plan, where `bundle cache` is the preferred command.
### What is your fix for the problem, implemented in this PR?
My fix is to migrate docs, tests and help text to use `bundle cache`, and to remove duplicated specs for `bundle cache` and `bundle package`, since they are testing the exact same code.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit 5ba1360de631e2fabf2bfa998b104c4355c58b13)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
7372: October manpages r=hsbt a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that outdated manpages.
### What is your fix for the problem, implemented in this PR?
My fix is to update them.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit 8058b2e3178a0ac5775a07279811755cf23339f5)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
7353: require `rubygems`, not `ubygems` in example r=hsbt a=crazymykl
The latter does not work on Ruby 2.6.3.
Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.
### What was the end-user problem that led to this PR?
The problem was a broken example in the docs.
### What was your diagnosis of the problem?
Ibid.
### What is your fix for the problem, implemented in this PR?
My fix was to write what was likely intended.
### Why did you choose this fix out of the possible options?
I chose this fix because the solution space is pretty small.
Co-authored-by: Mike MacDonald <crazymykl@gmail.com>
(cherry picked from commit f7de5df5910d5bea9de22536b7f7f646fed30f6f)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
7339: Bump man documentation's month r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that CI is green because `rake man:check` is failing.
### What was your diagnosis of the problem?
My diagnosis was is that this is a gotcha of our current documentation building workflow.
### What is your fix for the problem, implemented in this PR?
I want to address this in the future but for now the easiest for me is to bump the documentation's date once a month.
### Why did you choose this fix out of the possible options?
I chose this fix because it's the simplest way to get CI green for me now.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit 022f9bc99e05fc0f7334a67f4b2377f9af946bfa)
|
|
|
|
| |
This reverts commit 52c5a0eedec34b5d86464b3cf135dc2002486f1d.
|
|
|
|
| |
And instead educate users on the preferred, non deprecated, way.
|
| |
|
|
|
|
| |
So that the examples work in currently supported rubies.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has the benefit that:
* Allows the installation of bundler as a default gem from rubygems to
include man pages.
* Removes the need to build man pages during our tests.
* Makes working with the manifest easier, because we only have source
controlled files, and not a mix of source control and generated files.
To make sure they never fall out of sync, we replace the previous
`man:build` CI task with a `man:check` task that makes sure the
generated man pages are up to date.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
7265: Fix incorrect sectioning in `gemfile` man page r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that Gemfile's man page has incorrect syntax in the section where examples for `:ref`, `:tag` and `:branch` are given.
### What was your diagnosis of the problem?
My diagnosis was that the section was incorrect since the examples were listed as a separate section. Also, the syntax seems incorrect, since building the docs with [ronn-ng]() (something I've been experimenting with lately) gives the following error:
```
$ bin/rake man/gemfile.5
/home/deivid/.rbenv/versions/2.6.3/bin/ruby -S ronn --roff --pipe man/gemfile.5.ronn > man/gemfile.5
warn: unrecognized inline tag: ["p"]
warn: unrecognized inline tag: ["p"]
warn: unrecognized inline tag: ["p"]
man/gemfile.5 ran for 0.000305 0.000038 0.317832 ( 0.317939)
```
### What is your fix for the problem, implemented in this PR?
My fix is to correct the syntax. The comparison of the rendered man page is:
#### `bundle help gemfile` (before)
```
(...)
branch, tag, and ref
You MUST only specify at most one of these options. The default is :branch => "master"
For example:
submodules
For reference, a git submodule https://git-scm.com/book/en/v2/Git-Tools-Submodules lets you have another git repository within a subfolder of your
repository. Specify :submodules => true to cause bundler to expand any submodules included in the git repository
(...)
```
#### `bundle help gemfile` (after)
```
(...)
branch, tag, and ref
You MUST only specify at most one of these options. The default is :branch => "master". For example:
git "https://github.com/rails/rails.git", :branch => "5-0-stable" do
git "https://github.com/rails/rails.git", :tag => "v5.0.0" do
git "https://github.com/rails/rails.git", :ref => "4aded" do
submodules
For reference, a git submodule https://git-scm.com/book/en/v2/Git-Tools-Submodules lets you have another git repository within a subfolder of your
repository. Specify :submodules => true to cause bundler to expand any submodules included in the git repository
(...)
```
### Why did you choose this fix out of the possible options?
I chose this fix because it seems like the right thing to do.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
|
| | |
|
| | |
|
|/ |
|
| |
|
|
|
| |
The default cache path is `vendor/cache`, not `vendor/bundle`.
|
|
|
|
|
|
|
| |
This is a bug fix, so it makes no sense to make it configurable. Also,
the fix is unlikely to cause problems other than maybe needing a fresh
`bundle install` on some edge cases. So, let's ship the fix and remove
the setting.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
7127: Add git and branch options to `bundle add` r=deivid-rodriguez a=tokachev
Closes #6841 These changes will allow to add a gem with the git or branch options.
```
bundle add redis --git "https://github.com/redis/redis-rb" --branch "staging"
```
The result in Gemfile will be:
```
gem "redis", "~> 4.0", :git => "https://github.com/redis/redis-rb", :branch => "staging"
```
Co-authored-by: Baumgarten <baumgarten@localhost.localdomain>
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In my opinion, it's overkill to provide a setting for how little this
setting was doing. Both types of Gemfile are supported and work
regardless of this setting. The only difference this setting would make
is the warning message one would get when having _both_ types of
Gemfiles in the same project.
I changed things so that gems.rb is always looked up first, and the
warning message in case you have both always tells you to remove Gemfile
and Gemfile.lock.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The list command was still present (just aliased to `bundle show`), even
if the setting was set to false. So the setting was at least super
confusing if not just wrong.
It also led to misleading situations such as
```
$ bundle list --help
(...)
NAME
bundle-list - List all the gems in the bundle
SYNOPSIS
bundle list [--name-only] [--paths] [--without-group=GROUP] [--only-group=GROUP]
(...)
$ bundle list --only-group=development
Unknown switches '--only-group=development'
```
So, instead, I enable the new list command _always_ and remove the
`bundle list => bundle show` alias.
|
|
|
|
| |
They are actually compatible.
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6931: Add patch option in bundle config r=greysteil a=ankitkataria
### What was the end-user problem that led to this PR?
Issue #5994
### What was your diagnosis of the problem?
As mentioned by @indirect I added a `patch` option in the bundler config, which by default is false. If set to true, patch level update are preferred if no update levels are specified.
### What is your fix for the problem, implemented in this PR?
A patch level config option which can be opted into.
Co-authored-by: Ankit Kataria <ankitkataria28@gmail.com>
|
| | |
|
| | |
|
|/ |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6751: Fix BUNDLE_PATH_RELATIVE_TO_CWD env variable name r=greysteil a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that an environment variable in the docs does not work.
### What was your diagnosis of the problem?
My diagnosis was that its name is incorrect.
### What is your fix for the problem, implemented in this PR?
My fix is to fix the typo.
### Why did you choose this fix out of the possible options?
I chose this fix because it's the only non absurd fix.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
|
| | |
|
|/ |
|
| |
|
| |
|
|
|
|
| |
Bundler
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add `bundle remove`
Features of the command implemented:
- Multiple gems support
```bash
$ bundle remove rack rails
```
- Remove any empty block that might occur after removing the gem or otherwise present
Things yet to implement:
- Add `rm` alias. _Optional_
- [x] Add `--install` flag to remove gems from `.bundle`.
- [x] Handling multiple gems on the same line.
- [x] Handle gem spec
- [x] Handle eval_gemfile cases ([one](https://github.com/bundler/bundler/pull/6513#discussion_r195632603) case left)
Closes #6506
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Document that `bundle show [--paths]` sorts results
### What was the end-user problem that led to this PR?
The problem was that I could not tell from the manpage or documentation website whether `bundle show` and `bundle show --paths` would list gems and gem paths in the same order.
I am using `bundle show` and `bundle show --paths` to inventory gems that projects depend upon.
### What was your diagnosis of the problem?
My diagnosis was that the implementation of `bundle show` _does_ sort results by name, but that the manpage for the subcommand doesn't mention this.
### What is your fix for the problem, implemented in this PR?
My fix involved slightly editing the existing manpage for `bundle show`.
### Why did you choose this fix out of the possible options?
I chose this fix because the `.ronn` file text matched the current text I was seeing via the documentation website.
|