summaryrefslogtreecommitdiff
path: root/spec/commands
Commit message (Collapse)AuthorAgeFilesLines
* Always pass the `--all` flag when neededremove_bundle_update_deprecationsDavid Rodríguez2019-03-303-19/+19
|
* Remove `bundle config` deprecations from specsremove_bundle_config_deprecationsDavid Rodríguez2019-03-298-22/+22
|
* Merge #7073Bundlerbot2019-03-291-2/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7073: Unskip passing spec r=colby-swandale a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I discovered by chance that one of the skipped specs seems to be passing. ### What was your diagnosis of the problem? My diagnosis was that something has changed for the better that made this spec green. ### What is your fix for the problem, implemented in this PR? My fix is to remove the skip. ### Why did you choose this fix out of the possible options? I chose this fix because it's good :) Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * This spec is now passing, it seemsunskip_not_failing_specDavid Rodríguez2019-03-281-2/+0
| |
* | Allow `update` to install when `--no-install` usedno_install_allows_update_to_installDavid Rodríguez2019-03-281-0/+12
|/ | | | The `--no-install` flag flag is only meant for `bundle package`.
* Make `bundle clean` clean git extension directoriesDylan Thacker-Smith2019-03-211-0/+39
|
* Remove ruby version leftoversremove_ruby_version_leftoversDavid Rodríguez2019-03-152-9/+4
|
* Merge #7037Bundlerbot2019-03-151-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7037: Test `bundle viz` command deprecation r=colby-swandale a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we were not printing any deprecation messages for `bundle viz`. ### What was your diagnosis of the problem? My diagnosis was that we are removing `bundle viz` at the same time as deprecating it. Thus, the deprecations never actually show up. ### What is your fix for the problem, implemented in this PR? My fix is to first deprecate the command on bundler 2, then remove it in bundler 3. ### Why did you choose this fix out of the possible options? I chose this fix because it's the most sensible approach to this removal. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Test and fix `bundle viz` command deprecationDavid Rodríguez2019-03-151-1/+1
| |
* | Merge #7030Bundlerbot2019-03-151-22/+4
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7030: Remove `LessThanProc` r=colby-swandale a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the `LessThanProc` class we use for filtering specs is confusing, in my opinion. For example, if I tag a spec with `:bundler => "2"`, I would expect it to run only against bundler 2. However, that's not how it works, it instead runs against any bundler higher than or equal to 2. ### What was your diagnosis of the problem? My diagnosis was that the `LessThanProc` class could be much simpler, and just check that the passed requirement matches the version the class was created with. ### What is your fix for the problem, implemented in this PR? My fix is to simplify the `LessThanProc` class to only do requirement matching, and remove the "less than" functionality. ### Why did you choose this fix out of the possible options? I chose this fix because in my opinion it's simpler to understand and less surprising. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Remove old 1.9 stuffDavid Rodríguez2019-03-131-22/+4
| |
* | Remove `eq_err` matcherDavid Rodríguez2019-03-141-1/+1
|/ | | | In favor of a simpler helper.
* Test repo1 should be inmutableDavid Rodríguez2019-03-131-1/+1
|
* Fixes for dockerDavid Rodríguez2019-03-131-2/+2
|
* make rubocop happyJan Piotrowski2019-03-032-2/+2
|
* fix other sys_exec calls that prepended an env variableJan Piotrowski2019-03-032-2/+2
|
* Remove unnecessary rubygems filters from specsDavid Rodríguez2019-02-256-32/+9
|
* Remove unnecessary ruby filters from specsremove_unnecessary_ruby_filtersDavid Rodríguez2019-02-224-5/+5
|
* Reword deprecation messagesDavid Rodríguez2019-02-211-4/+4
| | | | | | Including the version is confusing, in my opinion, because it's unclear whether it refers to the future version of removal, or to the current running version.
* Merge #6974Bundlerbot2019-02-2013-73/+71
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6974: Use newer list interface r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that our specs emit a lot of deprecations about the list command. ### What was your diagnosis of the problem? My diagnosis was that we are using the deprecated interface to the list command everywhere. ### What is your fix for the problem, implemented in this PR? My fix is to start using the new interface. If we don't use it ourselves, how could we be in a position to tell our users to start using it? ### Why did you choose this fix out of the possible options? I chose this fix because we should do this, at same point, and doing it now simplifies enabling deprecations. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Remove undefined commandDavid Rodríguez2019-02-191-2/+0
| |
| * Use newest interface to `bundle config` everywhereDavid Rodríguez2019-02-1913-71/+71
| |
* | Fixed cop failuresSHIBATA Hiroshi2019-02-201-1/+1
| |
* | Use ENV["BUNDLE_GEM"] instead of gem command provided by system ruby.SHIBATA Hiroshi2019-02-191-5/+9
|/ | | | | It break the examples of bundler. Because some examples detect the different version of system ruby than test target version like trunk.
* Fix 1.x specscheck_out_only_in_specsDavid Rodríguez2019-02-143-6/+6
|
* Remove now unnecessary `lack_errors` matcherDavid Rodríguez2019-02-143-4/+4
| | | | | Since the errors are checked on their own stream, no filtering is needed.
* Split stderr and stdout in specsDavid Rodríguez2019-02-1420-146/+129
|
* Fix typoDavid Rodríguez2019-02-141-1/+1
|
* Spec behaves consistenly across OS's apparentlyDavid Rodríguez2019-02-121-1/+1
|
* Stop leaking to system rubygems on subprocessesDavid Rodríguez2019-02-121-10/+8
| | | | | | | | | | | In order to be able to test against different versions of rubygems, we prepend our local copy of rubygems to the $LOAD_PATH. This is done as early as possible, inside each binstubs through [this helper file]. However, some subprocesses overwrite the `RUBYOPT` env variable, thus leaking to the system copy of rubygems again. Since we already [prepend the hacks file] to `RUBYOPT` in the main helper, while also preserving the previous value, this "customized environments" are not needed.
* Properly restrict rubygems version for failing specsDavid Rodríguez2019-02-102-2/+2
| | | | | These specs need https://github.com/rubygems/rubygems/pull/1527 to pass, so restrict them to rubygems version containing that.
* Merge #6931Bundlerbot2019-01-291-0/+9
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6931: Add patch option in bundle config r=greysteil a=ankitkataria ### What was the end-user problem that led to this PR? Issue #5994 ### What was your diagnosis of the problem? As mentioned by @indirect I added a `patch` option in the bundler config, which by default is false. If set to true, patch level update are preferred if no update levels are specified. ### What is your fix for the problem, implemented in this PR? A patch level config option which can be opted into. Co-authored-by: Ankit Kataria <ankitkataria28@gmail.com>
| * change prefer to patch_prefer and updated help textAnkit Kataria2019-01-271-2/+2
| |
| * add patch option in bundle configAnkit Kataria2019-01-241-0/+9
| |
* | Update the additional versions of rake in rspec examples.update-default-version-of-templateSHIBATA Hiroshi2019-01-242-5/+5
| |
* | Fixed failing examples.SHIBATA Hiroshi2019-01-241-3/+3
|/
* make system_bundle_bin_path helper and resolve failing tests for ruby < 2.6Colby Swandale2018-12-281-1/+2
|
* Followed up https://github.com/bundler/bundler/pull/6743SHIBATA Hiroshi2018-11-161-2/+2
| | | | | #6743 was failed with ruby core repository and ignored working example. Fixed them.
* Merge #6743Bundlerbot2018-11-167-13/+16
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6743: Support file structure of ruby core repository. r=hsbt a=hsbt ### What was the end-user problem that led to this PR? In the ruby core repository, I put bundler executable and bundler libraries under the `bin` and `lib` directories. It breaks the current behavior. ### What is your fix for the problem, implemented in this PR? Support the structure of ruby core repository. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
| * To use helper method instead of env variables.SHIBATA Hiroshi2018-11-011-1/+1
| |
| * Backport from ruby coreSHIBATA Hiroshi2018-11-015-23/+23
| |
| * Added ruby_core filtering condition with some examples.SHIBATA Hiroshi2018-10-207-27/+27
| | | | | | | | The ruby core repository couldn't invoke its examples.
| * Added to support BUNDLE_RUBY and BUNDLE_GEM environmental variables.SHIBATA Hiroshi2018-10-201-1/+4
| | | | | | | | They are replaced build binary on ruby core repository.
* | Merge #6714Bundlerbot2018-11-061-13/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6714: Spec reset state and refactorings r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that while working on #6713, I noticed several issues like order dependent failures, situations hard to debug, or specs doing too much and taking longer than they should. ### What was your diagnosis of the problem? My diagnosis was that: * Sometimes specs leak settings and env variable modifications. * When a hang happens inside a subprocess, it's hard to debug because logging is not printed out anywhere. * Some specs create unnecessary gemfiles and run `bundle install` multiple times unnecessarily. ### What is your fix for the problem, implemented in this PR? My fix for state leaks is to reset state after each spec, for the hangs is to reorder some lines in the `sys_exec` helper (https://github.com/bundler/bundler/commit/b305a5b2524a6457b05a9d39e9526f75c98a0752), and for the unnecessary operations, to refactor the specs to avoid them. ### Why did you choose this fix out of the possible options? I chose this fix because it seems like the best way to alleviate the issues found. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Reuse `install_gemfile` helperDavid Rodríguez2018-10-031-15/+5
| | |
| * | Move gemfile write to the specs that need itDavid Rodríguez2018-10-031-12/+47
| | | | | | | | | | | | | | | | | | If a set of specs need the Gemfile, they also need to `bundle install` it, so it's more readable to move those together, and also more efficient since we don't create Gemfiles that are not necessary.
| * | Reword spec so it reads betterDavid Rodríguez2018-10-031-1/+1
| | |
* | | Merge #6769Bundlerbot2018-10-301-0/+24
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6769: Fix `remove` when block method appears in gem name r=segiddins a=dduugg Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? https://github.com/bundler/bundler/issues/6768 ### What was your diagnosis of the problem? `remove_nested_blocks` considers any appearance of text matching a block method (`group source env install_if`) to be an occurrence of a nested block. ### What is your fix for the problem, implemented in this PR? `remove_nested_blocks` should only reduce the scope of where a nested block method can occur. ### Why did you choose this fix out of the possible options? Another approach would use word delimiters rather than `starts_with?` to find nested block methods, but this is probably fine. Co-authored-by: Douglas Eichelberger <dduugg@gmail.com>
| * | | Add testDouglas Eichelberger2018-10-291-0/+24
| | |/ | |/|
* | | Remove more unnecessary stuffremove_old_rubygems_stuff_from_specsDavid Rodríguez2018-10-261-2/+0
| | |
View Lorry Controller Status