summaryrefslogtreecommitdiff
path: root/spec/lock
Commit message (Collapse)AuthorAgeFilesLines
* Bump rake version to 13.0 everywherebump_rakeDavid Rodríguez2020-02-211-2/+2
|
* Extract `bundled_app_lock` path helperDavid Rodríguez2020-01-121-14/+14
|
* Skip the rest of the failures on WindowsDavid Rodríguez2020-01-071-0/+4
|
* Remove unnecessary rubygems require'sDavid Rodríguez2019-11-111-2/+0
|
* Normalize "bundle cache" vs "bundle package"normalize_bundle_cacheDavid Rodríguez2019-10-201-1/+1
| | | | | | | Use the preferred `bundle cache` everywhere, but leave package as an alias. Remove duplicated tests.
* Always set `cache_all` via config during testsDavid Rodríguez2019-07-241-1/+2
| | | | | So that the behavior is the same regardless of the tested bundler version.
* Fully remove compatibility guardremove_compatibility_guardDavid Rodríguez2019-07-091-2/+0
|
* Normalize file:// handling in specsDavid Rodríguez2019-06-111-70/+70
|
* Slight rewording for consistency with other specsdowngrade_version_mismatches_to_warningsDavid Rodríguez2019-04-271-1/+1
|
* Remove `simulate_bundler_version` from lockfile specsDavid Rodríguez2019-04-271-38/+58
| | | | | | The simulation is not very friendly because it needs to happen before `hax.rb` is loaded so, for example, it won't be applied to the lockfile platforms.
* Remove hard errors on version mismatchesDavid Rodríguez2019-04-271-27/+0
| | | | This is already short-circuit by rubygems' bundler version finder.
* Merge unnecessarily split specsDavid Rodríguez2019-04-271-49/+1
|
* Remove duplicated specDavid Rodríguez2019-04-271-38/+0
| | | | | This is essentially the same as "errors if the current is a major version older than lockfile's bundler version".
* s/last_command.stderr/err/David Rodríguez2019-04-121-3/+3
|
* Unify stderr helpersDavid Rodríguez2019-04-121-3/+3
|
* Move on to bundler 3David Rodríguez2019-04-111-8/+8
| | | | | | * Drop bundler 1 stuff from tests. * Move all feature flags to bundler 3 (like they are in 2-0-stable) and get them tested.
* Move multiple global source removal to bundler 3David Rodríguez2019-04-081-2/+2
| | | | And fix specs.
* Merge lockfile spec filesmerge_lockfile_specsDavid Rodríguez2019-04-032-1400/+170
|
* Merge #7089Bundlerbot2019-04-021-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7089: Normalize file URIs in spec's lockfiles r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that bumping bundler's version in #7088 made a lockfile spec fail. ### What was your diagnosis of the problem? My diagnosis was that there was a combination of bugs that was making this spec pass, but the spec was incorrect. ### What is your fix for the problem, implemented in this PR? My fix is to change the test version the spec uses to not hit https://github.com/rubygems/rubygems/issues/2595, and thus reproduce the failure. And then fix the spec that was incorrect because the lockfile written had different URLs (`file://localhost/<stuff>`) from the lockfile we were checking against (`file://<stuff>`), thus tricking `bundle install` into thinking something had changed, and thus making it rewrite it with an incorrect bundler version. ### Why did you choose this fix out of the possible options? I chose this fix because it makes #7088 pass and it reduces surprises. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Fix spec about lockfile writingnormalize_uris_in_lockfilesDavid Rodríguez2019-04-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change is simple but not easy to explain. What this test does is to ensure that if bundle install doesn't change anything, then the bundler version in the lockfile does not get rewritten. Whereas this test was passing, the implementation was wrong, but two bugs were "compesating for each other" and making it pass. The explanation is the following: Due to a regression in rubygems, in rubygems 3+ "2.0.0.0.a" is considered higher than "2.0.0.dev". This changes the test because bundler will never dowgrade the bundler version in a lockfile, so even if the lockfile gets rewritten, it will still keep "2.0.0.0.a", since it's considered higher. However, if we change the test to use "2.0.0.a" instead of "2.0.0.dev", then the test starts failing and shows the bug in the test. The bug is that the lock file in the test is written with "file://localhost" style URLs. However, the lockfile that would be generated would contain "file://" style URLs. This would trick bundler into thinking that something has been changed by `bundle install`, so it will rewrite the lock file, use "2.0.0.dev" as the locked bundler version, and cause the test to fail.
* | Remove lockfile incompatibility due to a settingseparate_rubygems_sources_in_lockfileDavid Rodríguez2019-03-021-43/+43
|/ | | | | | The `lockfile_uses_separate_rubygems_sources` was causing a lockfile incompatibility but in my opinion, this incompatibility is not necessary in the general case.
* Merge #6971Bundlerbot2019-02-242-2/+6
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6971: Fix warning message about bundler version r=colby-swandale a=deivid-rodriguez Fixes #6909. ### What was the end-user problem that led to this PR? The problem was that we're recommending a command to make a warning go away that doesn't really make the warning go away. ### What was your diagnosis of the problem? My diagnosis was that the current recommendation installs the latest bundler, which might not be the same as the version the lock file was created with. If it's not the same, the warning will not go away. ### What is your fix for the problem, implemented in this PR? My fix is to recommend installing exactly the version the lockfile was created with. ### Why did you choose this fix out of the possible options? I chose this fix because it's really simple and it should work. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Fix warning message about bundler versionfix_upgrade_instructionsDavid Rodríguez2019-02-182-2/+6
| | | | | | | | | | | | | | To actually make the warning go away, we need to recommend exactly installing the locked version. Otherwise the latest version gets installed, but not used to being a different major than the one locked, so the warning stays.
* | Use newest interface to `bundle config` everywhereDavid Rodríguez2019-02-192-2/+2
|/
* Fix 1.x specscheck_out_only_in_specsDavid Rodríguez2019-02-141-2/+2
|
* Split stderr and stdout in specsDavid Rodríguez2019-02-142-11/+11
|
* Update the additional versions of rake in rspec examples.update-default-version-of-templateSHIBATA Hiroshi2019-01-242-4/+4
|
* fix breaking bundler 1 spec for ruby 2.6 with RG 2.7segiddins/ruby-2.6Colby Swandale2018-12-291-3/+3
|
* Backport from ruby coreSHIBATA Hiroshi2018-11-011-1/+1
|
* Modify localhost variable when defining URI::File. It will be provided from ↵SHIBATA Hiroshi2018-06-152-2/+2
| | | | Ruby 2.6.
* Added hostname for file protocol in GemfileSHIBATA Hiroshi2017-12-281-67/+67
|
* Fixed failing examples with Ruby 2.5.SHIBATA Hiroshi2017-12-111-66/+66
| | | | | It's introduced by URI::Generic channges. https://github.com/ruby/ruby/commit/ed48bfa5e8770a345424abd7f24f94ea9bbf5973
* Completely remove the package --all option on 2.0 and force its behaviorseg-bundler-2-defaultsSamuel Giddins2017-08-282-4/+4
|
* fix tests/functionality breaking with new deprecation errorseg-deprecations-hard-error-in-2Colby Swandale2017-08-201-1/+1
|
* Allow ignoring the compatibilty guard in specsSamuel Giddins2017-08-172-0/+4
| | | | | | # Conflicts: # spec/install/bundler_spec.rb # spec/other/compatibility_guard_spec.rb
* Set forgotten command line options via config in 2.0Samuel Giddins2017-07-191-1/+1
|
* Update specs for the specific platform being added to the lockfileSamuel Giddins2017-07-051-55/+56
| | | | Also ensure the resolver processes specs in the correct order for error messages
* Update specs that simulate 2.0 lockfiles to include the specific platformSamuel Giddins2017-07-051-0/+2
|
* More bundler 2 spec fixesseg-remove-rubygems-aggregateSamuel Giddins2017-06-271-1/+29
|
* Get the Bundler 2 specs passing with transitive source pinningSamuel Giddins2017-06-232-55/+1449
|
* Get the 2.0 specs passing under 2.0Samuel Giddins2017-06-231-7/+9
|
* Specify `--require spec_helper` in .rspecKoichi ITO2017-05-032-2/+0
|
* Support rubygems that print dep type in specsSamuel Giddins2017-04-131-1/+1
|
* Avoid deadlocking when installing with a lockfile missing dependenciesSamuel Giddins2017-04-131-0/+23
|
* [Source::Path] Don’t store cache paths in the lockfileseg-install-frozen-gemspec-deps-changedSamuel Giddins2017-02-101-0/+30
|
* Disable RSpec monkey patchingSamuel Giddins2017-01-152-2/+2
|
* fix specs for bundler version warning with version numbersJonathan Rochkind2016-08-151-2/+2
|
* Remove expect_err from the specs & print all output on a spec failureSamuel Giddins2016-08-031-1/+1
|
* Use `include_gem` as the matcher nameSamuel Giddins2016-08-022-8/+8
|
* Remove focus from the lockfile specSamuel Giddins2016-08-021-1/+1
|
View Lorry Controller Status