summaryrefslogtreecommitdiff
path: root/spec/quality_spec.rb
Commit message (Collapse)AuthorAgeFilesLines
* Add CODE_OF_CONDUCT to exempted files in quality specCoraline Ada Ehmke2020-02-171-1/+1
|
* Remove global directory switching from specstests/less_flakynessDavid Rodríguez2020-01-121-75/+55
| | | | | | | | `Dir.chdir` is not thread safe, so it makes our parallel specs flaky. Instead, use the following alternatives: * Use `:chdir` parameter to `Open3` methods for specs that shell out. * Stub `find_gemfile` or other relevant helpers for unit tests.
* Make warnings spec independent of LOAD_PATHDavid Rodríguez2020-01-121-3/+3
|
* Extract `man_tracked_files` path helperDavid Rodríguez2020-01-121-1/+1
|
* Extract `in_repo_root`David Rodríguez2020-01-051-10/+10
|
* Fix some bundler specs (#2380)David Rodríguez2019-08-231-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * These seem to consistenly pass already * Show actual command when running `make test-bundler` Current the setup command that installs the necessary gems for testing bundler was printed, but not the actual command that runs the tests. That was a bit confusing. * Borrow trick from setproctitle specs * A title that long doesn't get set sometimes No idea why, but the test doesn't need that the title is that long. * Fix most gem helper spec ruby-core failures * Fix the rest of the gem helper failures * Fix version spec by improving the assertion * Remove unnecessary `BUNDLE_RUBY` environment var We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name because bundler considers `BUNDLE_*` variables as settings. * Rename `BUNDLE_GEM` to `GEM_COMMAND` This is more descriptive I think, and also friendlier for bundler because `BUNDLE_` env variables are interpreted by bundler as settings, and this is not a bundler setting. This fixes one bundler spec failure in config specs against ruby-core. * Fix quality spec when run in core Use the proper path helper. * Fix dummy lib builder to never load default gems If a dummy library is named as a default gem, when requiring the library from its executable, the default gem would be loaded when running from core, because in core all default gems share path with bundler, and thus they are always in the $LOAD_PATH. We fix the issue by loading lib relatively inside dummy lib executables. * More exact assertions Sometimes I have the problem that I do some "print debugging" inside specs, and suddently the spec passes. This happens when the assertion is too relaxed, and the things I print make it match, specially when they are simple strings like "1.0" than can be easily be part of gem paths that I print for debugging. I fix this by making a more exact assertion. * Detect the correct shebang when ENV["RUBY"] is set * Relax assertion So that the spec passes even if another paths containing "ext" are in the load path. This works to fix a ruby-core issue, but it's a better assertion in general. We just want to know that the extension path was added. * Use folder structure independent path helper It should fix this spec for ruby-core. * Fix the last failing spec on ruby-core * Skip `bundle open <default_gem>` spec when no default gems
* Extract yet another helper methodDavid Rodríguez2019-08-161-9/+1
|
* Extract a `with_root_gemspec` helperDavid Rodríguez2019-08-161-7/+1
|
* Only chdir when necessaryDavid Rodríguez2019-08-161-16/+14
|
* Make sure gem has been built before deleteng itDavid Rodríguez2019-08-161-11/+13
|
* Cleanup in a location independent wayDavid Rodríguez2019-08-161-1/+1
|
* Remove obvious commentDavid Rodríguez2019-08-161-1/+0
|
* Remve another unneeded `to_s`David Rodríguez2019-08-161-1/+1
| | | | `FileUtils.rm` supports a `Pathname` argument.
* Remove unneeded `to_s` callsDavid Rodríguez2019-08-161-1/+1
| | | | They are implicit inside `gem_command!`.
* Extract a `lib_tracked_files` path helperDavid Rodríguez2019-08-161-4/+0
|
* Rename a variableDavid Rodríguez2019-08-161-4/+4
| | | | Otherwise I get conflicts when extracting the helper.
* Extract a `tracked_files` path helperDavid Rodríguez2019-08-161-4/+0
|
* Rename some variablesDavid Rodríguez2019-08-161-19/+19
| | | | | | I want to extract these to path helper methods, but the name `files` conflict with some builder methods that are also available at the same level.
* Remove unexistent file from exemptionsDavid Rodríguez2019-08-101-1/+1
|
* Remove unexistent folder from exemptionsDavid Rodríguez2019-08-101-1/+1
|
* Commit man pages to source controlDavid Rodríguez2019-08-101-4/+3
| | | | | | | | | | | | | | This has the benefit that: * Allows the installation of bundler as a default gem from rubygems to include man pages. * Removes the need to build man pages during our tests. * Makes working with the manifest easier, because we only have source controlled files, and not a mix of source control and generated files. To make sure they never fall out of sync, we replace the previous `man:build` CI task with a `man:check` task that makes sure the generated man pages are up to date.
* Merge #7226Bundlerbot2019-07-241-25/+47
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7226: Improve quality specs r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? I'm not really sure of the exact context when I made these changes, but I recall I was getting some invalid encoding errors somehow, and they turned out to be an estraneous `’` quote in one of the documentation files. ### What was your diagnosis of the problem? My diagnosis was that we should not include this character anywhere, but instead use regular quotes. ### What is your fix for the problem, implemented in this PR? My fix is to add a quality spec for this, and while I was at it, I added some improvements to quality specs in general. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Check for straneous quotesimprove_quality_specsDavid Rodríguez2019-07-101-0/+25
| | | | | | | | And use single quotes consistenly.
| * Remove unnecessary lineDavid Rodríguez2019-07-101-1/+0
| | | | | | | | It contains a typo, so it can't be needed.
| * Tweak some quality specs to check more filesDavid Rodríguez2019-07-101-8/+8
| |
| * Refactor setting the encoding in quality specsDavid Rodríguez2019-07-101-13/+14
| | | | | | | | Instead of setting the encoding globally, set it when reading the files.
| * This seems to pass for meDavid Rodríguez2019-07-101-3/+0
| |
* | Remove `cache_command_is_package` feature flagDavid Rodríguez2019-07-151-1/+0
|/ | | | | So that we handle the removal of `bundle cache` just like we'll handle the removal of `bundle show` and `bundle console`.
* Fully switch to https sourceshttps_sourcesDavid Rodríguez2019-04-241-1/+0
|
* Add spec for using relative requiresrequire_relativeDavid Rodríguez2019-04-221-0/+16
|
* Add missing requireDavid Rodríguez2019-04-221-0/+2
| | | | So that the spec can be run in isolation.
* Merge #7128Bundlerbot2019-04-141-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7128: Backport to workaround from ruby core. r=deivid-rodriguez a=hsbt ### What was the end-user problem that led to this PR? The current master branch couldn't invoke with the ruby core repository. ### What was your diagnosis of the problem? 1. We need to add explicitly declare `rspec` in spec_helper.rb 2. Some examples were failed on ruby core repository. ### What is your fix for the problem, implemented in this PR? 1. simply added. 2. update the `ruby_repo` labels for skipping to run. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
| * Update ruby_repo filter with the latest ruby-core implementaion.SHIBATA Hiroshi2019-04-141-1/+1
| |
* | s/last_command.stderr/err/David Rodríguez2019-04-121-2/+2
|/
* Merge multisource related settingsDavid Rodríguez2019-04-081-1/+0
|
* Remove `console_command` settingremove_command_removal_settingsDavid Rodríguez2019-03-311-1/+0
| | | | | | | | This setting is not meant to be used by end users. The `console` command is going away and we plan to fully remove the code once we only have to maintain bundler 3 or higher versions. Adding a setting makes it look like the presence of this command is something "configurable", but it's not.
* Remove `viz_command` settingDavid Rodríguez2019-03-311-1/+0
| | | | | | | | This setting is not meant to be used by end users. The `viz` command is going away and we plan to fully remove the code once we only have to maintain bundler 3 or higher versions. Adding a setting makes it look like the presence of this command is something "configurable", but it's not.
* Unify the certificates for rubygems.org to rubygems store.SHIBATA Hiroshi2019-03-141-1/+1
| | | | | * Removed CertificateManager and related rake tasks. * Removed the certificates from bundler internal.
* github.https setting is booleanDavid Rodríguez2019-03-121-0/+1
|
* Remove git subshelling from gemspecDavid Rodríguez2019-03-051-0/+12
|
* Remove more unnecessary rubygems version checksDavid Rodríguez2019-02-251-7/+3
|
* Fixed cop failuresSHIBATA Hiroshi2019-02-201-1/+1
|
* The ruby core applied the difference structure from bundler upstreamSHIBATA Hiroshi2019-02-191-3/+11
| | | | repository. We need to modify a configuration for test-bundler.
* Fix redefinition warningtest_warningDavid Rodríguez2019-02-171-8/+0
|
* ignore RubyGems warnings about deprecated methods in version.rbColby Swandale2018-12-291-1/+5
|
* Backport from ruby coreSHIBATA Hiroshi2018-11-011-16/+23
|
* Added ruby_core filtering condition with some examples.SHIBATA Hiroshi2018-10-201-8/+8
| | | | The ruby core repository couldn't invoke its examples.
* Merge tag 'v1.16.0'Samuel Giddins2017-10-311-0/+3
|\ | | | | | | Version 1.16.0
| * Properly handle unsafe YAML warnings in specs on Ruby 1.8.7Samuel Giddins2017-10-301-0/+3
| |
* | Create quality spec for docs in SpanishPatricia Arbona2017-09-071-1/+1
| |
View Lorry Controller Status