summaryrefslogtreecommitdiff
path: root/spec/support
Commit message (Collapse)AuthorAgeFilesLines
* Refresh all VCR cassettesrefresh_vcr_cassettesDavid Rodríguez2019-02-22708-414/+503
|
* Reword deprecation messagesDavid Rodríguez2019-02-211-1/+1
| | | | | | Including the version is confusing, in my opinion, because it's unclear whether it refers to the future version of removal, or to the current running version.
* Merge #6974Bundlerbot2019-02-201-2/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6974: Use newer list interface r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that our specs emit a lot of deprecations about the list command. ### What was your diagnosis of the problem? My diagnosis was that we are using the deprecated interface to the list command everywhere. ### What is your fix for the problem, implemented in this PR? My fix is to start using the new interface. If we don't use it ourselves, how could we be in a position to tell our users to start using it? ### Why did you choose this fix out of the possible options? I chose this fix because we should do this, at same point, and doing it now simplifies enabling deprecations. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * Use newest interface to `bundle config` everywhereDavid Rodríguez2019-02-191-2/+2
| |
* | Fixup r66984. Update the location of bundler gemspec.SHIBATA Hiroshi2019-02-201-1/+1
| | | | | | | | git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* | Fixed cop failuresSHIBATA Hiroshi2019-02-201-1/+1
| |
* | Use ENV["BUNDLE_GEM"] instead of gem command provided by system ruby.SHIBATA Hiroshi2019-02-191-1/+2
| | | | | | | | | | It break the examples of bundler. Because some examples detect the different version of system ruby than test target version like trunk.
* | The ruby core applied the difference structure from bundler upstreamSHIBATA Hiroshi2019-02-191-4/+8
|/ | | | repository. We need to modify a configuration for test-bundler.
* Fix redefinition warningtest_warningDavid Rodríguez2019-02-171-0/+8
|
* Remove now unnecessary `lack_errors` matcherDavid Rodríguez2019-02-141-7/+0
| | | | | Since the errors are checked on their own stream, no filtering is needed.
* Split stderr and stdout in specsDavid Rodríguez2019-02-141-2/+2
|
* Remove exception since MRI 1.9.3 is no longer supporteddependency_reviewDavid Rodríguez2019-02-131-4/+3
|
* Bump builder gem since we no longer support MRI 1.9.2David Rodríguez2019-02-131-2/+1
|
* Bump rack-test since we no longer support MRI 1.8.7David Rodríguez2019-02-131-3/+1
|
* Fix TODO note since linked issue seems closedDavid Rodríguez2019-02-131-3/+1
|
* Remove no longer relevant commentDavid Rodríguez2019-02-131-1/+0
| | | | Ruby 2.2.2 is no longer supported.
* Update the additional versions of rake in rspec examples.update-default-version-of-templateSHIBATA Hiroshi2019-01-241-1/+1
|
* Fixed failing examples.SHIBATA Hiroshi2019-01-241-1/+1
|
* Added condition for Object =~ comparison.SHIBATA Hiroshi2019-01-231-1/+1
|
* Merge #6793Bundlerbot2019-01-231-5/+0
|\ | | | | | | | | | | | | | | | | | | 6793: Removed exe/bundle_ruby and its example. r=hsbt a=hsbt Originated from #3489 `exe/bundle_ruby` was already removed from bundler's gemspec. We can remove it now. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
| * Removed exe/bundle_ruby and its example.SHIBATA Hiroshi2018-11-201-5/+0
| |
* | make system_bundle_bin_path helper and resolve failing tests for ruby < 2.6Colby Swandale2018-12-282-1/+5
| |
* | set `bundle` spec helper to load the system bundler binstub directly instead ↵Colby Swandale2018-12-281-1/+1
| | | | | | | | of depending on the $PATH
* | Following up ruby core changes.SHIBATA Hiroshi2018-11-271-1/+1
|/ | | | | * To use libexec instead of bin directory. * Restore exe direcotry for bundler.gemspec while running test suite.
* Merge #6743Bundlerbot2018-11-162-6/+22
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6743: Support file structure of ruby core repository. r=hsbt a=hsbt ### What was the end-user problem that led to this PR? In the ruby core repository, I put bundler executable and bundler libraries under the `bin` and `lib` directories. It breaks the current behavior. ### What is your fix for the problem, implemented in this PR? Support the structure of ruby core repository. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
| * Backport from ruby coreSHIBATA Hiroshi2018-11-012-14/+16
| |
| * rubocop -aSHIBATA Hiroshi2018-10-202-2/+3
| |
| * Added to support BUNDLE_RUBY and BUNDLE_GEM environmental variables.SHIBATA Hiroshi2018-10-202-5/+18
| | | | | | | | They are replaced build binary on ruby core repository.
* | Merge #6714Bundlerbot2018-11-061-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6714: Spec reset state and refactorings r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that while working on #6713, I noticed several issues like order dependent failures, situations hard to debug, or specs doing too much and taking longer than they should. ### What was your diagnosis of the problem? My diagnosis was that: * Sometimes specs leak settings and env variable modifications. * When a hang happens inside a subprocess, it's hard to debug because logging is not printed out anywhere. * Some specs create unnecessary gemfiles and run `bundle install` multiple times unnecessarily. ### What is your fix for the problem, implemented in this PR? My fix for state leaks is to reset state after each spec, for the hangs is to reorder some lines in the `sys_exec` helper (https://github.com/bundler/bundler/commit/b305a5b2524a6457b05a9d39e9526f75c98a0752), and for the unnecessary operations, to refactor the specs to avoid them. ### Why did you choose this fix out of the possible options? I chose this fix because it seems like the best way to alleviate the issues found. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
| * | Hangs in specs improvedDavid Rodríguez2018-10-031-1/+1
| | | | | | | | | | | | | | | | | | | | | When working on a bug, I was getting a hang inside the subprocess of a specs, and it was hard to debug because any logging I added was not visible. This reording makes logging visible and can make it easier to troubleshoot these cases.
* | | Remove unnecessary stuff from specsDavid Rodríguez2018-10-263-16/+4
| |/ |/| | | | | Since we no longer test against rubygems versions that old.
* | Make RakeTask spec:deps OS agnosticLeo Arnold2018-10-172-10/+10
| | | | | | | | | | | | | | | | @segiddins encouraged contributions towards support for Windows https://github.com/bundler/bundler/issues/5992#issuecomment-326809543 As a first step towards this goal this commit fixes file path specification in the first pieces of Ruby code called when setting up a test environment.
* | Merge #6742Bundlerbot2018-10-172-1/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6742: Use helper method instead of hard-code path. r=colby-swandale a=hsbt ### What was the end-user problem that led to this PR? In ruby core repository, We need to replace executable file like `ruby`, `rake`, `gem`. ### What is your fix for the problem, implemented in this PR? This pull request makes hard-coded executable file to the helper methods. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
| * | rubocop -aSHIBATA Hiroshi2018-10-161-1/+1
| | |
| * | added full path of rake executable.SHIBATA Hiroshi2018-10-161-1/+1
| | |
| * | Added missing helper method for rakeSHIBATA Hiroshi2018-10-161-0/+4
| | |
| * | Use helper method instead of hard-code path.SHIBATA Hiroshi2018-10-161-1/+1
| | |
* | | Removed win32-open3 workaround.SHIBATA Hiroshi2018-10-161-0/+2
|/ / | | | | | | | | win32-open3 gem was required Ruby 1.8 with Windows environment. Because RubyInstaller2 only provides the version of Ruby 2.1+.
* | Remove "no-color" tweaks from specsDavid Rodríguez2018-10-011-3/+0
|/ | | | | I don't know why it was there, and it makes things more complicated with dealing and running assertions on ARGV.
* [GemVersionPromoter] Prefer non-pre-release versionssegiddins/6684-gvp-prefer-non-presSamuel Giddins2018-09-121-0/+1
|
* Fallback to the standard RUBY_ENGINE_VERSION constantBenoit Daloze2018-09-091-1/+1
|
* Let updater retry on HTTPRequestedRangeNotSatisfiable (416)Maxime Lapointe2018-08-271-0/+34
| | | | | | Fixes issues when gems get yanked, which leads to the cached infos being longer than what is on the server. Being longer, the compact index api just return a 416, and bundler would fallback to the dependency API. Retrying to the compact index with no range would fix the issue. This is what this fix does.
* Fix error sortingSamuel Giddins2018-08-061-2/+2
| | | | Also avoid mutating the original exception message to generate the message we want
* rubocop -ano-documentSHIBATA Hiroshi2018-07-121-3/+3
|
* To use --no-document option after RubyGems 2.0. RubyGems will remove --no-ri ↵SHIBATA Hiroshi2018-07-122-2/+10
| | | | and --no-rdoc options at RubyGems 3.0
* Add heredoc string to expected_gemfileAgrim Mittal2018-06-281-0/+4
|
* More flexible mocking of specificationDavid Rodríguez2018-06-251-1/+1
| | | | | So we can change the signature in rubygems without breaking bundler's specs.
* typo fixskip-remove-auth-with-file-protocolSHIBATA Hiroshi2018-06-151-1/+1
|
* Move normalize methods to helper methods from rspec example files.SHIBATA Hiroshi2018-06-152-3/+11
|
* Modify localhost variable when defining URI::File. It will be provided from ↵SHIBATA Hiroshi2018-06-151-2/+3
| | | | Ruby 2.6.