| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
Including the version is confusing, in my opinion, because it's unclear
whether it refers to the future version of removal, or to the current
running version.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6974: Use newer list interface r=indirect a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that our specs emit a lot of deprecations about the list command.
### What was your diagnosis of the problem?
My diagnosis was that we are using the deprecated interface to the list command everywhere.
### What is your fix for the problem, implemented in this PR?
My fix is to start using the new interface. If we don't use it ourselves, how could we be in a position to tell our users to start using it?
### Why did you choose this fix out of the possible options?
I chose this fix because we should do this, at same point, and doing it now simplifies enabling deprecations.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
|
| | |
|
| |
| |
| |
| | |
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
| | |
|
| |
| |
| |
| |
| | |
It break the examples of bundler. Because some examples detect the
different version of system ruby than test target version like trunk.
|
|/
|
|
| |
repository. We need to modify a configuration for test-bundler.
|
| |
|
|
|
|
|
| |
Since the errors are checked on their own stream, no filtering is
needed.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Ruby 2.2.2 is no longer supported.
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6793: Removed exe/bundle_ruby and its example. r=hsbt a=hsbt
Originated from #3489
`exe/bundle_ruby` was already removed from bundler's gemspec. We can remove it now.
Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
|
| | |
|
| | |
|
| |
| |
| |
| | |
of depending on the $PATH
|
|/
|
|
|
| |
* To use libexec instead of bin directory.
* Restore exe direcotry for bundler.gemspec while running test suite.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6743: Support file structure of ruby core repository. r=hsbt a=hsbt
### What was the end-user problem that led to this PR?
In the ruby core repository, I put bundler executable and bundler libraries under the `bin` and `lib` directories. It breaks the current behavior.
### What is your fix for the problem, implemented in this PR?
Support the structure of ruby core repository.
Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
|
| | |
|
| | |
|
| |
| |
| |
| | |
They are replaced build binary on ruby core repository.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
6714: Spec reset state and refactorings r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that while working on #6713, I noticed several issues like order dependent failures, situations hard to debug, or specs doing too much and taking longer than they should.
### What was your diagnosis of the problem?
My diagnosis was that:
* Sometimes specs leak settings and env variable modifications.
* When a hang happens inside a subprocess, it's hard to debug because logging is not printed out anywhere.
* Some specs create unnecessary gemfiles and run `bundle install` multiple times unnecessarily.
### What is your fix for the problem, implemented in this PR?
My fix for state leaks is to reset state after each spec, for the hangs is to reorder some lines in the `sys_exec` helper (https://github.com/bundler/bundler/commit/b305a5b2524a6457b05a9d39e9526f75c98a0752), and for the unnecessary operations, to refactor the specs to avoid them.
### Why did you choose this fix out of the possible options?
I chose this fix because it seems like the best way to alleviate the issues found.
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When working on a bug, I was getting a hang inside the subprocess of a
specs, and it was hard to debug because any logging I added was not
visible. This reording makes logging visible and can make it easier to
troubleshoot these cases.
|
| |/
|/|
| |
| | |
Since we no longer test against rubygems versions that old.
|
| |
| |
| |
| |
| |
| |
| |
| | |
@segiddins encouraged contributions towards support for Windows
https://github.com/bundler/bundler/issues/5992#issuecomment-326809543
As a first step towards this goal this commit fixes file path specification
in the first pieces of Ruby code called when setting up a test environment.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
6742: Use helper method instead of hard-code path. r=colby-swandale a=hsbt
### What was the end-user problem that led to this PR?
In ruby core repository, We need to replace executable file like `ruby`, `rake`, `gem`.
### What is your fix for the problem, implemented in this PR?
This pull request makes hard-coded executable file to the helper methods.
Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| | |
win32-open3 gem was required Ruby 1.8 with Windows environment.
Because RubyInstaller2 only provides the version of Ruby 2.1+.
|
|/
|
|
|
| |
I don't know why it was there, and it makes things more complicated with
dealing and running assertions on ARGV.
|
| |
|
| |
|
|
|
|
|
|
| |
Fixes issues when gems get yanked, which leads to the cached infos being longer than what is on the server.
Being longer, the compact index api just return a 416, and bundler would fallback to the dependency API.
Retrying to the compact index with no range would fix the issue. This is what this fix does.
|
|
|
|
| |
Also avoid mutating the original exception message to generate the message we want
|
| |
|
|
|
|
| |
and --no-rdoc options at RubyGems 3.0
|
| |
|
|
|
|
|
| |
So we can change the signature in rubygems without breaking bundler's
specs.
|
| |
|
| |
|
|
|
|
| |
Ruby 2.6.
|