| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
transitive children
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| | |
[CLI] Dont override Kernel#gem for bundle gem
Should fix #5296
Since `Kernel#require` calls into `Kernel#gem` as an instance method on `self`, overriding the `gem` method can lead to bad things happening
|
| | |
|
|/ |
|
|\
| |
| |
| |
| |
| |
| |
| | |
Support :mri_25 platform and its variations
The next ruby version is decided to be 2.5 🎉 https://github.com/ruby/ruby/commit/1a47fcadd675601c5b9c4e69d49def28fc3b61af
I'm not requesting you the bundler team to rush for a new release for this, but I guess it's not too early to have this definition in master.
|
| | |
|
|\ \
| | |
| | |
| | | |
[Worker] Fail gracefully when creating threads fails
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Document 1.14 platform changes
See https://github.com/bundler/bundler/issues/4853
@indirect feel free to add any other docs you think might be helpful to this branch
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
Don't include dev deps in Index#dependency_names
See #5256
|
| | | | |
|
| | |/
| |/| |
|
| |/
|/| |
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
4854 gemnotfound error
Fixes broken test
Wanting to help out, I was on the outlook for something easy to fix in bundler. I stumbled upon this issue #4854, which was already tackled by @b-ggs but somehow not merged yet. I went on to check whether I could do something. Here's what I've come up with:
@b-ggs' PR included everything to solve the issue, but introduced the use of `Bundler.app_cache` in the resolver. This works out just fine until you run `bundle plugin install`, which does not seem to require a Gemfile. `Bundler.app_cache` however calls `root`, which then again tries to find a Gemfile. This obviously fails and raises a `GemfileNotFound` exception. The error message "Could not locate Gemfile or .bundle/ directory" starts very similar to the one expected in the failing test ("Could not find"). This however, is a completely different error.
The solution is now is to rescue the GemfileNotFound error when it comes up to here.
All credit for solving the issue goes to @b-ggs and his PR here: https://github.com/bundler/bundler/pull/4865
|
| |\ |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Specs for multiple platform bug fix in outdated.
This supersedes PR #4734, which fixed a bug but didn't have proper spec
coverage. Since that PR was submitted, a different commit (291a807c in
PR #5176) fixed a similar bug at the same time. That caused a merge
conflict in #4734. It was unknown if the same fix fixed both bugs,
since there were no successfully implemented specs. These specs show
that the bug was properly fixed.
These specs were mostly already implemented by @b-ggs, just needed a
little additional guidance.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This supersedes PR #4734, which fixed a bug but didn't have proper spec
coverage. Since that PR was submitted, a different commit (291a807c in
PR #5176) fixed a similar bug at the same time. That caused a merge
conflict in #4734. It was unknown if the same fix fixed both bugs,
since there were no successfully implemented specs. These specs show
that the bug was properly fixed.
These specs were mostly already implemented by @b-ggs, just needed a
little additional guidance.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Random spec improvements
Called "sam has a flight and forgot to run `rake spec:deps`"
|
| | | | |
| | | | |
| | | | |
| | | | | |
This is so persistent will use our override class
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
This avoids loading rack, which conflicts with some specs
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | | |
Fix the specs on Ruby 2.4
|
| | | | | |
|
| |/ / / |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add a new line for before priring BundlerError errors
This PR is fixing a problem where the warnings and errors on a `bundle install` using an invalid source are not being put on a newline correctly.
```
› bundle install
Fetching source index from https://www.google.com/
Retrying fetcher due to error (2/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/
Retrying fetcher due to error (3/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/
Retrying fetcher due to error (4/4): Bundler::HTTPError Could not fetch specs from https://www.google.com/Could not fetch specs from https://www.google.com/
```
This is happening because the new lines for the warnings are being printed before the error itself. This behaviour is happening due to another UI problem, see https://github.com/bundler/bundler/commit/2ac26bc88ba30b28aba6e11c9b2d04cdb0276a25.
Maybe a better way of fixing this problem is to add a new line to the exception message itself rather then what i have submitted. Its a bit of a weird one.
Let me know.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`bundle update` post install messages
Currently post install messages are only displayed for `bundle install` not for `bundle update`. This PR fixes that so they're displayed for both, and includes a small refactor of some duplicated functionality between `install` and `update`
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
[Lock] Fix --add-platform ruby
Necessary since the ruby platform is a string instead of a platform object
Closes #5230
|
| |/ / /
| | | |
| | | |
| | | | |
Necessary since the ruby platform is a string instead of a platform object
|