From 09d7f453125cc0535ed12c65be1a334efe4a759b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Wed, 24 Apr 2019 15:24:56 +0200 Subject: Remove coverage tracking for the time being The current numbers are misleading and coverage tracking doesn't work in most of the places since the current test suite is mostly based on spawning subprocesses, and coverage doesn't get properly tracked there. Let's revisit this in the future. --- .travis.yml | 5 ----- README.md | 1 - Rakefile | 4 ---- doc/contributing/HOW_YOU_CAN_HELP.md | 2 +- spec/spec_helper.rb | 2 -- spec/support/code_climate.rb | 26 -------------------------- 6 files changed, 1 insertion(+), 39 deletions(-) delete mode 100644 spec/support/code_climate.rb diff --git a/.travis.yml b/.travis.yml index 65ca9bb54b..8dbb06f355 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,11 +25,6 @@ notifications: rooms: - secure: JxBi7DDJGkIF/7f/FSN/HUHpvV4EKfQccZHTPd1b2pNJn3GXo6u+tNVbAw2WjxYzPyPQI3ZcYBCU9SEXp/i7VmG8uMzh8Kyildw+miSKYKVb90uYqcsXWzbxwyNBgJLvyDkzST45H5lgnyAicee3WkFes/WDZikIajbH7ztdb04= -addons: - code_climate: - repo_token: - secure: "TrzIv116JLGUxm6PAUskCYrv8KTDguncKROVwbnjVPKTGDAgoDderd8JUdDEXrKoZ9qGLD2TPYKExt9/QDl71E+qHdWnVqWv4HKCUk2P9z/VLKzHuggOUBkCXiJUhjywUieCJhI3N92bfq2EjSBbu2/OFHqWOjLQ+QCooTEBjv8=" - rvm: - 2.6.3 - 2.5.5 diff --git a/README.md b/README.md index b06d456df4..da7fd7c275 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,5 @@ [![Version ](https://img.shields.io/gem/v/bundler.svg?style=flat)](https://rubygems.org/gems/bundler) [![Build Status](https://img.shields.io/travis/bundler/bundler/master.svg?style=flat)](https://travis-ci.org/bundler/bundler) -[![Code Climate](https://img.shields.io/codeclimate/maintainability/bundler/bundler.svg?style=flat)](https://codeclimate.com/github/bundler/bundler) [![Inline docs ](http://inch-ci.org/github/bundler/bundler.svg?style=flat)](http://inch-ci.org/github/bundler/bundler) [![Slack ](http://bundler-slackin.herokuapp.com/badge.svg)](http://bundler-slackin.herokuapp.com) diff --git a/Rakefile b/Rakefile index 2fcdbff816..fbbd3365b6 100644 --- a/Rakefile +++ b/Rakefile @@ -71,10 +71,6 @@ namespace :spec do # Install the gems with a consistent version of RubyGems sh "gem update --system 3.0.3" - $LOAD_PATH.unshift("./spec") - require "support/rubygems_ext" - Spec::Rubygems::DEPS["codeclimate-test-reporter"] = "~> 0.6.0" if RUBY_VERSION >= "2.2.0" - # Install the other gem deps, etc Rake::Task["spec:deps"].invoke end diff --git a/doc/contributing/HOW_YOU_CAN_HELP.md b/doc/contributing/HOW_YOU_CAN_HELP.md index 68cbe85967..46cf33e65c 100644 --- a/doc/contributing/HOW_YOU_CAN_HELP.md +++ b/doc/contributing/HOW_YOU_CAN_HELP.md @@ -22,6 +22,6 @@ Generally, great ways to get started helping out with Bundler are: - improving existing code, including suggestions from [PullReview](https://www.pullreview.com/github/bundler/bundler/reviews/master) or [CodeClimate](https://codeclimate.com/github/bundler/bundler) - writing code (no patch is too small! fix typos or bad whitespace) - get started setting up your dev environment with [these instructions](../development/SETUP.md) - - backfilling [unit tests](https://github.com/bundler/bundler/tree/master/spec/bundler) for modules that lack [coverage](https://codeclimate.com/github/bundler/bundler/coverage) + - backfilling [unit tests](https://github.com/bundler/bundler/tree/master/spec/bundler) for modules that lack coverage. If nothing on those lists looks good, [talk to us](https://slack.bundler.io/), and we'll figure out what you can help with. We can absolutely use your help, no matter what level of programming skill you have at the moment. diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index e8e7cc9a1f..35cf8bfefb 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -30,8 +30,6 @@ ENV["BUNDLE_SPEC_RUN"] = "true" # Don't wrap output in tests ENV["THOR_COLUMNS"] = "10000" -Spec::CodeClimate.setup - module Gem def self.ruby=(ruby) @ruby = ruby diff --git a/spec/support/code_climate.rb b/spec/support/code_climate.rb deleted file mode 100644 index a15442cabe..0000000000 --- a/spec/support/code_climate.rb +++ /dev/null @@ -1,26 +0,0 @@ -# frozen_string_literal: true - -module Spec - module CodeClimate - def self.setup - require "codeclimate-test-reporter" - ::CodeClimate::TestReporter.start - configure_exclusions - rescue LoadError - # it's fine if CodeClimate isn't set up - nil - end - - def self.configure_exclusions - SimpleCov.start do - add_filter "/bin/" - add_filter "/lib/bundler/man/" - add_filter "/lib/bundler/vendor/" - add_filter "/man/" - add_filter "/pkg/" - add_filter "/spec/" - add_filter "/tmp/" - end - end - end -end -- cgit v1.2.1