From ca96316b97353b4344ba283be0051ef7e9d9a013 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Fri, 28 Jun 2019 11:06:03 +0200 Subject: Improve spec to be more realistic --- spec/bundler/source/git/git_proxy_spec.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/spec/bundler/source/git/git_proxy_spec.rb b/spec/bundler/source/git/git_proxy_spec.rb index 8ac0ae4dd0..c18490233d 100644 --- a/spec/bundler/source/git/git_proxy_spec.rb +++ b/spec/bundler/source/git/git_proxy_spec.rb @@ -128,17 +128,18 @@ RSpec.describe Bundler::Source::Git::GitProxy do context "when given a SHA as a revision" do let(:revision) { "abcd" * 10 } + let(:command) { "reset --hard #{revision}" } it "fails gracefully when resetting to the revision fails" do expect(subject).to receive(:git_retry).with(start_with("clone ")) { destination.mkpath } expect(subject).to receive(:git_retry).with(start_with("fetch ")) - expect(subject).to receive(:git).with("reset --hard #{revision}").and_raise(Bundler::Source::Git::GitCommandError, "command") + expect(subject).to receive(:git).with(command).and_raise(Bundler::Source::Git::GitCommandError, command) expect(subject).not_to receive(:git) expect { subject.copy_to(destination, submodules) }. to raise_error( Bundler::Source::Git::MissingGitRevisionError, - "Git error: command `git command` in directory #{destination} has failed.\n" \ + "Git error: command `git #{command}` in directory #{destination} has failed.\n" \ "Revision #{revision} does not exist in the repository #{uri}. Maybe you misspelled it?" \ ) end -- cgit v1.2.1