summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSage Weil <sage@newdream.net>2012-02-23 11:03:44 -0800
committerSage Weil <sage@newdream.net>2012-02-23 11:39:57 -0800
commit286df2db3ea4e7ba6522e2042685f0c971b3fa6d (patch)
treea0efd1aae11762d4f67bea6ad91d4e4852aee6ed
parent963dec82880717054c760a745cf93cc7b43112df (diff)
downloadceph-286df2db3ea4e7ba6522e2042685f0c971b3fa6d.tar.gz
crush: fix weight adjust for list, tree buckets
Fix the typo. Code now matches that for straw buckets. Reported-by: ZhuRongze <zrz4ceph@gmail.com> Signed-off-by: Sage Weil <sage@newdream.net>
-rw-r--r--src/crush/builder.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/crush/builder.c b/src/crush/builder.c
index dcf5a8b6457..c68fdf04eed 100644
--- a/src/crush/builder.c
+++ b/src/crush/builder.c
@@ -727,7 +727,7 @@ int crush_adjust_list_bucket_item_weight(struct crush_bucket_list *bucket, int i
if (i == bucket->h.size)
return 0;
- diff = weight = bucket->item_weights[i];
+ diff = weight - bucket->item_weights[i];
bucket->item_weights[i] = weight;
bucket->h.weight += diff;
@@ -752,7 +752,7 @@ int crush_adjust_tree_bucket_item_weight(struct crush_bucket_tree *bucket, int i
return 0;
node = crush_calc_tree_node(i);
- diff = weight = bucket->node_weights[node];
+ diff = weight - bucket->node_weights[node];
bucket->node_weights[node] = weight;
bucket->h.weight += diff;