diff options
| author | Yehuda Sadeh <yehuda@inktank.com> | 2013-08-12 10:05:44 -0700 |
|---|---|---|
| committer | Yehuda Sadeh <yehuda@inktank.com> | 2013-08-12 14:29:19 -0700 |
| commit | 2632846e24e3c26139e982e0a569951d25e1589b (patch) | |
| tree | d7d393129ee99247070ffc5812da506405a51d80 | |
| parent | cb50b5a7f1ab2d4e7fdad623a0e7769000755a70 (diff) | |
| download | ceph-2632846e24e3c26139e982e0a569951d25e1589b.tar.gz | |
rgw: fix multi delete
Fixes: #5931
Backport: bobtail, cuttlefish
Fix a bad check, where we compare the wrong field. Instead of
comparing the ret code to 0, we compare the string value to 0
which generates implicit casting, hence the crash.
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
| -rw-r--r-- | src/rgw/rgw_rest_s3.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/rgw/rgw_rest_s3.cc b/src/rgw/rgw_rest_s3.cc index bbf363804bd..8690dd8fdbe 100644 --- a/src/rgw/rgw_rest_s3.cc +++ b/src/rgw/rgw_rest_s3.cc @@ -1709,7 +1709,7 @@ void RGWDeleteMultiObj_ObjStore_S3::send_partial_response(pair<string,int>& resu s->formatter->open_object_section("Deleted"); s->formatter->dump_string("Key", result.first); s->formatter->close_section(); - } else if (result.first < 0) { + } else if (result.second < 0) { struct rgw_http_errors r; int err_no; |