summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>2013-05-14 19:07:29 +0200
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>2013-05-14 19:07:29 +0200
commitfb222a0a1c98a4141b6d0e79eac7a41c208f7147 (patch)
treed2132d766f68de33c6aca03680db55c4c70eeb08
parentc87788b69b82abaa9202e624d255033a0c5766b4 (diff)
downloadceph-fb222a0a1c98a4141b6d0e79eac7a41c208f7147.tar.gz
mds/Server.cc: fix possible NULL pointer dereference
Assert of straydn is NULL here. CID 1019558 (#1 of 1): Dereference after null check (FORWARD_NULL) var_deref_model: Passing null pointer "straydn" to function "CDentry::get_dir() const", which dereferences it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
-rw-r--r--src/mds/Server.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 3e89156cd93..46adf220021 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -7100,6 +7100,7 @@ void Server::_rename_rollback_finish(Mutation *mut, MDRequest *mdr, CDentry *src
if (destdn) {
CInode *oldin = destdn->get_linkage()->get_inode();
// update subtree map?
+ assert(straydn);
if (oldin && oldin->is_dir())
mdcache->adjust_subtree_after_rename(oldin, straydn->get_dir(), true);
}