summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Farnum <greg@inktank.com>2013-09-19 17:11:04 -0700
committerGreg Farnum <greg@inktank.com>2013-09-19 18:15:00 -0700
commita2d633bb209f0ba85d581783fec9bd10fb280e4f (patch)
tree9f9ebf534635b28492415b72d4477c8afc258463
parentf7f3005555a531095f70834372d1486e391c4681 (diff)
downloadceph-a2d633bb209f0ba85d581783fec9bd10fb280e4f.tar.gz
OpTracker: demand that a TrackedOp gets to own its Message for life.
Signed-off-by: Greg Farnum <greg@inktank.com>
-rw-r--r--src/common/TrackedOp.h2
-rw-r--r--src/osd/OpRequest.h4
2 files changed, 1 insertions, 5 deletions
diff --git a/src/common/TrackedOp.h b/src/common/TrackedOp.h
index 5d2abf591c4..94eb4e3f71e 100644
--- a/src/common/TrackedOp.h
+++ b/src/common/TrackedOp.h
@@ -140,7 +140,7 @@ protected:
virtual void init_from_message() {};
public:
- virtual ~TrackedOp() { if (request) request->put(); }
+ virtual ~TrackedOp() { assert(request); request->put(); }
utime_t get_arrived() const {
return received_time;
diff --git a/src/osd/OpRequest.h b/src/osd/OpRequest.h
index 9a40c1be219..88c4e7d4bc2 100644
--- a/src/osd/OpRequest.h
+++ b/src/osd/OpRequest.h
@@ -75,10 +75,6 @@ private:
OpRequest(Message *req, OpTracker *tracker);
public:
- ~OpRequest() {
- assert(request);
- }
-
bool been_queued_for_pg() { return hit_flag_points & flag_queued_for_pg; }
bool been_reached_pg() { return hit_flag_points & flag_reached_pg; }
bool been_delayed() { return hit_flag_points & flag_delayed; }